diff options
author | Pirama Arumuga Nainar <pirama@google.com> | 2020-02-20 15:08:30 -0800 |
---|---|---|
committer | George Burgess <gbiv@chromium.org> | 2020-02-28 17:33:01 +0000 |
commit | ee7e22c6435048f1b37db4d944e3b6f4c65a77e5 (patch) | |
tree | 248a02e46350a6df82cf83403e08475d6de82adf /compiler_wrapper/config.go | |
parent | 2495a9bb06590534a0b873e36285f06f10c107ba (diff) | |
download | toolchain-utils-ee7e22c6435048f1b37db4d944e3b6f4c65a77e5.tar.gz |
Change behavior of doubleBuildWithWNoError for Android
"Double build with -Wno-error" is always on in the Android useLlvmNext
wrapper and always off in the production wrapper. The warnings JSON is
written to $OUT_DIR/warnings_reports.
NFC for the ChromeOS configs.
Originally reviewed in https://android-review.googlesource.com/c/1242126.
BUG=b:149836702
TEST=go test
Change-Id: I5f1a43524772d991b5c64422189643cde61c3826
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2079547
Tested-by: Pirama Arumuga Nainar <pirama@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Diffstat (limited to 'compiler_wrapper/config.go')
-rw-r--r-- | compiler_wrapper/config.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/compiler_wrapper/config.go b/compiler_wrapper/config.go index 5f389684..70c27f06 100644 --- a/compiler_wrapper/config.go +++ b/compiler_wrapper/config.go @@ -14,6 +14,8 @@ type config struct { isAndroidWrapper bool // Whether to use ccache. useCCache bool + // Whether llvmNext wrapper. + useLlvmNext bool // Flags to add to gcc and clang. commonFlags []string // Flags to add to gcc only. @@ -83,6 +85,7 @@ func getConfig(configName string, useCCache bool, useLlvmNext bool, version stri return nil, newErrorwithSourceLocf("unknown config name: %s", configName) } cfg.useCCache = useCCache + cfg.useLlvmNext = useLlvmNext if useLlvmNext { cfg.clangFlags = append(cfg.clangFlags, llvmNextFlags...) } @@ -208,5 +211,5 @@ var androidConfig = &config{ gccFlags: []string{}, clangFlags: []string{}, clangPostFlags: []string{}, - newWarningsDir: "/tmp/fatal_clang_warnings", + newWarningsDir: "", } |