diff options
author | Bob Haarman <inglorion@google.com> | 2020-07-09 17:14:53 -0700 |
---|---|---|
committer | Bob Haarman <inglorion@chromium.org> | 2020-07-14 19:59:18 +0000 |
commit | 94fd622c652b7aa46f2ca24d3a0efe93c7fde040 (patch) | |
tree | 8fd77289f99163ebaae2a0e1f7f250fbf0081cdf /compiler_wrapper/testdata/cros_hardened_noccache_golden | |
parent | 6cfbb3d75dbd5383419814804f4d94b699537b50 (diff) | |
download | toolchain-utils-94fd622c652b7aa46f2ca24d3a0efe93c7fde040.tar.gz |
compiler_wrapper: remove -grecord-gcc-switches
-grecord-gcc-switches causes the compiler and compiler flags to be
stored in the produced debug information. This causes Goma builds to
be non-deterministic, because the compiler path differs depending
on whether the compiler was run locally or on Goma. This, in turn,
causes cache pollution and needless work. Since we are not in
fact using the information stored by -grecord-gcc-switches, this
change disables it. We can re-enable it when we want to start
using the information, provided we come up with another way to
avoid the issues described earlier.
BUG=chromium:1103065
TEST=Build an object file in chromeos-chrome and check that info is absent
Change-Id: Ib8022a3a1baf2e4b5d3d9d1453deb67f539baff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2290624
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Tested-by: Bob Haarman <inglorion@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tiancong Wang <tcwang@google.com>
Diffstat (limited to 'compiler_wrapper/testdata/cros_hardened_noccache_golden')
5 files changed, 0 insertions, 32 deletions
diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/bisect.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/bisect.json index dfe8c0c0..f31bbe96 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/bisect.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/bisect.json @@ -26,7 +26,6 @@ "/usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -84,7 +83,6 @@ "/usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -145,7 +143,6 @@ "/usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/clang_path.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/clang_path.json index c8a0e101..b2cdeb46 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/clang_path.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/clang_path.json @@ -16,7 +16,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -63,7 +62,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -110,7 +108,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -157,7 +154,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -211,7 +207,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -271,7 +266,6 @@ "/somedir/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -330,7 +324,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -379,7 +372,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -423,7 +415,6 @@ "args": [ "--sysroot=/tmp/stable/a/b/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -467,7 +458,6 @@ "args": [ "--sysroot=/tmp/stable/a/b/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -511,7 +501,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -558,7 +547,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/clangtidy.json index b8b786db..eae5c3d9 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/clangtidy.json @@ -32,7 +32,6 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -63,7 +62,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -124,7 +122,6 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -156,7 +153,6 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -219,7 +215,6 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -254,7 +249,6 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -318,7 +312,6 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -350,7 +343,6 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/force_disable_werror.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/force_disable_werror.json index 9700b128..d01ceac3 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/force_disable_werror.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/force_disable_werror.json @@ -19,7 +19,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -66,7 +65,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -99,7 +97,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -150,7 +147,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -183,7 +179,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/gcc_clang_syntax.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/gcc_clang_syntax.json index 3b31be3c..e9f5e64a 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/gcc_clang_syntax.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/gcc_clang_syntax.json @@ -17,7 +17,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -86,7 +85,6 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -155,7 +153,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -208,7 +205,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", |