diff options
| author | Manoj Gupta <manojgupta@google.com> | 2021-01-28 21:46:53 -0800 |
|---|---|---|
| committer | Manoj Gupta <manojgupta@chromium.org> | 2021-01-29 16:36:04 +0000 |
| commit | efefb1af9de841e2be7e714960e492e86ba0edbf (patch) | |
| tree | 878a66714151ea54913a662f5eb18ddfb9ab0d0a /compiler_wrapper/testdata | |
| parent | 2844e62d0405e009f4a57093eedab9c37416e54c (diff) | |
| download | toolchain-utils-efefb1af9de841e2be7e714960e492e86ba0edbf.tar.gz | |
compiler_wrapper: Fix gcc host wrapper config
GCC host wrapper was not calling the code to add common
flags for no clear reason. Add it so that "-fcommon" is now
passed to GCC host compiler invocations.
BUG=chromium:1171833
TEST=go test
Change-Id: Id354b65ff0a08d0b25f895bb95cd4e99412b856b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2657585
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Diffstat (limited to 'compiler_wrapper/testdata')
4 files changed, 19 insertions, 0 deletions
diff --git a/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_host_wrapper.json b/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_host_wrapper.json index 62afbbaa..825e5dd3 100644 --- a/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_host_wrapper.json +++ b/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_host_wrapper.json @@ -17,6 +17,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } diff --git a/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_maincc_target_specific.json b/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_maincc_target_specific.json index 6c88c344..97fb19b0 100644 --- a/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_maincc_target_specific.json +++ b/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_maincc_target_specific.json @@ -17,6 +17,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -41,6 +42,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -65,6 +67,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -89,6 +92,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -113,6 +117,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -137,6 +142,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -161,6 +167,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -185,6 +192,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -209,6 +217,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } diff --git a/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_path.json b/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_path.json index b846d47f..c71bcd44 100644 --- a/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_path.json +++ b/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_path.json @@ -17,6 +17,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -44,6 +45,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] }, @@ -71,6 +73,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -95,6 +98,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -119,6 +123,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } @@ -146,6 +151,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "main.cc" ] } diff --git a/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_specific_args.json b/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_specific_args.json index e1470474..cd656307 100644 --- a/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_specific_args.json +++ b/compiler_wrapper/testdata/cros_gcc_host_golden/gcc_specific_args.json @@ -18,6 +18,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "-march=goldmont", "main.cc" ] @@ -44,6 +45,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "-march=goldmont-plus", "main.cc" ] @@ -70,6 +72,7 @@ "-Wno-maybe-uninitialized", "-Wno-unused-local-typedefs", "-Wno-deprecated-declarations", + "-fcommon", "-march=skylake", "main.cc" ] |