diff options
author | Tobias Bosch <tbosch@google.com> | 2019-06-24 09:31:39 -0700 |
---|---|---|
committer | Tobias Bosch <tbosch@google.com> | 2019-06-28 19:00:23 +0000 |
commit | 900dbc92800d8fc927905db29cb302461054cf97 (patch) | |
tree | c74ecbfb01ee4ee679090139596aef3546f19d9b /compiler_wrapper/unsupported_flags.go | |
parent | 739e6abb2cd03b60e579df31ad55870a4a00260a (diff) | |
download | toolchain-utils-900dbc92800d8fc927905db29cb302461054cf97.tar.gz |
Introduce infrastructure for calling and testing nested
commands, error messages and exit codes.
Also:
- implements the -Xclang-path= flag as use case of calling
a nested command.
- adds tests for forwarding errors, comparing against the
old wrapper, and exit codes.
- captures the source locations of errors in error messages.
- compares exit codes of new wrapper and old wrapper.
BUG=chromium:773875
TEST=unit test
Change-Id: I919e58091d093d68939809f676f799a68ec7a34e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1676833
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Tobias Bosch <tbosch@google.com>
Diffstat (limited to 'compiler_wrapper/unsupported_flags.go')
-rw-r--r-- | compiler_wrapper/unsupported_flags.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/compiler_wrapper/unsupported_flags.go b/compiler_wrapper/unsupported_flags.go index 604f94ce..3e3e8cb5 100644 --- a/compiler_wrapper/unsupported_flags.go +++ b/compiler_wrapper/unsupported_flags.go @@ -1,13 +1,9 @@ package main -import ( - "errors" -) - func checkUnsupportedFlags(cmd *command) error { for _, arg := range cmd.args { if arg == "-fstack-check" { - return errors.New(`option "-fstack-check" is not supported; crbug/485492`) + return newUserErrorf(`option %q is not supported; crbug/485492`, arg) } } return nil |