diff options
| author | Ryan Beltran <ryanbeltran@chromium.org> | 2020-12-17 18:24:56 +0000 |
|---|---|---|
| committer | Ryan Beltran <ryanbeltran@chromium.org> | 2020-12-17 19:04:20 +0000 |
| commit | 58a786a07a0e160ebff3cc4eba04d7d609bf0a15 (patch) | |
| tree | 94ea8c1b01c957458f1979019af94747c1cc25cb /compiler_wrapper | |
| parent | a27756bd06caae7d87c5f2e57cdfdd94b81c4837 (diff) | |
| download | toolchain-utils-58a786a07a0e160ebff3cc4eba04d7d609bf0a15.tar.gz | |
compiler_wrapper: Fix rusage_flag permission error
Seeing permission errors in builder bots that create rusage_flags.
We need to set the Umask to 0 during creation of the directory.
BUG=chromium:1156314
TEST=None
Change-Id: I667d922762c2cb090adbb3abac2d4782bc48b87d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2597478
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tiancong Wang <tcwang@google.com>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Diffstat (limited to 'compiler_wrapper')
| -rw-r--r-- | compiler_wrapper/rusage_flag.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/compiler_wrapper/rusage_flag.go b/compiler_wrapper/rusage_flag.go index f43d3515..31ff0d10 100644 --- a/compiler_wrapper/rusage_flag.go +++ b/compiler_wrapper/rusage_flag.go @@ -76,6 +76,11 @@ func logRusage(env env, logFileName string, compilerCmd *command) (exitCode int, maxMemUsed := rusageAfter.Maxrss absCompilerPath := getAbsCmdPath(env, compilerCmd) + // We need to temporarily set umask to 0 to ensure 777 permissions are actually 777 + // This effects builderbots in particular + oldMask := syscall.Umask(0) + defer syscall.Umask(oldMask) + if err := os.MkdirAll(filepath.Dir(logFileName), 0777); err != nil { return 0, wrapErrorwithSourceLocf(err, "error creating rusage log directory %s", logFileName) } |