diff options
| author | Caroline Tice <cmtice@google.com> | 2015-12-10 12:09:40 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2015-12-11 03:51:12 +0000 |
| commit | 7057cf67ba1dbdd4387f53e5fe47b43c955b1a53 (patch) | |
| tree | c4dd4303b356240113781f1e0c71d1628911d7c3 /crosperf/crosperf_unittest.py | |
| parent | 939274265fbac8c7f3d47c4e36c680d58cd578e9 (diff) | |
| download | toolchain-utils-7057cf67ba1dbdd4387f53e5fe47b43c955b1a53.tar.gz | |
Crosperf: Fix many broken unittests.
Apparently people have been making changes and not running the
unittests; many of the unittests were suffering from bit-rot. This
CL fixes most of the broken unittests (there are still 3 large ones
being worked on -- that will be in another CL).
BUG=chromium:567883
TEST=Verified that these unittests work now.
Change-Id: I0252a276a035894e70e04c61339cdba148c9bbfd
Reviewed-on: https://chrome-internal-review.googlesource.com/241513
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Diffstat (limited to 'crosperf/crosperf_unittest.py')
| -rwxr-xr-x | crosperf/crosperf_unittest.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crosperf/crosperf_unittest.py b/crosperf/crosperf_unittest.py index 3af3507f..082d8a6c 100755 --- a/crosperf/crosperf_unittest.py +++ b/crosperf/crosperf_unittest.py @@ -19,8 +19,8 @@ import experiment_runner from help import Help -from utils import command_executer -from utils import logger +from cros_utils import command_executer +from cros_utils import logger EXPERIMENT_FILE_1 = """ board: x86-alex @@ -60,7 +60,7 @@ class CrosperfTest(unittest.TestCase): self.assertEqual(len(options_before), 3) crosperf.SetupParserOptions(parser) options_after = parser._get_all_options() - self.assertEqual(len(options_after), 26) + self.assertEqual(len(options_after), 29) def test_convert_options_to_settings(self): @@ -78,7 +78,7 @@ class CrosperfTest(unittest.TestCase): settings = crosperf.ConvertOptionsToSettings(options) self.assertIsNotNone(settings) self.assertIsInstance(settings, settings_factory.GlobalSettings) - self.assertEqual(len(settings.fields), 22) + self.assertEqual(len(settings.fields), 25) self.assertTrue(settings.GetField('rerun')) argv = ['crosperf/crosperf.py', 'temp.exp'] options, args = parser.parse_args(argv) |