diff options
| author | Zhizhou Yang <zhizhouy@google.com> | 2019-10-16 17:45:30 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-10-27 05:16:16 -0700 |
| commit | 45582b59e386953ecfc25a6b19ca23e18c550eef (patch) | |
| tree | fe65d9944832d3c3731492f38b8e6237ac70711f /crosperf/download_images_unittest.py | |
| parent | e2546d5a35c3f400a74d1902992f635ade141f90 (diff) | |
| download | toolchain-utils-45582b59e386953ecfc25a6b19ca23e18c550eef.tar.gz | |
crosperf: Add option to not download debug symbols
This patch introduces a new option --download_debug to crosperf.
We will only download debug symbols when this option is set to True.
This will save space when perf test users doesn't need it.
TEST=passed unittests.
BUG=chromium:1010294
Change-Id: Ic80958377f1c25cb04e3b7b56b40fafcada6d2d8
Reviewed-on: https://chromium-review.googlesource.com/1865958
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Commit-Ready: Zhizhou Yang <zhizhouy@google.com>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Denis Nikitin <denik@chromium.org>
Diffstat (limited to 'crosperf/download_images_unittest.py')
| -rwxr-xr-x | crosperf/download_images_unittest.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/crosperf/download_images_unittest.py b/crosperf/download_images_unittest.py index 68a84676..dd83c3fa 100755 --- a/crosperf/download_images_unittest.py +++ b/crosperf/download_images_unittest.py @@ -167,7 +167,7 @@ class ImageDownloaderTestcast(unittest.TestCase): test_empty_debug_path = '' test_autotest_path = '/tmp/autotest' test_debug_path = '/tmp/debug' - perf_args = '-a' + download_debug = True # Set values to test/check. self.called_download_image = False @@ -224,7 +224,7 @@ class ImageDownloaderTestcast(unittest.TestCase): # Call Run. image_path, autotest_path, debug_path = downloader.Run( test_chroot, test_build_id, test_empty_autotest_path, - test_empty_debug_path, perf_args) + test_empty_debug_path, download_debug) # Make sure it called both _DownloadImage and _UncompressImage self.assertTrue(self.called_download_image) @@ -244,7 +244,7 @@ class ImageDownloaderTestcast(unittest.TestCase): image_path, autotest_path, debug_path = downloader.Run( test_chroot, test_build_id, test_autotest_path, test_debug_path, - perf_args) + download_debug) # Verify that downloadAutotestFiles was not called self.assertFalse(self.called_download_autotest_files) @@ -263,7 +263,7 @@ class ImageDownloaderTestcast(unittest.TestCase): # Call Run again. self.assertRaises(download_images.MissingImage, downloader.Run, test_chroot, test_autotest_path, test_debug_path, test_build_id, - perf_args) + download_debug) # Verify that UncompressImage and downloadAutotestFiles were not called, # since _DownloadImage "failed" |