diff options
| author | Zhizhou Yang <zhizhouy@google.com> | 2019-10-16 17:45:30 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-10-27 05:16:16 -0700 |
| commit | 45582b59e386953ecfc25a6b19ca23e18c550eef (patch) | |
| tree | fe65d9944832d3c3731492f38b8e6237ac70711f /crosperf/experiment_factory.py | |
| parent | e2546d5a35c3f400a74d1902992f635ade141f90 (diff) | |
| download | toolchain-utils-45582b59e386953ecfc25a6b19ca23e18c550eef.tar.gz | |
crosperf: Add option to not download debug symbols
This patch introduces a new option --download_debug to crosperf.
We will only download debug symbols when this option is set to True.
This will save space when perf test users doesn't need it.
TEST=passed unittests.
BUG=chromium:1010294
Change-Id: Ic80958377f1c25cb04e3b7b56b40fafcada6d2d8
Reviewed-on: https://chromium-review.googlesource.com/1865958
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Commit-Ready: Zhizhou Yang <zhizhouy@google.com>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Denis Nikitin <denik@chromium.org>
Diffstat (limited to 'crosperf/experiment_factory.py')
| -rw-r--r-- | crosperf/experiment_factory.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/crosperf/experiment_factory.py b/crosperf/experiment_factory.py index 5b4d4b0d..1758f0c7 100644 --- a/crosperf/experiment_factory.py +++ b/crosperf/experiment_factory.py @@ -137,6 +137,10 @@ class ExperimentFactory(object): remote = new_remote rm_chroot_tmp = global_settings.GetField('rm_chroot_tmp') perf_args = global_settings.GetField('perf_args') + download_debug = global_settings.GetField('download_debug') + # Do not download debug symbols when perf_args is not specified. + if not perf_args and download_debug: + download_debug = False acquire_timeout = global_settings.GetField('acquire_timeout') cache_dir = global_settings.GetField('cache_dir') cache_only = global_settings.GetField('cache_only') @@ -433,7 +437,7 @@ class ExperimentFactory(object): raise RuntimeError("Can not have empty 'build' field!") image, autotest_path, debug_path = label_settings.GetXbuddyPath( build, autotest_path, debug_path, board, chromeos_root, log_level, - perf_args) + download_debug) cache_dir = label_settings.GetField('cache_dir') chrome_src = label_settings.GetField('chrome_src') |