diff options
| author | cmtice <cmtice@google.com> | 2014-04-16 14:48:47 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-04-21 20:54:52 +0000 |
| commit | 98a53692fb946a8eac46e3e82257f540d1350c18 (patch) | |
| tree | 330fee723ed07a69fccf88fe6a86d806c0c016f5 /crosperf/experiment_file_unittest.py | |
| parent | 71e004237b85bdcab97c09b7f58305e5f5eff7f8 (diff) | |
| download | toolchain-utils-98a53692fb946a8eac46e3e82257f540d1350c18.tar.gz | |
Clean up Crosperf options and help.
Crosperf's help was completely out of date and incorrect. Fixed
that. Also, I cleaned up the options, removed some that were no
longer appropriate or not ever used, and made some options global-only.
Also removed all references to pyauto. We no longer use or run pyauto
tests.
Option changes: Completely removed outlier_range (it was not actually doing
anything), key_results_only (applied only to pyauto tests), use_test_that
(not needed now that we're not using pyauto) and md5sum (never used).
Made the following options global-only: rm_chroot_tmp, perf_args, logging_level,
show_all_results, board. Removed 'build' from global settings and made
it an image-only setting (it made no sense as a global setting).
I also adjusted the unittests to work with these changes.
BUG=None
TEST=I tested all the options in all their various positions; I tested with and
wtihout caching; and I tested local and official images. I also ran the unittests. Everything works.
Change-Id: I7653663f65c0a3363a1904c0220f1066e72c7f9d
Reviewed-on: https://chrome-internal-review.googlesource.com/160758
Reviewed-by: Bhaskar Janakiraman <bjanakiraman@google.com>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Diffstat (limited to 'crosperf/experiment_file_unittest.py')
| -rwxr-xr-x | crosperf/experiment_file_unittest.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/crosperf/experiment_file_unittest.py b/crosperf/experiment_file_unittest.py index d08c7eb5..335a516b 100755 --- a/crosperf/experiment_file_unittest.py +++ b/crosperf/experiment_file_unittest.py @@ -21,7 +21,6 @@ EXPERIMENT_FILE_1 = """ } image2 { - board: lumpy remote: chromeos-lumpy1 chromeos_image: /usr/local/google/cros_image2.bin } @@ -82,7 +81,6 @@ class ExperimentFileTest(unittest.TestCase): label_settings = experiment_file.GetSettings("label") self.assertEqual(len(label_settings), 2) self.assertEqual(label_settings[0].name, "image1") - self.assertEqual(label_settings[0].GetField("board"), "x86-alex") self.assertEqual(label_settings[0].GetField("chromeos_image"), "/usr/local/google/cros_image1.bin") self.assertEqual(label_settings[1].GetField("remote"), ["chromeos-lumpy1"]) |