diff options
| author | Zhizhou Yang <zhizhouy@google.com> | 2019-12-03 16:00:31 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-12-11 16:35:37 +0000 |
| commit | 5a74f07b374010951c7c66226cbbb548de69789e (patch) | |
| tree | 91c52b1b86adac5dd865603e6819d7c570df1e22 /crosperf/results_cache_unittest.py | |
| parent | 5ca2cc3ee7651e904cacde7b1fde0fbc98b5ca70 (diff) | |
| download | toolchain-utils-5a74f07b374010951c7c66226cbbb548de69789e.tar.gz | |
crosperf: migrate device setup functions for telemetry_Crosperf
This is a patch working together with crrev.com/c/1949606 to migrate
device setup functions from suite_runner to autotest telmetry_Crosperf.
In this patch, we modified the logic of different suite types along with
skylab mode for suite_runner.
In result_cache, we handle the wait time log file to accumulate cool
down time per machine.
We also move intel_pstate kernel updating code into SetupDevice() since
it doesn't increase overhead by checking every iteration.
TEST=Passed all unittests; tested with different benchmark modes (Note
that currently skylab server tests cannot be tested because of
regression: crbug.com/984103).
BUG=chromium:1020655
Cq-Depend: chromium:1949606
Change-Id: If8e5099d096d2568d4f54584a8fcfd3c0f99c8f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1949626
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Denis Nikitin <denik@chromium.org>
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Auto-Submit: Zhizhou Yang <zhizhouy@google.com>
Commit-Queue: Denis Nikitin <denik@chromium.org>
Diffstat (limited to 'crosperf/results_cache_unittest.py')
| -rwxr-xr-x | crosperf/results_cache_unittest.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/crosperf/results_cache_unittest.py b/crosperf/results_cache_unittest.py index 7ce04221..c1c27265 100755 --- a/crosperf/results_cache_unittest.py +++ b/crosperf/results_cache_unittest.py @@ -434,6 +434,7 @@ class ResultTest(unittest.TestCase): self.callGetTurbostatFile = False self.callGetCpustatsFile = False self.callGetTopFile = False + self.callGetWaitTimeFile = False self.args = None self.callGatherPerfResults = False self.mock_logger = mock.Mock(spec=logger.Logger) @@ -1126,6 +1127,10 @@ class ResultTest(unittest.TestCase): self.callGetTopFile = True return [] + def FakeGetWaitTimeFile(): + self.callGetWaitTimeFile = True + return [] + def FakeProcessResults(show_results=False): if show_results: pass @@ -1143,6 +1148,7 @@ class ResultTest(unittest.TestCase): self.callGetTurbostatFile = False self.callGetCpustatsFile = False self.callGetTopFile = False + self.callGetWaitTimeFile = False self.callProcessResults = False self.result.GetResultsDir = FakeGetResultsDir @@ -1152,6 +1158,7 @@ class ResultTest(unittest.TestCase): self.result.GetTurbostatFile = FakeGetTurbostatFile self.result.GetCpustatsFile = FakeGetCpustatsFile self.result.GetTopFile = FakeGetTopFile + self.result.GetWaitTimeFile = FakeGetWaitTimeFile self.result.ProcessResults = FakeProcessResults self.result.PopulateFromRun(OUTPUT, '', 0, 'test', 'telemetry_Crosperf', @@ -1163,6 +1170,7 @@ class ResultTest(unittest.TestCase): self.assertTrue(self.callGetTurbostatFile) self.assertTrue(self.callGetCpustatsFile) self.assertTrue(self.callGetTopFile) + self.assertTrue(self.callGetWaitTimeFile) self.assertTrue(self.callProcessResults) def FakeGetKeyvals(self, show_all=False): |