diff options
| author | cmtice <cmtice@google.com> | 2014-04-16 14:48:47 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-04-21 20:54:52 +0000 |
| commit | 98a53692fb946a8eac46e3e82257f540d1350c18 (patch) | |
| tree | 330fee723ed07a69fccf88fe6a86d806c0c016f5 /crosperf/results_organizer.py | |
| parent | 71e004237b85bdcab97c09b7f58305e5f5eff7f8 (diff) | |
| download | toolchain-utils-98a53692fb946a8eac46e3e82257f540d1350c18.tar.gz | |
Clean up Crosperf options and help.
Crosperf's help was completely out of date and incorrect. Fixed
that. Also, I cleaned up the options, removed some that were no
longer appropriate or not ever used, and made some options global-only.
Also removed all references to pyauto. We no longer use or run pyauto
tests.
Option changes: Completely removed outlier_range (it was not actually doing
anything), key_results_only (applied only to pyauto tests), use_test_that
(not needed now that we're not using pyauto) and md5sum (never used).
Made the following options global-only: rm_chroot_tmp, perf_args, logging_level,
show_all_results, board. Removed 'build' from global settings and made
it an image-only setting (it made no sense as a global setting).
I also adjusted the unittests to work with these changes.
BUG=None
TEST=I tested all the options in all their various positions; I tested with and
wtihout caching; and I tested local and official images. I also ran the unittests. Everything works.
Change-Id: I7653663f65c0a3363a1904c0220f1066e72c7f9d
Reviewed-on: https://chrome-internal-review.googlesource.com/160758
Reviewed-by: Bhaskar Janakiraman <bjanakiraman@google.com>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Diffstat (limited to 'crosperf/results_organizer.py')
| -rw-r--r-- | crosperf/results_organizer.py | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/crosperf/results_organizer.py b/crosperf/results_organizer.py index a771922f..0460b6e9 100644 --- a/crosperf/results_organizer.py +++ b/crosperf/results_organizer.py @@ -28,11 +28,6 @@ class ResultOrganizer(object): [ ]}. """ - key_filter = ["milliseconds_", - "retval", - "iterations", - "ms_", - "score_"] def __init__(self, benchmark_runs, labels, benchmarks=None): self.result = {} @@ -59,9 +54,6 @@ class ResultOrganizer(object): if not benchmark_run.result: continue benchmark = benchmark_run.benchmark - key_filter_on = (benchmark.key_results_only and - "PyAutoPerfTest" in benchmark.name + benchmark.test_name - and "perf." not in benchmark.test_args) if not show_all_results: summary_list = self._GetSummaryResults(benchmark.test_name) if len(summary_list) > 0: @@ -70,10 +62,6 @@ class ResultOrganizer(object): # Did not find test_name in json file; therefore show everything. show_all_results = True for test_key in benchmark_run.result.keyvals: - if (key_filter_on and - not any([key for key in self.key_filter if key in test_key]) - ): - continue if not show_all_results and not test_key in summary_list: continue result_value = benchmark_run.result.keyvals[test_key] |