diff options
| author | Ting-Yuan Huang <laszio@google.com> | 2017-02-17 12:20:02 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-02-21 16:16:41 -0800 |
| commit | 8332364c0237ca6c4976c5206346ab9a596c8e98 (patch) | |
| tree | acb32cdab517b4d2d78836ce2d1dba0073c6d436 /crosperf/settings_factory.py | |
| parent | 1cc48481a2ca530bab04999da78eddc8a1b98adb (diff) | |
| download | toolchain-utils-8332364c0237ca6c4976c5206346ab9a596c8e98.tar.gz | |
crosperf: set recommended iterations for benchmarks
This CL associates estimated standard deviations to each benchmark,
according to experiments. The recommended iterations can be specified by
setting iterations = 0 in the experiment files. Setting it to numbers
greater than 0 will override the default iterations and behaves exactly
the same as before.
With this change, benchmarks in all_toolchain_perf get no more than 2%
margin of error within 90% of time. See crbug.com/673558 for how the
standard deviations are estimated.
BUG=chromium:673558
TEST=all_toolchain_perf + page_cycler_v2.typical_25 finishes in 3.5
hours for an image on chell.
Change-Id: Ie2ed07878c1237ad31a8568ae3fd3fb96cd11f3b
Reviewed-on: https://chromium-review.googlesource.com/424915
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Diffstat (limited to 'crosperf/settings_factory.py')
| -rw-r--r-- | crosperf/settings_factory.py | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/crosperf/settings_factory.py b/crosperf/settings_factory.py index e42d82a9..05e3fbbb 100644 --- a/crosperf/settings_factory.py +++ b/crosperf/settings_factory.py @@ -29,9 +29,11 @@ class BenchmarkSettings(Settings): self.AddField( IntegerField( 'iterations', - default=1, - description='Number of iterations to run the ' - 'test.')) + required=False, + default=0, + description='Number of iterations to run the test. ' + 'If not set, will run each benchmark test the optimum number of ' + 'times to get a stable result.')) self.AddField( TextField( 'suite', default='', description='The type of the benchmark.')) @@ -186,9 +188,11 @@ class GlobalSettings(Settings): self.AddField( IntegerField( 'iterations', - default=1, - description='Number of iterations to run all ' - 'tests.')) + required=False, + default=0, + description='Number of iterations to run all tests. ' + 'If not set, will run each benchmark test the optimum number of ' + 'times to get a stable result.')) self.AddField( TextField( 'chromeos_root', |