diff options
author | Luis Lozano <llozano@chromium.org> | 2015-05-19 12:22:37 -0700 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-05-28 23:02:21 +0000 |
commit | df76222bf1cbdbc42bb41934fb960bac8694eca4 (patch) | |
tree | 3bcefbfb23af029d6512a220c584cce2da987bac /crosperf/settings_factory.py | |
parent | 7cdb11a25795a7215d59aa49c7b8619780951afa (diff) | |
download | toolchain-utils-df76222bf1cbdbc42bb41934fb960bac8694eca4.tar.gz |
Added benchmark retry support.
We often get spurious failures from the benchmarks runs. This CL adds
support for a "retries" field that will automatically retry the benchmark
run by the amount specified.
BUG=None
TEST=Test by hand.
Change-Id: Ib881c40d766e67a7daf855ce9137d3e3d631f12e
Reviewed-on: https://chrome-internal-review.googlesource.com/217525
Reviewed-by: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Diffstat (limited to 'crosperf/settings_factory.py')
-rw-r--r-- | crosperf/settings_factory.py | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/crosperf/settings_factory.py b/crosperf/settings_factory.py index 835748a3..9def4398 100644 --- a/crosperf/settings_factory.py +++ b/crosperf/settings_factory.py @@ -30,6 +30,9 @@ class BenchmarkSettings(Settings): "test.")) self.AddField(TextField("suite", default="", description="The type of the benchmark")) + self.AddField(IntegerField("retries", default=0, + description="Number of times to retry a " + "benchmark run.")) class LabelSettings(Settings): @@ -130,9 +133,9 @@ class GlobalSettings(Settings): "whether to all the results, instead of just " "the default (summary) results.")) self.AddField(TextField("share_cache", default="", - description="Path to alternat cache whose data " + description="Path to alternate cache whose data " "you want to use. It accepts multiples directories" - " se[arated bu a \",\"")) + " separated by a \",\"")) self.AddField(TextField("results_dir", default="", description="The results dir")) default_locks_dir = lock_machine.Machine.LOCKS_DIR @@ -148,7 +151,9 @@ class GlobalSettings(Settings): "This is used to run telemetry benchmarks. " "The default one is the src inside chroot.", required=False, default="")) - + self.AddField(IntegerField("retries", default=0, + description="Number of times to retry a " + "benchmark run.")) class SettingsFactory(object): """Factory class for building different types of Settings objects. |