diff options
| author | Zhizhou Yang <zhizhouy@google.com> | 2020-01-14 16:49:12 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-16 03:36:24 +0000 |
| commit | 0410b6515691a2fd3410917849d32495490d6999 (patch) | |
| tree | f456416e7706148c2505789bc51f3966c50b071c /crosperf/settings_unittest.py | |
| parent | c977ae00dfd11ebd7c9212b04d0cf1808ea9bfc6 (diff) | |
| download | toolchain-utils-0410b6515691a2fd3410917849d32495490d6999.tar.gz | |
crosperf: fix pylint for crosperf
This is the first step of python 3 migration for crosperf
TEST=Passed presubmit for all .py files in crosperf
BUG=chromium:1011676
Change-Id: I615d0323c81ba688c8ce2aa0cac307035d0b882b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2001696
Commit-Queue: Zhizhou Yang <zhizhouy@google.com>
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Auto-Submit: Zhizhou Yang <zhizhouy@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Diffstat (limited to 'crosperf/settings_unittest.py')
| -rwxr-xr-x | crosperf/settings_unittest.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crosperf/settings_unittest.py b/crosperf/settings_unittest.py index 8140e9b9..e6126923 100755 --- a/crosperf/settings_unittest.py +++ b/crosperf/settings_unittest.py @@ -37,7 +37,7 @@ class TestSettings(unittest.TestCase): settings_parent = {'fake_parent_entry': 0} self.settings.SetParentSettings(settings_parent) self.assertIsNotNone(self.settings.parent) - self.assertEqual(type(self.settings.parent), dict) + self.assertTrue(isinstance(self.settings.parent, dict)) self.assertEqual(self.settings.parent, settings_parent) def test_add_field(self): @@ -88,7 +88,7 @@ class TestSettings(unittest.TestCase): description="A comma-separated list of ip's of " 'chromeos devices to run ' 'experiments on.')) - self.assertEqual(type(self.settings.fields), dict) + self.assertTrue(isinstance(self.settings.fields, dict)) self.assertEqual(len(self.settings.fields), 2) res = self.settings.fields['remote'] self.assertEqual(res.Get(), []) |