diff options
| author | Salud Lemus <saludlemus@google.com> | 2019-08-13 10:59:02 -0700 |
|---|---|---|
| committer | Salud Lemus <saludlemus@google.com> | 2019-08-16 22:36:24 +0000 |
| commit | 3f0c0754d9d2d068a14489cf207a4d5994e740f4 (patch) | |
| tree | 4413453ffb6af10829d4d18a3afe084daf83d989 /llvm_tools/failure_modes.py | |
| parent | 16603d5a467634a77b551daa2452f658d65d0ec2 (diff) | |
| download | toolchain-utils-3f0c0754d9d2d068a14489cf207a4d5994e740f4.tar.gz | |
LLVM tools: Added support for bisection of patches
Changed 'get_google3_llvm_version.py' and 'get_llvm_hash.py' to use the
subprocess module instead of the command executer because the patch
manager script uses some methods for bisection (retrieving the good and
bad hash). They were also changed because the ebuilds will not have
access to the command executer when invoking the patch manager script.
BUG=None
TEST=Ran the script on SVN version of 367622 without continuing
bisection and successfully bisected the failed patch and terminated the
script. Then moved HEAD of source tree to the bisected SVN version and
applied the patch manually to test correctness and also moved HEAD to
the SVN version one above it and one below it and also manually applied
the patch.
Change-Id: I2367b76e9bb4d0c95d651ec7b3f66e582155d2c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1752526
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Diffstat (limited to 'llvm_tools/failure_modes.py')
| -rw-r--r-- | llvm_tools/failure_modes.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/llvm_tools/failure_modes.py b/llvm_tools/failure_modes.py index 6a381c2e..1e05dfcf 100644 --- a/llvm_tools/failure_modes.py +++ b/llvm_tools/failure_modes.py @@ -18,3 +18,6 @@ class FailureModes(enum.Enum): DISABLE_PATCHES = 'disable_patches' BISECT_PATCHES = 'bisect_patches' REMOVE_PATCHES = 'remove_patches' + + # Only used by 'bisect_patches'. + INTERNAL_BISECTION = 'internal_bisection' |