aboutsummaryrefslogtreecommitdiff
path: root/llvm_tools/get_llvm_hash_unittest.py
diff options
context:
space:
mode:
authorGeorge Burgess IV <gbiv@google.com>2019-09-05 20:10:06 -0700
committerGeorge Burgess <gbiv@chromium.org>2019-09-10 01:58:25 +0000
commitfc0b318753e23bc669121b3f7b7e132a96a7ac6c (patch)
tree8b1f421cd01b964a0e1a790997a4f1b13c883b03 /llvm_tools/get_llvm_hash_unittest.py
parent478cfee03066d58ca3899753de95a58f35a96835 (diff)
downloadtoolchain-utils-fc0b318753e23bc669121b3f7b7e132a96a7ac6c.tar.gz
llvm_tools: support grabbing google3's unstable LLVM
Google3 integrates LLVM pretty often -- using that as a foundation for testing might be a good idea. This CL enables us to pull the revision of their unstable LLVM. As an added bonus, this will also have us print a message to stderr when we're syncing LLVM for the first time. Otherwise, it may seem to a user that our script got hung up on something while that first clone happens. :) BUG=chromium:914081 TEST=Unittests. Ran the new get_llvm_hash functionality. Change-Id: I3a7088c25dbd7169ca31373daf0c46fb28f46a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1793906 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
Diffstat (limited to 'llvm_tools/get_llvm_hash_unittest.py')
-rwxr-xr-xllvm_tools/get_llvm_hash_unittest.py11
1 files changed, 10 insertions, 1 deletions
diff --git a/llvm_tools/get_llvm_hash_unittest.py b/llvm_tools/get_llvm_hash_unittest.py
index e7f155a0..77957aa0 100755
--- a/llvm_tools/get_llvm_hash_unittest.py
+++ b/llvm_tools/get_llvm_hash_unittest.py
@@ -12,9 +12,9 @@ import subprocess
import unittest
import get_llvm_hash
-from get_llvm_hash import LLVMHash
import mock
import test_helpers
+from get_llvm_hash import LLVMHash
# We grab protected stuff from get_llvm_hash. That's OK.
# pylint: disable=protected-access
@@ -130,6 +130,15 @@ class TestGetLLVMHash(unittest.TestCase):
self.assertEqual(LLVMHash().GetGoogle3LLVMHash(), 'a13testhash3')
mock_get_llvm_hash.assert_called_once_with(1000)
+ @mock.patch.object(LLVMHash, 'GetLLVMHash')
+ @mock.patch.object(get_llvm_hash, 'GetGoogle3LLVMVersion')
+ def testReturnGoogle3UnstableLLVMHash(self, mock_google3_llvm_version,
+ mock_get_llvm_hash):
+ mock_get_llvm_hash.return_value = 'a13testhash3'
+ mock_google3_llvm_version.return_value = 1000
+ self.assertEqual(LLVMHash().GetGoogle3UnstableLLVMHash(), 'a13testhash3')
+ mock_get_llvm_hash.assert_called_once_with(1000)
+
@mock.patch.object(subprocess, 'check_output')
def testSuccessfullyGetGitHashFromToTOfLLVM(self, mock_check_output):
mock_check_output.return_value = 'a123testhash1 path/to/master\n'