aboutsummaryrefslogtreecommitdiff
path: root/llvm_tools/get_upstream_patch.py
diff options
context:
space:
mode:
authorJordan R Abrahams <ajordanr@google.com>2022-02-25 22:40:36 +0000
committerCommit Bot <commit-bot@chromium.org>2022-02-28 22:17:06 +0000
commit79644ecd692df1a59cc50e9d31514948edb74852 (patch)
tree080a2c77eca4d7101cea305b79f16afd69056610 /llvm_tools/get_upstream_patch.py
parentcf276c12f5fbbaf0167c5242b317c712b7162f9d (diff)
downloadtoolchain-utils-79644ecd692df1a59cc50e9d31514948edb74852.tar.gz
llvm_tools: Allow version_range for start/end
At present, the start_version and end_version information are split as far apart as possible due to alphabetical sorting. This leads to bugs when developers want to modify those bug ranges by hand. This CL is the first step to grouping these version ranges together under the `version_range` property. BUG=b:221489531 TEST=python3 patch_manager_unittest.py TEST=cd patch_sync; cargo test TEST=edit PATCHES.json w/ version_range; patch_sync show <...> Change-Id: I9d0fead07c61c0bd0edb745ed623990f0686b8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3490757 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Diffstat (limited to 'llvm_tools/get_upstream_patch.py')
-rwxr-xr-xllvm_tools/get_upstream_patch.py11
1 files changed, 7 insertions, 4 deletions
diff --git a/llvm_tools/get_upstream_patch.py b/llvm_tools/get_upstream_patch.py
index 7a4be3eb..5669b023 100755
--- a/llvm_tools/get_upstream_patch.py
+++ b/llvm_tools/get_upstream_patch.py
@@ -96,15 +96,18 @@ def add_patch(patches_json_path: str, patches_dir: str,
cwd=llvm_dir,
encoding='utf-8')
+ end_vers = rev.number if isinstance(rev, git_llvm_rev.Rev) else None
patch_props = {
'rel_patch_path': rel_patch_path,
- 'start_version': start_version.number,
'metadata': {
'title': commit_subject.strip(),
'info': [],
},
'platforms': sorted(platforms),
- 'end_version': rev.number if isinstance(rev, git_llvm_rev.Rev) else None,
+ 'version_range': {
+ 'from': start_version.number,
+ 'until': end_vers,
+ },
}
patches_json.append(patch_props)
@@ -346,8 +349,8 @@ def _convert_patch(llvm_config: git_llvm_rev.LLVMConfig,
is_differential=is_differential)
-def _get_duplicate_shas(
- patches: t.List[ParsedPatch]) -> t.List[t.Tuple[ParsedPatch, ParsedPatch]]:
+def _get_duplicate_shas(patches: t.List[ParsedPatch]
+ ) -> t.List[t.Tuple[ParsedPatch, ParsedPatch]]:
"""Return a list of Patches which have duplicate SHA's"""
return [(left, right) for i, left in enumerate(patches)
for right in patches[i + 1:] if left.sha == right.sha]