diff options
| author | George Burgess IV <gbiv@google.com> | 2020-04-28 12:58:35 -0700 |
|---|---|---|
| committer | George Burgess <gbiv@chromium.org> | 2020-04-28 20:11:20 +0000 |
| commit | 16d12146ddf8c2ea77f12dbc43bf6ab55d742d80 (patch) | |
| tree | d2595f457ab9467972797914ad0e0db0478aa2bc /llvm_tools | |
| parent | ded113a1f5e9d2715361d8e2836edd0c48925d15 (diff) | |
| download | toolchain-utils-16d12146ddf8c2ea77f12dbc43bf6ab55d742d80.tar.gz | |
llvm_tools: don't check the same SHA for reverts twice
It occurred to me that there are times where llvm-next == llvm-stable.
If that's the case, we shouldn't generate two emails with (nearly)
identical contents.
BUG=chromium:1046988
TEST=unittests
Change-Id: Ib19db46daf95e73c64cc958d57c4220fc957bb51
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2171297
Reviewed-by: Tiancong Wang <tcwang@google.com>
Tested-by: George Burgess <gbiv@chromium.org>
Diffstat (limited to 'llvm_tools')
| -rwxr-xr-x | llvm_tools/nightly_revert_checker.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/llvm_tools/nightly_revert_checker.py b/llvm_tools/nightly_revert_checker.py index c3167ad8..3f5f771d 100755 --- a/llvm_tools/nightly_revert_checker.py +++ b/llvm_tools/nightly_revert_checker.py @@ -57,7 +57,11 @@ def _parse_llvm_ebuild_for_shas( if not llvm_next_hash or not llvm_hash: raise ValueError('Failed to detect SHAs for llvm/llvm_next. Got: ' 'llvm=%s; llvm_next=%s' % (llvm_hash, llvm_next_hash)) - return [('llvm', llvm_hash), ('llvm-next', llvm_next_hash)] + + results = [('llvm', llvm_hash)] + if llvm_next_hash != llvm_hash: + results.append(('llvm-next', llvm_next_hash)) + return results def _find_interesting_shas(chromeos_base: str) -> t.List[t.Tuple[str]]: |