diff options
| author | Manoj Gupta <manojgupta@google.com> | 2020-04-13 13:31:16 -0700 |
|---|---|---|
| committer | Manoj Gupta <manojgupta@chromium.org> | 2020-04-13 21:10:57 +0000 |
| commit | b12b7024519a30e8b4ef47a2f4f355f30e904182 (patch) | |
| tree | 37a1ec39a53ff5fbd5d1d6bdfc42a27fc1820941 /llvm_tools | |
| parent | 10ed31a339421ba2b4a60d6003d14c158ef97a40 (diff) | |
| download | toolchain-utils-b12b7024519a30e8b4ef47a2f4f355f30e904182.tar.gz | |
llvm_tools: Stop marking CL as WIP
WIP CLs are not handled by gwsq to find oncall reviewer.
We already pass "--ne" so the emails are not sent out for
anyone monitoring this repo which is probably enough.
BUG=chromium:1067029
TEST=unit tests, gswq assigned reviewer in CL:2146298
Change-Id: I962d6201482a5ba9bc3a0db2ba6db4fc4f0841de
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2148000
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Diffstat (limited to 'llvm_tools')
| -rwxr-xr-x | llvm_tools/update_chromeos_llvm_hash.py | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/llvm_tools/update_chromeos_llvm_hash.py b/llvm_tools/update_chromeos_llvm_hash.py index c44e8e14..4f6e9936 100755 --- a/llvm_tools/update_chromeos_llvm_hash.py +++ b/llvm_tools/update_chromeos_llvm_hash.py @@ -527,20 +527,19 @@ def UploadChanges(path_to_repo_dir, branch, commit_messages): commit_cmd, cwd=path_to_repo_dir, verbose=verbose) # Upload the changes for review. - upload_change_cmd = ( - 'yes | repo upload --wip --ne --br=%s --no-verify' % branch) + # Use --ne to avoid sending email notifications. + upload_change_cmd = [ + 'repo', 'upload', '--yes', '--ne', '--no-verify', + '--br=%s' % branch + ] # Pylint currently doesn't lint things in py3 mode, and py2 didn't allow # users to specify `encoding`s for Popen. Hence, pylint is "wrong" here. # pylint: disable=unexpected-keyword-arg - - # NOTE: Need `shell=True` in order to pipe `yes` into `repo upload ...`. - # # The CL URL is sent to 'stderr', so need to redirect 'stderr' to 'stdout'. upload_changes_obj = subprocess.Popen( upload_change_cmd, cwd=path_to_repo_dir, - shell=True, encoding='UTF-8', stdout=subprocess.PIPE, stderr=subprocess.STDOUT) |