aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-05-23crosperf: remove ".cros" suffix from hostnamesBob Haarman
We don't need the ".cros" suffix anymore, and its presence causes the ping check for at least one host to fail. BUG=b:231402615 TEST=Checking lab machines should pass after this Change-Id: I620db48c6f92837c12f86886eb9e87168dfc6ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3661356 Reviewed-by: Denis Nikitin <denik@chromium.org> Tested-by: Bob Haarman <inglorion@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org>
2022-05-20afdo_metadata: Publish the new kernel profilesDenis Nikitin
Update chromeos-kernel-4.4 Update chromeos-kernel-4.14 Update chromeos-kernel-4.19 Update chromeos-kernel-5.4 Update chromeos-kernel-5.10 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: I882dfa16066e0048c1ed3640dcbb29c697786e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3656068 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Auto-Submit: Denis Nikitin <denik@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2022-05-19llvm_tools: Add check for invalid until valuesJordan R Abrahams-Whitehead
Currently in get_upstream_patch.py, it's possible for the "until" value to be earlier than "from", which means the patch can never apply. This CL reports this as an error now. Applies some pre-upload autofixes as well, and adds minor documentation for the --differential flag to describe some non-obvious behavior. BUG=None TEST=get_upstream_patch.py with invalid patch versions Change-Id: Ie8338f8b9b27f0c41f0e350706a3131e5daab1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3653987 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org>
2022-05-17crosperf: Remove .cros dependency and add snappy to remotesDenis Nikitin
Clean up code which handles ".cros" suffix. Crosfleet, ssh and cros shell don't require .cros suffix in remotes. Snappy device is back. Add it to lab machines checks. BUG=b:231402615 TEST=tested locally Change-Id: I6e9a308428de05b8e84891933bdc19c55e18d08e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3651281 Commit-Queue: Denis Nikitin <denik@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org>
2022-05-17afdo_metadata: Publish the new kernel profilesDenis Nikitin
Update chromeos-kernel-4.4 Update chromeos-kernel-4.14 Update chromeos-kernel-4.19 Update chromeos-kernel-5.4 Update chromeos-kernel-5.10 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: If3f7a828c656a6534f7cf93aa7beed5666e1ed71 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3647287 Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Auto-Submit: Denis Nikitin <denik@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: Denis Nikitin <denik@chromium.org>
2022-05-17auto_delete_nightly_test_data: gracefully handle dirs not existingGeorge Burgess IV
To avoid cases like the attached bug, simply log when a dir doesn't exist. Doesn't seem bad to consider this a success. BUG=b:232843376 TEST=None Change-Id: I291d1b1ca4007d2402a6707c83ce483470099c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3651935 Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: George Burgess <gbiv@chromium.org>
2022-05-16compiler_wrapper: keep FORTIFY if sanitizer is trivialGeorge Burgess IV
For sanitizers like `return`, `builtin`, etc., we have no reason to also drop FORTIFY checks. BUG=b:231357370 TEST=`go test` Change-Id: I1e349a4f6743e549b7bc0899a307b10683bb42e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3651188 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2022-05-16compiler_wrapper: fix testGeorge Burgess IV
`-Wl,-z -Wl,defs` should be passed as separate flags. BUG=b:231357370 TEST=go test Change-Id: Iacd0be0c74df0cc7bd8607473a859c36c5ef4f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3651187 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2022-05-12compiler_wrapper: handle split "-Wl,-z,defs"Adrian Ratiu
During the libxcrypt build, both "-Wl,-z,defs" and its split equivalent "-Wl,-z -Wl,defs" are used which create problems because only the unified version is supported. This adds support for filtering the flags seprately and two tests to verify the functionality. BUG=b:187795307 TEST=Local builds with cross-*/libxcrypt; CQ. Change-Id: If48499f5c8e552e28c7cefd2d959e40f4757a88f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3641843 Tested-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org>
2022-05-11crosperf: Update remote lab machinesDenis Nikitin
BUG=b:231402615 TEST=ping <dut> Change-Id: I40b3c47f9c5209501cb2a15457a4c640887e8733 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3642336 Tested-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org> Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org>
2022-05-11compiler_wrapper: `go fmt`George Burgess IV
Pre-upload checks in chromiumos-overlay complained about these files not being `go fmt`'ed; do that. This is apparently an artifact of a build tag migration upstream: https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md ...so leave both in here for a while. BUG=b:232114933 TEST=go test Change-Id: I8f8e0896d3e3ce37d155035d93412f8c1c89b1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639686 Tested-by: George Burgess <gbiv@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Auto-Submit: George Burgess <gbiv@chromium.org>
2022-05-11compiler_wrapper: Disable warning implicit-intManoj Gupta
Wimplicit-int has been promoted to be an default error even with Wno-error. Disable the error by default since it is breaking a lot of packages. BUG=b:231987783 TEST=cq Change-Id: If88877cb63cdd5c392fcf05c2940751547466213 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3642338 Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
2022-05-10compiler_wrapper: move common clangFlags to a functionGeorge Burgess IV
BUG=b:232114933 TEST=go test Change-Id: Iffc686c47c21017a31b9fb69e1f2764390fe29f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639683 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2022-05-10compiler_wrapper: sort clangFlags; partition for dedupGeorge Burgess IV
This CL sorts clang flags, and puts ones shared across all CrOS configurations into their own textual blocks. This should make factoring these out into their own function not require golden updates, which makes verifying the CL that actually _does_ that simpler. BUG=b:232114933 TEST=go test Change-Id: I7dc6110d680505d4ad2af98709730e85c386ae5d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639682 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org>
2022-05-10compiler_wrapper: factor clangPostFlags into a function; sortGeorge Burgess IV
Since order doesn't matter, make this sorted. Otherwise, these are all shared, so no point in repeating them. BUG=b:232114933 TEST=go test Change-Id: Ide3c620de9018fed3fe8d898b21b3d5d4f42700f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639281 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2022-05-10compiler_wrapper: un-pointer-ify all configsGeorge Burgess IV
We do nothing with these but immediately deref them. It's simpler (and should be infinitesimally faster) to just have values here. BUG=None TEST=go test Change-Id: I6df8eda8f36032e856f9abad3e090c62c9d6beb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639684 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: George Burgess <gbiv@chromium.org>
2022-05-10compiler_wrapper: Disable warning implicit-function-declarationManoj Gupta
Wimplicit-function-declaration has been promoted to be an default error even with Wno-error. Disable the error by default since it is breaking a lot of packages. BUG=b:230345382 TEST=cq Change-Id: Ib46b0b47a3e1dea3797739370a4d9cf92a4d25f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3637117 Tested-by: Manoj Gupta <manojgupta@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
2022-05-10compiler_wrapper: remove -checks=* for tidyRyan Beltran
This CL removes -checks=*` from the Clang Tidy flags when WITH_TIDY=tricium which allows projects to provide their own configuration files for clang tidy. BUG=b:187790543 TEST=manually tested Change-Id: Ic6893a09146f071874f21f7bedb04a1f85e83284 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3635256 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org> Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
2022-05-10check-presubmit: use `isort` with `yapf`George Burgess IV
This requires a few things: - Running `isort` to begin with - Syncing with Chromite's `yapf` config, so `yapf` and `isort` don't disagree - ...Which itself requires upgrading `yapf`, since these disagree with `yapf`'s current configuration in toolchain-utils. The most recent chromite configuration requires v0.31.0, and depot_tools only has v0.27.0. This CL does all of these. BUG=b:231985625 TEST=Ran on a few files in toolchain-utils Change-Id: I43414abea7b75790b129e78708903ed90dae6ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3636138 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2022-05-09auto_delete_nightly_test_data: fix a few bugsGeorge Burgess IV
I forgot to copy the entire path here. Further, this caller of RemoveAllSubdirsMatchingPredicate _used_ to simply remove everything regardless of atime. Seems that crosperf accesses these things semi-often, so we can't have an `atime` check here. `mtime` also works, but just prefer the old behavior anyway. BUG=b:231976533 TEST=Ran on chrotomation. Change-Id: If833ea4bb07f80555890241ff9d2102079d0f8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3635698 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2022-05-05afdo_metadata: Publish the new kernel profilesDenis Nikitin
Update chromeos-kernel-4.4 Update chromeos-kernel-4.14 Update chromeos-kernel-4.19 Update chromeos-kernel-5.4 Update chromeos-kernel-5.10 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: I194f5ce08d98b80a6549c03a21b4b801b90ab96d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3630341 Auto-Submit: Denis Nikitin <denik@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
2022-05-02Sync unwindlib option with current llvmManoj Gupta
Use unwindlib=libunwind to match current production wrapper. BUG=None TEST=go test Change-Id: I6cdace48ed871ac87a093addf2b96b86ee5153c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3621381 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
2022-05-02Remove "-Wno-unused-but-set-variable" from config.go.Michael Benfield
BUG=b:227655984 TEST=CQ Change-Id: Ib8928cab96f8e3b4dfe50e5d89645e8ec5e905d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3613766 Auto-Submit: Michael Benfield <mbenfield@google.com> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
2022-04-29auto_delete_nightly_test_data: enhance telemetry file deletionGeorge Burgess IV
The output of this function was unhelpful. Much like previous CLs changing this file, this CL seeks to make the output more helpful (and make the removal more resilient to transient errors). Functionally, this also means we'll wait a day before removing these subdirectories. This doesn't seem inherently bad. BUG=b:230656849 TEST=Ran on Chrotomation Change-Id: I8e5f9bdd7725591abb5a694eebd1b47f8a3f6eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3614355 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org>
2022-04-28llvm_tools: Skip patch failures on local bisectionJordan R Abrahams-Whitehead
This is now controlled by a USE flag: 'continue-on-patch-failure', which we can make use of in this script. BUG=b:226987500 TEST=./llvm_local_bisection.sh # with erroneous patches Change-Id: I893ee1ca9743d0bc5b0a9ca6e4f88d73ebfb6454 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3610724 Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2022-04-26auto_delete_nightly_test_data: fix a bugGeorge Burgess IV
We should only print "discarding [...]" if we actually ran OnError. This was an oversight in my original CL. BUG=b:230201673 TEST=None Change-Id: Id6a664faa49fef0a4dc9d7ef01bd60280c071c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3609228 Tested-by: George Burgess <gbiv@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
2022-04-26auto_delete_nightly_test_data: refactor tmp file cleaningGeorge Burgess IV
This function fails pretty often, and its output is very unhelpful (similar quality to "something somewhere failed"). This turns the function into Python code, and makes it error out more gracefully. BUG=b:230201673 TEST=Ran on chrotomation without issue. Change-Id: I57397c7a19a86aa62d5320ae35ca72615115ba35 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3607074 Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2022-04-26auto_delete_nightly_test_data: s/.format()/f-stringsGeorge Burgess IV
Pylint complained about these, so fix them. BUG=b:230201673 TEST=None Change-Id: Ief092e828d3f153394c1d3dcc9da37380243fe39 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3607073 Tested-by: George Burgess <gbiv@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org>
2022-04-26auto_delete_nightly_test_data: formatGeorge Burgess IV
yapf doesn't like the current style in this file. fix it up. BUG=b:230201673 TEST=None Change-Id: I649c61d2165ffc089bdc05d768a54b7d339ed2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3607072 Tested-by: George Burgess <gbiv@chromium.org> Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Commit-Queue: George Burgess <gbiv@chromium.org>
2022-04-25afdo_metadata: Publish the new kernel profilesDenis Nikitin
Update chromeos-kernel-4.4 Update chromeos-kernel-4.14 Update chromeos-kernel-4.19 Update chromeos-kernel-5.4 Update chromeos-kernel-5.10 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: Ia33adce8ea17e7a542a450356840f3ded72789ba Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3606103 Tested-by: Denis Nikitin <denik@chromium.org> Auto-Submit: Denis Nikitin <denik@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
2022-04-25llvm_tools: add a nightly clang-tidy diagnostic checkerGeorge Burgess IV
This CL adds a tool that files bugs on us to evaluate new clang-tidy checks as they're landed upstream. The intent is for this to be run at some regular interval. Hopefully it can be extended to clang, too? BUG=None TEST=Ran a few times on my machine with the bug bits stubbed out Change-Id: I1736d6e18009bb4ea9ba0a9b4d068ed0331d3353 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3539313 Reviewed-by: Christopher Di Bella <cjdb@google.com> Commit-Queue: Christopher Di Bella <cjdb@google.com> Tested-by: George Burgess <gbiv@chromium.org>
2022-04-21toolchain_utils: s/Cr OS/CrOS/gGeorge Burgess IV
Result of running `sed -ri 's/Chrom(ium|e) OS/Chrom\1OS/g' $(find -type f)`. BUG=None TEST=None Change-Id: I59be92537aa19bc989f52b585e307e76dbde401b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3600147 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2022-04-06afdo_metadata: Publish the new kernel profilesManoj Gupta
Update chromeos-kernel-4.4 Update chromeos-kernel-4.14 Update chromeos-kernel-4.19 Update chromeos-kernel-5.4 Update chromeos-kernel-5.10 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: I55ee3a4799f0ecaab87ad1d8207d688c908fbea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3573011 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org>
2022-04-04llvm_tools: Add llvm_local_bisection.shJordan R Abrahams-Whitehead
This adds a template for a complete bash script for llvm local bisection. This template is from a script that llozano gave to ryanbeltran, but reworked to be easily extendable to other bisection steps. Comes with "batteries included" build_llvm and "build_pkg" functions. BUG=None TEST=Run on llvm-project as the `git bisect run` arg. Change-Id: Ibc0115033d07b76d40ec2f4b7d7950cf9a518152 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3563907 Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
2022-04-01crosperf: Remove veyron from remotesDenis Nikitin
Veyron was removed from the nightly toolchain testing. Remove it from remotes monitoring. BUG=b:227714343 TEST=None Change-Id: I23d0b6027b0a37e6ebcde77955fa00eb8941b2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3565860 Tested-by: Denis Nikitin <denik@chromium.org> Auto-Submit: Denis Nikitin <denik@chromium.org> Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org> Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org> Feels: Ryan Beltran <ryanbeltran@chromium.org>
2022-03-31afdo_metadata: Publish the new kernel profilesDenis Nikitin
Update chromeos-kernel-4.4 Update chromeos-kernel-4.14 Update chromeos-kernel-4.19 Update chromeos-kernel-5.4 Update chromeos-kernel-5.10 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: I1036ff48f370bfa11daeb401f143900aea2fb551 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3564694 Tested-by: Denis Nikitin <denik@chromium.org> Auto-Submit: Denis Nikitin <denik@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
2022-03-31llvm_tools: Add URL formatting for revert_checkerJordan R Abrahams-Whitehead
Copied from llvm-project/llvm/utils. This lets the revert_checker.py get called with the `-u` option which formats the revert SHAs into a handy URLs to the LLVM reviews. BUG=None TEST=revert_checker.py -C ../../llvm-project -u <SHA> HEAD Change-Id: I8dd90f20727a73a481a61519a9fb56364b20107c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3558477 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
2022-03-28lock_machine: use swarming binary instead of .pyRyan Beltran
This cl moves away from calling swarming.py in favor of direcly invoking the binary for swarming. The justification for doing so is this: 1) swarming.py in luci-client is now 3 years out of date 2) uprevving luci-client in the manifest could have unforseen impact on other consumers BUG=b:221777277 TEST=Verify in chrotomation Change-Id: I269ef5fb4a450f166bbff50c97a4d545680d028c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3553787 Reviewed-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org> Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
2022-03-25afdo_metadata: Publish the new kernel profilesLuis Lozano
Update chromeos-kernel-4.4 Update chromeos-kernel-4.14 Update chromeos-kernel-4.19 Update chromeos-kernel-5.4 Update chromeos-kernel-5.10 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: Ia84aafd0138f0de9df17d17b8db62e8b4bb4057d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3551233 Auto-Submit: Luis Lozano <llozano@chromium.org> Reviewed-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org>
2022-03-25lock_machine: specify python3 for swarmingRyan Beltran
swarming.py was being called with python2 which no longer exists in chrotomation. This was later changed to make the invokaction call swarming as an exexutable, however, this lead swarming.py to then invoke the default `python` executable which also doesn't exist in chrotomation and so a similar problem ensued. BUG=b:221777277 TEST=manually verified Change-Id: Ie6537b00a25fbc12cdeb95ada92d8095a609b291 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3553430 Reviewed-by: Luis Lozano <llozano@chromium.org> Commit-Queue: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org>
2022-03-19afdo_metadata: Publish the new kernel profilesDenis Nikitin
Update chromeos-kernel-4.4 Update chromeos-kernel-4.14 Update chromeos-kernel-4.19 Update chromeos-kernel-5.4 Update chromeos-kernel-5.10 BUG=None TEST=Verified in kernel-release-afdo-verify-orchestrator Change-Id: Id3ddbafa957b5d9f7bcf437ed50498ab81097b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3536829 Tested-by: Denis Nikitin <denik@chromium.org> Reviewed-by: Christopher Di Bella <cjdb@google.com> Commit-Queue: Denis Nikitin <denik@chromium.org>
2022-03-18update_kernel_afdo: Skip 5.10 update in M-100Denis Nikitin
Add mechanism to skip kernel versions in individual branches. BUG=None TEST=./afdo_tools/update_kernel_afdo stable Change-Id: Ic91ff99bd4dd2e57950376066ae2d4117c3845ed Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3536843 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org>
2022-03-18update_kernel_afdo: Update commmit message and commentsDenis Nikitin
BUG=None TEST=./afdo_tools/update_kernel_afdo Change-Id: Idcb3cfc4cd9c71f0e88b8d2f6a0f1ddf14ca3748 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3536832 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org>
2022-03-10lock_machine: remove python2 from call to swarmingRyan Beltran
swarming.py is being called with python2 which no longer exists in chrotomation. This was being done becuase swarming.py did not support python3 but this is no longer the case. BUG=b:221777277 TEST=manually verified that call executes the write script Change-Id: I2ec50a6f10b597ac7ca0a478e83eb9e2a5e3bb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3514287 Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org>
2022-03-08update_kernel_afdo: Add kernel 5.10Denis Nikitin
Add 5.10 and skip the kernel AFDO update if the channel does not support AFDO. Force worktree clean-up if the update fails. BUG=b:218702582 TEST=./afdo_tools/update_kernel_afdo main Change-Id: I9282e7cf600c27ba5a8b7e7329eae1512804af29 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3508821 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org>
2022-03-08update_kernel_afdo: Fix lint errorsDenis Nikitin
BUG=b:221882737 TEST=cros lint afdo_tools/update_kernel_afdo Change-Id: Ib4c5a19531400d8cad1060679cf167397ddb4540 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3508820 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org>
2022-03-05llvm_tools: Reformat all python llvm_toolsJordan R Abrahams-Whitehead
This CL runs `yapf` from inside the chroot for all python files in llvm_tools, except revert_checker.py, which comes from upstream LLVM. Also manually fixes some cros_lint backslash errors. BUG=None TEST=Presubmit checks Change-Id: I5f81fbdbbf954fe9ec591e641844f4ef3c17b73b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3503393 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
2022-03-05patch_sync: Use upstream branches, not mirrorsJordan R Abrahams-Whitehead
At present, on the automation system that runs patch_sync, we check out the main branch for AOSP & CrOS as a mirror locally. However, this leads to issues where the local mirror will detach from remote, and causes rebase conflicts that shouldn't happen. This patch makes us check out the remote in a detached state, which will update with the repo sync. BUG=b:221572478 TEST=Testing on mobiletc-prebuild Change-Id: I9124901f8d657fa9c25bc7125b374c5b9006f325 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3501012 Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com> Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
2022-03-04llvm_tools: Clean up start_, end_version entriesJordan R Abrahams-Whitehead
This removes any dangling end_version or start_version entry use in the patch_manager code. This forces all PATCHES.json to use the version_range schema. There was also a bug where end_version was being incorrectly set, which messed with nightly builders. BUG=None TEST=patch_manager_unittest.py TEST=cargo test Change-Id: If8fde535794b95a2cd80291f61a7b4d782b575ce Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3503392 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com> Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
2022-03-02nightly_revert_checker: add loggingGeorge Burgess IV
Android is reporting strange behavior for this script; logging the SHAs we observe on chrotomation each night will hopefully help us understand this. BUG=None TEST=Unittests Change-Id: Id3a41d9c5f9eae7021863bc994cedeb5469158ae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3498905 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>