aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-23toolchain: Add more boards to rotating builders.Manoj Gupta
Add fizz and zoombini boards to rotating builders testing. BUG=None TEST=fizz-llvm-toolchain-tryjob job is created. Change-Id: Ib985a53b8a96595877801a970efea5544f797c22 Reviewed-on: https://chromium-review.googlesource.com/881701 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2018-01-16toolchain: Add kahlee board to nightly llvm tests.Manoj Gupta
Kahlee is a new board using AMD stoney ridge platform. BUG=None TEST=Kahlee-llvm-toolchain-tryjob job is created. Change-Id: I2c04c482d63ba2bc1cb79ded4402a69618b4f2dc Reviewed-on: https://chromium-review.googlesource.com/869171 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org>
2017-12-27crosperf: Cleanup files downloaded with -tryjob suffix.Manoj Gupta
Add -tryjob suffix to cleanup list. Also remove whole directory not accessed in last day instead of trying to delete individual files/directories. This makes it easier to see only the preserved directories later on. + Minor tc_format related changes. BUG=None TEST=Directories to be deleted show up in dry run.y Change-Id: I711a8d9200686be56fb4f081682d76207dea368b Reviewed-on: https://chromium-review.googlesource.com/844897 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-11-30Remove droameo benchmarks from predefined sets.Luis A. Lozano
They were renamed (grouped) in chromium:777664 but, instead of using the new name, we are going to just remove them from the set. CWP data indicates these benchmarks are not representative. BUG=None TEST=None Change-Id: I034961d4f98eda0cb6ab7e706ac7309afbf23f69 Reviewed-on: https://chromium-review.googlesource.com/802714 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
2017-11-27Add '-tryjob' suffix to build name.Yunlian Jiang
We got some errors like These configs are not tryjob safe: link-llvm-next-toolchain Consider these configs instead: link-llvm-next-toolchain-tryjob when lauching tryjobs to get the image. This CL fixes that. BUG=none TEST=The build name is changed. Change-Id: I56ef66dfb1071367b78ee8a7335552cdae5a5b44 Reviewed-on: https://chromium-review.googlesource.com/791391 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-11-22filter out -tryjob when finding vanilla image.Yunlian Jiang
We cannot find vanilla image because the build name of trybot image was falco-release-tryjob, it then tries to find vanilla image of falco-release-tryjob, but it could not find it. BUG=none. TEST=vanilla image was found. Change-Id: I9024ea27f480db70ae296012a5958d8e243f3c38 Reviewed-on: https://chromium-review.googlesource.com/786315 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-11-21Add '-tryjob' suffix to build name.Yunlian Jiang
We got some errors like These configs are not tryjob safe: lumpy-release Consider these configs instead: lumpy-release-tryjob when lauching tryjobs to get the image. This CL fixes that. BUG=none TEST=the build name is set to lumpy-release-tryjob. Change-Id: I30086001e3937c956983f7c31b038b4a09b3ecec Reviewed-on: https://chromium-review.googlesource.com/781441 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-11-07[toolchain-utils] Fix security issue.Caroline Tice
Remove the chromeos-toolchain-credentials.json file, which should not be in a publicly visible repo. Update the buildbot_test_* scripts to take an argument for the directory containing the credentials file. Update the buildbot_utils.py file to use the credentials file argument, and to default to the location in our role account. BUG=782452 TEST=With some code commented out, did basic testing of flag/options to make sure they work as expected. Change-Id: I47a98a69b9ba8d2704d25abc37fe4447fa6ba343 Reviewed-on: https://chromium-review.googlesource.com/757901 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-10-31Remove startup.cold.blank_page as Chrome perf team removed it.Dean Liao
startup.cold.blank_page was removed by Chrome perf team: https://chromium-review.googlesource.com/c/chromium/src/+/644107 https://bugs.chromium.org/p/chromium/issues/detail?id=575762&desc=2 BUG=chromium:779484 TEST=./run_tests.sh Change-Id: Ib4cd3c2eaed2f496b8e25ab286919895adaa7571 Reviewed-on: https://chromium-review.googlesource.com/742778 Commit-Ready: Shuo-Peng Liao <deanliao@chromium.org> Tested-by: Shuo-Peng Liao <deanliao@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-10-05crosperf: Add new keys used in page cycler benchmarks.Manoj Gupta
croperf wasn't able to generate reports for page cycler since the names of tracked keys have changed. BUG=chromium:770802 TEST=Crosperf shows the results again. Change-Id: I02561bf577a342d9a1f26ece19b011edbdf0776f Reviewed-on: https://chromium-review.googlesource.com/701260 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-10-03[bisection tool] Fix bisect_driver.py and udpate for host bisection.Caroline Tice
This CL udpates bisect_driver.py to consolidate all the various versions we have into one "source of truth" bisect_driver.py. It also updates bisect_driver.py to ignore .o files generated during the 'configure' stage of Makefile/Autoconf packages (such as GCC & LLVM). And it adds two scripts to help with host package bisection. BUG=chromium:697995 TEST=Successfully ran unit tests; successfully bisected LLVM inside ChromeOS. Change-Id: I2e766299dadf9bf3c7de6496f507c863d446d00d Reviewed-on: https://chromium-review.googlesource.com/696031 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-09-29Rotating builders: s/reef/pyro and s/squawks/swanky/Manoj Gupta
Kernel team has rolled clang based kernel on kevin/pyro/swanky boards. We should update rotating builders to match this and catch any kernel related issues in llvm-next testing. CQ-DEPEND=CL:692633 BUG=chromium:770267 TEST=jobs are launched. Change-Id: If9f713193ec25cd0e13d7df369f09733e66ef247 Reviewed-on: https://chromium-review.googlesource.com/693135 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-09-29crosperf: Fix experiment_factory_unittest.Manoj Gupta
Remove x86-alex to fix crosperf unit tests. BUG=None TEST=crosperf unit tests pass. Change-Id: Ia494bb201272416b728cdd2c11d9bca712530b11 Reviewed-on: https://chromium-review.googlesource.com/693004 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-09-29buildbot_test_toolchain: return 2 if trybot fails.Yunlian Jiang
We will print out the trybot url in the sheriff email if the trybot fails. To to that, we need to set return value to 2 if the trybot fails. BUG=chromium:767524 TEST=None Change-Id: Id3a8eb2cbcb8f85ada28ea11d4faf9113c9369ba Reviewed-on: https://chromium-review.googlesource.com/692620 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-09-07crosperf: remove x86-alex machines from default_remotesYunlian Jiang
We are no longer using x86-alex machines, so we can remove them from default_remotes. This also fixes the nightly job Checking lab machines. BUG=None TEST=None Change-Id: I22e252e63b9f6f1cf46b1d5bb83c13af71fd8382 Reviewed-on: https://chromium-review.googlesource.com/655481 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-09-06USE local lock for buildbot_test_toolchain.Yunlian Jiang
Currently the AFE lock machanism for our nightly test is broken, we use local lock as a workaround for now. BUG=chromium:762589 TEST=Generate the crosperf command in another simple python file with the same code. Run the generated command line on crotomation2 and it goes though the locking machine stage. Change-Id: Icd3132bc383b63aab6d6f5237a04348f11d8726d Reviewed-on: https://chromium-review.googlesource.com/653213 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-08-23Force all toolchain tests as run_local: False.Manoj Gupta
wprgo package is missing for arm32. So we cannot run these tests locally till wprgo for arm32 is provided. BUG=chromium:754374 TEST=crosperf job is created with run_local:False Change-Id: I6503017f9350684988305d8a7d6432574dab04d6 Reviewed-on: https://chromium-review.googlesource.com/629716 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
2017-08-18Move cbuildbot flags to tryjob flagsTing-Yuan Huang
They are now available and needn't to be pass through. BUG=chromium:756100 TEST=buildbot_test_toolchains.py Change-Id: Icece6e74faa8966067346a3a5fc111c9fdb5e431 Reviewed-on: https://chromium-review.googlesource.com/622309 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org>
2017-08-16Switching from cbuildbot to cros tryjobTing-Yuan Huang
BUG=chromium:756100 TEST=buildbot_test_toolchains.py, buildbot_test_llvm.py Change-Id: Ie275b960afdb2ed7183a763302af70c3f2bc1092 Reviewed-on: https://chromium-review.googlesource.com/617404 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-08-15Update rotating builders list to match chromeos_config.Caroline Tice
Add 3 new boards and remove 2 redundant boards from the rotating builders list, to match the complete list for the rotating builders in chromeos_config. This should (currently) represent a complete list of platforms to test before toolchain upgrades. BUG=chromium:754803 CQ-DEPEND=CL:611486 TEST=None Change-Id: Idf8da7e1660e4ad3716fd813e46f7b3c62d0bf7a Reviewed-on: https://chromium-review.googlesource.com/612215 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
2017-08-03[toolchain-utils] update script to generate waterfall reports.Caroline Tice
This CL updates the script that generates the toolchain team daily waterfall reports: It adds an --email option, to specify an alternate person to receive the report; it removes the waterfall builders we no longer care about; and it doesn't attempt to update report data when the URL file is inaccessible. This is part of the work to make these run automatically every day. BUG=chromium:749962 TEST=Ran script in my directory and it worked. Change-Id: Iaf7c763ee8b7e3f6d32fd617cf511713dcd892ce Reviewed-on: https://chromium-review.googlesource.com/599005 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-07-27crosperf: remove duplicated benchmark in all_crosbolt_perfYunlian Jiang
This removes the duplicated benchmark video_PlaybackPerf.h264 in all_crosbolt_perf BUG=None TEST=the duplicated test was removed. Change-Id: Id4822fc1b82986cba2847b2e32ef825e90969c58 Reviewed-on: https://chromium-review.googlesource.com/590359 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-07-21Modify the method to patch synthmarkZhizhou Yang
The old way to patch synthmark kept a .mk file which will cause build failing. Have put the .mk file patch into a diff file so that Android building system will not see a .mk file here. BUG=None TEST=Checkbuild succeeded with this patched to external/toolchain-utils on Android side. Change-Id: I704aa02d9ca91098727786f053aeb26e989bd481 Reviewed-on: https://chromium-review.googlesource.com/581869 Commit-Ready: Zhizhou Yang <zhizhouy@chromium.org> Tested-by: Zhizhou Yang <zhizhouy@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org>
2017-07-18Add Android toolchain benchmark suiteZhizhou Yang
Add Android toolchain benchmark suite into toolchain-utils, which will be synced to Android Repository. BUG=None TEST=None Change-Id: Iee1ba9aa21a99ff6ce8d669c59d53af6e953703c Reviewed-on: https://chromium-review.googlesource.com/569481 Commit-Ready: Zhizhou Yang <zhizhouy@chromium.org> Tested-by: Zhizhou Yang <zhizhouy@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org>
2017-07-13[bisect tool] Fix full test to work with ChromeOS as well as Android.Caroline Tice
The run_bisect_test.py script worked well for Android but had a few hiccups for testing the ChromeOS compiler wrapper. This CL fixes that. BUG=chromium:741812 TEST=Ran test successfully outside the chroot with Android compiler wrapper; ran test succesfully inside chroot with ChromeOS compiler wrapper. Change-Id: Id5f737932064497e0dfaff9ba3ac53b4c1c87373 Reviewed-on: https://chromium-review.googlesource.com/568407 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-07-11Fix compiler bisection tests nowrapper script.Manoj Gupta
SAVE_DIR was being overwritten. Inside the condition, SAVE_DIR is not needed. Just use DIR directly. BUG=chromium:740230 TEST= ./full_bisect_test/run-test-nowrapper.sh works. Change-Id: Ic35d3039f6fd31f2a5f3a0d4812568eaceda4742 Reviewed-on: https://chromium-review.googlesource.com/567364 Reviewed-by: Caroline Tice <cmtice@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org>
2017-06-29Add 'lakitu' and 'whirlwind' to rotating builders.Caroline Tice
BUG=chromium:736862 TEST=Successfully ran trybots on lakitu-gcc-toolchain and whirlwind-llvm-toolchain builders. Change-Id: Icce7d18d2df0747d67f84c99ed233f910790ee4b Reviewed-on: https://chromium-review.googlesource.com/557279 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-06-16Build with -cros-debug by default.Luis A. Lozano
We need to make sure that we are building without asserts. BUG=None TEST=local build succeeded. Change-Id: Ifdac90c6c3f8fb3fc027cb1d8e3cfbeec21ba398 Reviewed-on: https://chromium-review.googlesource.com/537996 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
2017-06-06Crosperf: Mark benchmark run as failed if it contains no results.Manoj Gupta
Sometimes telemetry tests do not fail but results are empty. In that case, mark the run as failed explicitly. BUG=chromium:729634 TEST=Tested manually on failing lummpy nightly tests. The generated report shows tests as failed as expected. Change-Id: Ia52af887e81ed630d7578f9abe93f9656c70512b Reviewed-on: https://chromium-review.googlesource.com/526392 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
2017-06-06Add scripts for usb-only flashing for cros package bisecting.Caroline Tice
BUG=None TEST=None Change-Id: I0927bdb69d80c55cfccf0ea9c0ae3ad4ef554f2f Reviewed-on: https://chromium-review.googlesource.com/525840 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
2017-05-31Verify manifest is in paladin before trying to use it.Caroline Tice
With increasing frequency the lumpy nightly test fails very early because it ends up trying to get a manifest that only exists in Android, not in ChromeOS. This CL adds code to verify the manifest version actually exists in the paladins list before trying to use it. BUG=chromium:726778 TEST=Tested this code in the nightly build tests and it worked. Change-Id: I86f8eb9c8e28fd4a404bc63d49d8d9fb27de8b3b Reviewed-on: https://chromium-review.googlesource.com/517266 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-05-25Remove toolchain_tests from the report.Luis A. Lozano
We don't use that suite anymore. So, remove it from the report. It was causing an exception. BUG=None TEST=Generated report without any issues. Change-Id: Ie1c42b47a53e4d6e8a2665fdfba91d8d2ac963dc Reviewed-on: https://chromium-review.googlesource.com/511866 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-05-24Start testing compiler-rt with llvm-next.Manoj Gupta
We want to test compiler-rt performance and stability. So start testing llvm-next with compiler-rt as default using CL 513590. BUG=chromium:705071 TEST=buildbot runs with CL 513590 are fine for daisy, squawks, elm and peppy. Change-Id: Ic43ef238c7fce0cb88caabab7e6a32b1940cb860 Reviewed-on: https://chromium-review.googlesource.com/514302 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-05-17Fix results_organizer_unittest.pyCaroline Tice
Now that multiple iters inside a single run all report the correct pass/fail status, update the unittest to reflect that (is has been broken now for about a month). BUG=chromium:723807 TEST=ran unittest with fix and it passes now. Change-Id: Ie92034bbf073b73ce820f28c238f99192840197f Reviewed-on: https://chromium-review.googlesource.com/508277 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-05-17Disable beeps post reboots in crosperf.Manoj Gupta
Run gbb command before flashing to avoid post reboot beeps if possible. It works only on machines with Write Protect Disabled. Crosperf prints the erros messages and continues if this fails. BUG=chromium:697609 TEST=Tested on kevin, daisy and jaq. Change-Id: Ifb0c819281b3215655b7e3b02db605fa073d0e12 Reviewed-on: https://chromium-review.googlesource.com/508153 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-04-28Add reef board to rotating builders.Manoj Gupta
Add reef board and update caroline description. Change number of boards tested daily to 3. BUG=None Test=3 jobs send to cbuildbot (print only). Change-Id: I95e7d608b81c5358158c9e8f9d467fbcba74670e Reviewed-on: https://chromium-review.googlesource.com/490637 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org>
2017-04-25buildbot_test_toolchains: get latest instead green vanilla buildTing-Yuan Huang
So as to work around the problem that some builders' latest green builds are too old. BUG=chromium:714890 TEST=Tested _GetVanillaImageName locally. Change-Id: I06571f3d55743fb56977d7ef56a51fcddfdda62e Reviewed-on: https://chromium-review.googlesource.com/486086 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>
2017-04-20Crosperf: Rename chrotomation2.mtv to chrotomation2.svl.Manoj Gupta
BUG=None Test=Local DUT crosperf run works. Change-Id: I6ef3e3c14a01032be063e963d716a3cc03d576d9 Reviewed-on: https://chromium-review.googlesource.com/483048 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-04-14[toolchain-utils] Remove --do-not-use-buildbucket flagCaroline Tice
This implements the correct way to find the remote description so that we do not need to disable the buildbucket authentication. BUG=chromium:711430 TEST=Launched nightly buildbot job and it was able to find correct build log. Change-Id: I0a2e16ec284bae46af684daf3abcbbea1b9c3fe9 Reviewed-on: https://chromium-review.googlesource.com/478010 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-04-13[toolchain-utils] Workaround for new bug in cbuildbot.Caroline Tice
There's a regression/bug in the cbuildbot stuff that is causing all of our cbuildbot jobs to be unable to find their build records, which causes them to fail. Adding the flag '--do-not-use-buildbucket' is a workaround that temporarily fixes this problem. This CL adds that flag to all of our cbuildbot jobs. BUG=chromium:711430 TEST=Launched cbuildbots with & without this flag; saw the problem without the flag; with the flag the problme was gone. Change-Id: I75219dad55e762ce2d5f0e3b6d885a8e91be014e Reviewed-on: https://chromium-review.googlesource.com/477391 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-04-08[crosperf] Fix status reporting for multiple iters inside a single run.Caroline Tice
If a single benchmark run contains multiple iterations (like BootPerfServer), then only the first internal iteration was getting the correct pass/fail status, so even though everything passed the report title would claim 1 pass and 9 fails (for 10 internal iterations). This fixes that. BUG=chromium:426960 TEST=Ran BootPerfServer with change. Now shows correct number of passes/fails for the iterations. Change-Id: I9638b39c94692fd754698e64d89cb22c10e9d479 Reviewed-on: https://chromium-review.googlesource.com/470547 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-04-08[toolchain-utils] Fix remaining lint errors in toolchain-utils.Caroline Tice
In addition to fixing the lint errors, this also fixes the Python formatting issues (ran tc_pyformat on nearly all the files). BUG=chromium:570450 TEST=Ran all crosperf & bisect tool unit tests. Ran afe_lock_machine.py (check machine status) Ran full crosperf test (octane, speedometer, BootPerf) on alex. Change-Id: Ic86f9192801ac67769f3de30f1c5f0d203ce0831 Reviewed-on: https://chromium-review.googlesource.com/471886 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-03-20set the default compiler to llvm.Yunlian Jiang
Since we finished the migration to llvm. So we need to set the default compiler string to llvm. BUG=None TEST=The default compiler is set to llvm. Change-Id: I2d58c2850af5cc4d5f3a13e7bd2a68cd41d3ffb0 Reviewed-on: https://chromium-review.googlesource.com/457263 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-03-17Set scaling governor to performance in crosperf.Manoj Gupta
Elm seems to have stable numbers when only governor is set. Disable turbo is intel pstate thermal driver is used. Tested on squawks and lumpy. Includes some minor tc_pyformat changes. BUG=chromium:700190 TEST=Tested on elm, squawks, lumpy, kevin, falco and veyron_jaq. Change-Id: Ib368234b3bde5e54ff9b53ae3766e7384bd1df5f Reviewed-on: https://chromium-review.googlesource.com/454299 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-03-17Remove reference to chromeos.gyp.Justin TerAvest
chromeos.gyp is used here to detect a path to a valid chrome browser checkout. I'd like to get rid of chromeos.gyp, so this changes the logic to use BUILD.gn, which was added to the source in June 2014. BUG=chromium:701617 TEST=None Change-Id: I16f1705874bb8acafca0d3c38211f5e192e00a33 Reviewed-on: https://chromium-review.googlesource.com/455279 Commit-Ready: Justin TerAvest <teravest@chromium.org> Tested-by: Justin TerAvest <teravest@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
2017-03-16Remove user_activity_benchmarks.Ting-Yuan Huang
It's going to be hosted in CWP. BUG=None TEST=None Change-Id: I16374dd23e6871f4cf3ab5665b6f7b71336175b1 Reviewed-on: https://chromium-review.googlesource.com/456517 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org>
2017-03-16Use bash as the default shell for command execution in crosperf.Manoj Gupta
subprocess.Popen defaults to /bin/sh, however, the intended behavior is running them with bash. BUG=None TEST=Synatx error in . remote_access.sh is gone. Crosperf unit tests passed. Change-Id: I059ba9736e5ad3023b5c0a2201f6b40d11ddbe6e Reviewed-on: https://chromium-review.googlesource.com/452862 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-03-14crosperf: update unittest for 8332364cTing-Yuan Huang
BUG=chromium:699645 TEST=./crosperf/setttings_factory_unittest.py Change-Id: Iedab40ce6d6cf4e272a080134730a175f769c4e7 Reviewed-on: https://chromium-review.googlesource.com/452540 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-03-10Reformat cros_utils/command_executer.py using latest tc_pyformat.Manoj Gupta
This is to avoid reviewing unnecessary white space changes later on. BUG=None TEST=Crosperf Unit Tests Passed Change-Id: I0beea920e7c2a385220de26022403333a374ef67 Reviewed-on: https://chromium-review.googlesource.com/453104 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
2017-03-10crosperf: make default iterations of benchmarks >= 2Ting-Yuan Huang
So as to get standard deviations, which are needed in ttest for p-value. TEST=none BUG=none Change-Id: If59fb46b62c0cb58610507962f8ca13ccc0b7d01 Reviewed-on: https://chromium-review.googlesource.com/452796 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-20 04:57:14 +0000