| Age | Commit message (Collapse) | Author |
|---|
|
Occasionally the local AFE server goes down; this currently causes
the afe_lock_machine.py script to fail, whether the user is trying
to lock a local machine or not. This CL fixes that, so if the user
specified a HW Lab machine, we don't try to look at the local
server at all. Also cleans up some formatting.
BUG=chromium:647427
TEST=Tested getting status of lab machine when local server was
down.
Change-Id: Iff7799b2deea142bcbd85f0e3373cf0462590b72
Reviewed-on: https://chrome-internal-review.googlesource.com/287456
Commit-Ready: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>
|
|
This CL finishes switching the subdirectory from 'utils' to
'cros_utils'. It changes all the remaining import statements to
use 'cros_utils'; it removes the 'cros_utils' symlink, and it
renames the 'utils' subdirectory to 'cros_utils'.
BUG=chromium:568195
TEST=ran crosperf & binary search tool unittests.
Change-Id: I7427f8bfb2ddac3a4b6108e46782039059684382
Reviewed-on: https://chrome-internal-review.googlesource.com/270396
Commit-Ready: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Cassidy Burden <cburden@google.com>
Reviewed-by: Luis Lozano <llozano@chromium.org>
|
|
BUG=chromium:567921
TEST=these three files are lint warning free.
Change-Id: I23f9120283fc82958abcc16f47cd29d5800bd181
Reviewed-on: https://chrome-internal-review.googlesource.com/242485
Commit-Ready: Yunlian Jiang <yunlian@google.com>
Tested-by: Yunlian Jiang <yunlian@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
|
|
This gets rid of a lot of lint issues.
Ran by doing this:
for f in *.py; do echo -n "$f " ; if [ -x $f ]; then pyformat -i
--remove_trailing_comma --yapf --force_quote_type=double $f ; else
pyformat -i --remove_shebang --remove_trailing_comma --yapf
--force_quote_type=double $f ; fi ; done
BUG=chromium:567921
TEST=Ran simple crosperf run.
Change-Id: I59778835fdaa5f706d2e1765924389f9e97433d1
Reviewed-on: https://chrome-internal-review.googlesource.com/242031
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
|
|
BUG=None
TEST=Ran crosperf with newly formatted file.
Change-Id: I998b75761281a1ce9b0af8f606b47be8b8ca6aee
Reviewed-on: https://chrome-internal-review.googlesource.com/241175
Commit-Ready: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
|
|
Before this, this script was confusing because it would display
lab machine names without the '.cros' at the end, but it would require
the '.cros' at the end of lab machine names (from users) to recognize
them. This CL fixes that: Now when displaying machine status, it
makes sure the .cros is at the end of the lab machine names; and it
makes sure the various functions work for lab machines whether or not
the user specified the '.cros' at the end of the machine name (it adds
it automatically, if it's missing).
BUG=chromium:525198
TEST=Tested all the commands on lab machines with and without '.cros'.
Change-Id: I8fd36d116c3c542fad936be73b946c88a9228551
Reviewed-on: https://chrome-internal-review.googlesource.com/240880
Commit-Ready: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
|
|
Change the afe_lock_manager, so that an attempt to lock an already
locked machine or unlock an already unlocked machine is a warning
rather than an exception; also return a list of machines which we
were successfully able to lock/unlock.
Also update Crosperf: Previously if multiple machines were requested
and we were not able to lock all of them, the Crosperf job failed.
Now if we are able to successfully lock any of the requested machines,
Crosperf will try to run the job.
BUG=None
TEST=Tested in my workspace with various locked/unlocked
configurations for crosperf job with two machines.
Change-Id: I65a0a9cce4b8be8d0c043913dc2dd7f9f07cda0f
Reviewed-on: https://chrome-internal-review.googlesource.com/224180
Reviewed-by: Han Shen <shenhan@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
|
|
The local AFE server has been updated to use the newer code base,
and now it requires a locking reason (previously only the global
AFE server required one). Now the lock reason will be given
for both servers.
BUG=None
TEST=Tested in my work area with a local DUT.
Change-Id: I74ea1941b4c04d9647cc3bde6b1f1cce80c225b5
Reviewed-on: https://chrome-internal-review.googlesource.com/223810
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Caroline Tice <cmtice@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
|
|
BUG=None
TEST=Tested in role account on chrotomation2.mtv.
Change-Id: I97661c14427989b084c5394a040e1055c47d90a9
Reviewed-on: https://chrome-internal-review.googlesource.com/219042
Reviewed-by: Han Shen <shenhan@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
|
|
Rahul and I were having problems running crosperf outside crosperf
directory, the problematic we got was here -
./afe_lock_machine.py:181: machines_file = os.path.join(os.getcwd(), 'crosperf', 'default_remotes')
This assumes that crosperf is invoked right under toolchain-utils,
which is, as likely as not, false.
|
|
This CL implements a new machine locking mechanism using
Autotest Front End servers. When locking/unlocking a lab machine,
it uses the ChromeOS HW lab server; when locking/unlocking a local
machine, it uses a local AFE server on chrotomation2.
BUG=None
TEST=Tested the script manually to lock/unlock machines and query status.
Also tested with image_chromeos and with crosperf scripts.
Change-Id: I2793bc1f7dc056e725694e81ded656d9f49d227b
Reviewed-on: https://chrome-internal-review.googlesource.com/217560
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: David Sharp <dhsharp@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
|
