Age | Commit message (Collapse) | Author |
|
[-Werror, -Wgnu-offsetof-extensions] shows up in the bazel when it builds
@upb as part of the bazel testing.
upb revision wasn't updated in the latest bazel and there are no obvious
ways to patch bazel deps, so let's just suppress the warning.
BUG=b:280021348
TEST=go test
Change-Id: Ia972537114629ed5157c47681734a0a2bce22e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4515855
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Denis Nikitin <denik@chromium.org>
Tested-by: Denis Nikitin <denik@chromium.org>
|
|
When we land the llvm uprev we will need to move these flags over to the
current LLVM flags.
BUG=b:254289728
TEST=go test
Cq-Depend: chromium:4133805
Change-Id: I6a20b3695983be194e2ccddc3d35e80f052e87bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4133825
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
|
|
This CL adds -D_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES in the compiler
wrapper to reenable some removed C++ features for C++17. This should be
removed once we can get rid of all offending usages but is necessary for
now to unblock the next LLVM uprev.
BUG=b:263380440
TEST=go test . -update golden
TEST=CQ in the associated llvm CL
TEST=Verified works as intended in a repro with Compiler Explorer
Change-Id: I5ab45867432eef672aef8202667bc5ede39b86a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4122447
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
|
|
This CL adds -Wno-incompatible-function-pointer-types to disable
the warning and fix some mage problems.
BUG=b:260925814, b:249834910
TEST=emerge-atlas coreutils
Change-Id: I48723f046994e9453d15c0df7e9dd94e320ea326
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4066867
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
|
|
This CL adds -Wno-int-conversion to disable the warning and fix some
mage problems.
BUG=b:259158067
TEST=Added to failing compile command in sharutils
Change-Id: I63e20ffa5ba64dd350f225d90e0de0a8554dc195
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4066865
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
|
|
We previously passed -fexperimental-new-pass-manager to Clang to turn on
the new pass manager. The new pass manager has been made the default,
and -fexperimental-new-pass-manager has become a no-op. In newer
versions of LLVM, it has been removed. This means these versions
of LLVM will fail when the flag is passed in. To make compiler_wrapper
compatible with these versions, remove the flag.
BUG=b:258854887
TEST=build new wrapper, build LLVM that doesn't have the flag, see it work
Change-Id: I2bb6de0075973b0b2cdb7700306b094ec1e08de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/4061509
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Tested-by: Bob Haarman <inglorion@chromium.org>
Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org>
|
|
This CL add the Wno-unused-but-set-variable flag back into the compiler
wrapper. It was previously removed, but there are still occurances of
the warning and so we were never able to bundle that change into
chromoumos-overlay/llvm. An attempt to revert the original CL failed due
to a merge conflict.
BUG=b:227655984
TEST=None
Change-Id: Ic148a6ae577d5e4394249693ce9b09b95cb9df16
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3868978
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
|
|
Wimplicit-int has been promoted to be an default error
even with Wno-error. Disable the error by default since it is breaking
a lot of packages.
BUG=b:231987783
TEST=cq
Change-Id: If88877cb63cdd5c392fcf05c2940751547466213
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3642338
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
|
|
This CL sorts clang flags, and puts ones shared across all CrOS
configurations into their own textual blocks. This should make factoring
these out into their own function not require golden updates, which
makes verifying the CL that actually _does_ that simpler.
BUG=b:232114933
TEST=go test
Change-Id: I7dc6110d680505d4ad2af98709730e85c386ae5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639682
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
|
|
Since order doesn't matter, make this sorted. Otherwise, these are all
shared, so no point in repeating them.
BUG=b:232114933
TEST=go test
Change-Id: Ide3c620de9018fed3fe8d898b21b3d5d4f42700f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639281
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
|
|
Wimplicit-function-declaration has been promoted to be an default error
even with Wno-error. Disable the error by default since it is breaking
a lot of packages.
BUG=b:230345382
TEST=cq
Change-Id: Ib46b0b47a3e1dea3797739370a4d9cf92a4d25f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3637117
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
|
|
This CL adds a Wno-unused-but-set-var flag that was accidentally missing
in a clangPostFlags field. THis is already present in the llvm repo,
must have been fixed in there without mirroring it.
BUG=b:195433889
TEST=None
Change-Id: I23fcc91aee7b316cd70652f0119177d5ebdf7bbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3319338
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
|
|
BUG=b:191618957
TEST=wrapper test
Change-Id: I4340173ae681a6c5f022a3b1f1e890d2c9ee8b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3036676
Commit-Queue: Luis Lozano <llozano@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Auto-Submit: Luis Lozano <llozano@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
|
|
Also update the golden tests appropriately.
BUG=chromium:924760
TEST=Already tested/committed in llvm/files/compiler-wrapper.
Change-Id: I0cac1f60874d7c473a3a79e37c0eddbe3e5dfed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2683254
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
|
|
pass "-fcommon" to GCC to match clang. This is needed
since GCC 10 defaults to "-fno-common".
BUG=chromium:1171833
TEST=go test
Change-Id: Iceac503c8cc14afc1837c6952100189f45d2b567
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2657043
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
The new Clang version has a number of new warnings which we disable. This CL
makes those apply to llvm (current) as well as llvm-next.
BUG=None
TEST=go test
Change-Id: I1f4929580953003d21676e7e72af4577592fb217
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2561725
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
|
|
Since we now have crashArtifactsDir as a more abstract concept, it seems
good to apply '-fcrash-diagnostics-dir=' based on that, rather than
having it as an explicit clang flag.
BUG=chromium:1113442
TEST=FIXME
Change-Id: I147779d7cf8806b3bc712c2998446158e87ec967
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2343975
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
|
|
LLVM is currently build with DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=ON on
Chrome OS. This is however not reflected in clang crash diagnoses.
Adding -fexperimental-new-pass-manager to help with reproducibility on
4c.
BUG=chromium:1111103
TEST=CQ tests.
Change-Id: Ie01431dff397e982469e29c9132e21374354762d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2327414
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Jian Cai <jiancai@google.com>
|
|
-grecord-gcc-switches causes the compiler and compiler flags to be
stored in the produced debug information. This causes Goma builds to
be non-deterministic, because the compiler path differs depending
on whether the compiler was run locally or on Goma. This, in turn,
causes cache pollution and needless work. Since we are not in
fact using the information stored by -grecord-gcc-switches, this
change disables it. We can re-enable it when we want to start
using the information, provided we come up with another way to
avoid the issues described earlier.
BUG=chromium:1103065
TEST=Build an object file in chromeos-chrome and check that info is absent
Change-Id: Ib8022a3a1baf2e4b5d3d9d1453deb67f539baff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2290624
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Tested-by: Bob Haarman <inglorion@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tiancong Wang <tcwang@google.com>
|
|
Redirect all diagnoses of clang crashes to a dedicated directory using
fcrash-diagnostics-dir so we can upload these files to the cloud. The
flag was added to clangPostFlags to overwite redirection done on package
level.
BUG=chromium:1056904
TEST=None
Change-Id: I78bfc77d7f3af8556b4308f2e71407d627627747
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2251038
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Jian Cai <jiancai@google.com>
Tested-by: Jian Cai <jiancai@google.com>
|
|
Clang ToT has switched to "-fno-common" as default to match GCC 10 which
breaks many packages. Upgrading to ToT versions of many packages does not
fix the problem as packages upstream have not fixed them yet.
Pass "-fcommon" in compiler wrapper to workaround this for now.
This does not change the current clang behavior which defaults to
"-fcommon" so this is a NFC.
BUG=chromium:1060413
TEST=packages build with ToT clang; NFC for current clang
Change-Id: I5a40e502db201615f45a7e4720105bebef2f2b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2102905
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
Chrome OS code now is clean of following warnings:
"-Wreorder-init-list" and "-return-stack-address" so
stop disabling them.
BUG=chromium:1057384
TEST=warnings tested by CL:1898670
Change-Id: I568cf93a9e836ba936ea976312e9a78b5c473157
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2081707
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
BUG=chromium:1001317
TEST=In progress
Change-Id: I78481d2ca3f555d670e7e5972e547f94d2be22a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1888745
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
|
|
Match the changes to python wrapper in CL:1686078.
Also add small fix for echo path, it should be /bin/echo
instead of /usr/bin/echo.
BUG=chromium:979909
TEST=go test
Change-Id: I5e626febd5abab4f9824aba1e158f264bf75be9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1803778
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
|
|
BUG=chromium:773875
TEST=unit tests, compile cross-armv7m-cros-eabi/newlib
Change-Id: Ia98442a69b01cff87c52b6ac84dc39c47d5e998e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1760465
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Previously, a golden file contained multiple names sections.
This change splits these into separate files, making
changes easier to compare.
BUG=chromium:773875
TEST=unit test
Change-Id: Icffec335601297f504f98c4ff1654238f7838080
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1752523
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|