Age | Commit message (Collapse) | Author |
|
This CL moves flags added for LLVM Next that disabled
variable_unused_but_set warnings to PostFlags in order to make sure it
gets added after Wall and Wextra.
BUG=b:195433889
TEST=reran package tests
Change-Id: Icdd2cbe3ced7b8427257c87f9e527b0d0e8da57d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3214640
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
|
|
Tests are failing at HEAD; looks like prior changes forgot to update
these.
BUG=None
TEST=go test
Change-Id: Ia88b182ba0a922807f0857d8dc3df96de4528aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3162666
Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
|
|
Do not add static-libgcc to compiler command line if user
is passing {shared|static}-libgcc.
BUG=b:187794119
TEST=CQ
Change-Id: Iecd969dd11632837013bea71df9547bd08bbf30c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3064572
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
|
|
Update compiler wrapper for migrating the wrappers from
gcc to llvm ebuild.
This assumes that clang wrappers now live in /usr/bin/
instead of /usr/x86-64-pc-linux-gnu/... and is no longer
co-located with gcc wrappers.
BUG=b:186803617
TEST=CQ, SDK tryjobs
Change-Id: I60082913dbf5a3c6ce992ea951955086b280af43
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3046721
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
BUG=b:191618957
TEST=wrapper test
Change-Id: I4340173ae681a6c5f022a3b1f1e890d2c9ee8b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3036676
Commit-Queue: Luis Lozano <llozano@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Auto-Submit: Luis Lozano <llozano@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
|
|
This is in preparation for our migration to libunwind.
BUG=b:187785190
TEST=Tested locally and on CQ
Disallow-Recycled-Builds: test-failures
Change-Id: I1b11d54de3d9550086ead05c3880f149e2e2f839
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2945100
Tested-by: Christopher Di Bella <cjdb@google.com>
Tested-by: Luis Lozano <llozano@chromium.org>
Auto-Submit: Christopher Di Bella <cjdb@google.com>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
|
|
This functionality causes problems for several packages and it
seems to be only of importance for instrumented profiling which
we don't use.
BUG=b:187743526
TEST=CQ
Change-Id: I441b96223dc8e09eb113608b85cde918faf2753f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2943079
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Auto-Submit: Luis Lozano <llozano@chromium.org>
|
|
ToT clang needs --prefix is needed to find the correct tools.
BUG=chromium:1182224
TEST=Updated compiler wrapper in SimpleChrome, nacl builds.
Change-Id: I8073e1a5482a23f38bb1e0d88e2b31ee2d97fa6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2721199
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Also update the golden tests appropriately.
BUG=chromium:924760
TEST=Already tested/committed in llvm/files/compiler-wrapper.
Change-Id: I0cac1f60874d7c473a3a79e37c0eddbe3e5dfed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2683254
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
|
|
pass "-fcommon" to GCC to match clang. This is needed
since GCC 10 defaults to "-fno-common".
BUG=chromium:1171833
TEST=go test
Change-Id: Iceac503c8cc14afc1837c6952100189f45d2b567
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2657043
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
This updates the compiler wrapper flags to match recent updates to
compiler wrapper in sys-devel/llvm (for llvm-next).
BUG=chromium:1133468
TEST=None
Change-Id: Ibab9f0e1d0e35db3ba838e70a812efe2d5137a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2448871
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
|
|
This CL updates toolchain-utils to match recent compiler wrapper
changes in sys-devel/llvm/files. It's purpose is to disable the
new warning -Wcompound-token-split-by-space.
Also update golden tests appropriately.
BUG=chromium:1130080
TEST=Previous CL already tessted/committed.
Change-Id: I261250dc7ed6f1be7c3aa4652d793c924e1dc18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2423619
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Auto-Submit: Caroline Tice <cmtice@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
LLVM implemented some flags that used to not be supported. Remove these
flags from unsupported flags in the wrapper.
BUG=chromium:1112929
TEST=tested locally.
Change-Id: If91df0d35ac3db926067d3e0c5e213f6c5e3f390
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2346956
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Jian Cai <jiancai@google.com>
|
|
Since we now have crashArtifactsDir as a more abstract concept, it seems
good to apply '-fcrash-diagnostics-dir=' based on that, rather than
having it as an explicit clang flag.
BUG=chromium:1113442
TEST=FIXME
Change-Id: I147779d7cf8806b3bc712c2998446158e87ec967
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2343975
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
|
|
LLVM is currently build with DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=ON on
Chrome OS. This is however not reflected in clang crash diagnoses.
Adding -fexperimental-new-pass-manager to help with reproducibility on
4c.
BUG=chromium:1111103
TEST=CQ tests.
Change-Id: Ie01431dff397e982469e29c9132e21374354762d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2327414
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Jian Cai <jiancai@google.com>
|
|
-grecord-gcc-switches causes the compiler and compiler flags to be
stored in the produced debug information. This causes Goma builds to
be non-deterministic, because the compiler path differs depending
on whether the compiler was run locally or on Goma. This, in turn,
causes cache pollution and needless work. Since we are not in
fact using the information stored by -grecord-gcc-switches, this
change disables it. We can re-enable it when we want to start
using the information, provided we come up with another way to
avoid the issues described earlier.
BUG=chromium:1103065
TEST=Build an object file in chromeos-chrome and check that info is absent
Change-Id: Ib8022a3a1baf2e4b5d3d9d1453deb67f539baff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2290624
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Tested-by: Bob Haarman <inglorion@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tiancong Wang <tcwang@google.com>
|
|
Redirect all diagnoses of clang crashes to a dedicated directory using
fcrash-diagnostics-dir so we can upload these files to the cloud. The
flag was added to clangPostFlags to overwite redirection done on package
level.
BUG=chromium:1056904
TEST=None
Change-Id: I78bfc77d7f3af8556b4308f2e71407d627627747
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2251038
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Jian Cai <jiancai@google.com>
Tested-by: Jian Cai <jiancai@google.com>
|
|
This reverts commit 3b2358092e00ab7904a873b516ac6aac832c2277.
According to crrev.com/c/2171058, the fix in chromium could work.
Will wait till the patch submitted in chromium and CrOS uprevs to
merge the change into CrOS.
Reason for revert: The workaround is not needed anymore.
Original change's description:
> wrapper: Temporarily disable -Wmax-tokens
>
> As reported in crbug.com/1072209, -Wmax-tokens is causing latest
> chrome fail to build. While we are blocked by Chrome uprevs, we
> want to update the compiler by disabling the warning, until it's
> fixed properly on upstream Chrome.
>
> BUG=chromium:1072209
> TEST=Local testing in CrOS
>
> Change-Id: I082dd342a802e80250d0fca7c4b15afb4e972e7e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2161770
> Commit-Queue: Tiancong Wang <tcwang@google.com>
> Tested-by: Tiancong Wang <tcwang@google.com>
> Reviewed-by: George Burgess <gbiv@chromium.org>
Bug: chromium:1072209
Change-Id: I904fb3c4f7d125579667bef675be654a5465fad9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2173949
Tested-by: Tiancong Wang <tcwang@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Tiancong Wang <tcwang@google.com>
|
|
As reported in crbug.com/1072209, -Wmax-tokens is causing latest
chrome fail to build. While we are blocked by Chrome uprevs, we
want to update the compiler by disabling the warning, until it's
fixed properly on upstream Chrome.
BUG=chromium:1072209
TEST=Local testing in CrOS
Change-Id: I082dd342a802e80250d0fca7c4b15afb4e972e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2161770
Commit-Queue: Tiancong Wang <tcwang@google.com>
Tested-by: Tiancong Wang <tcwang@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
CCACHE_BASEDIR used to be set to sysroot so that ccache can reuse
compilation results across different boards. This is not useful
on builders and also less useful for board builds since we set
closer to target CFLAGS now.
It also breaks use of -fmacro-prefix-map option in clang/gcc.
So rip it out and simplify the rest of code.
BUG=chromium:983759
TEST=go test
Change-Id: Ia99ca994c976ee1137c3d904a78f7e25931c70f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2103170
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Clang ToT has switched to "-fno-common" as default to match GCC 10 which
breaks many packages. Upgrading to ToT versions of many packages does not
fix the problem as packages upstream have not fixed them yet.
Pass "-fcommon" in compiler wrapper to workaround this for now.
This does not change the current clang behavior which defaults to
"-fcommon" so this is a NFC.
BUG=chromium:1060413
TEST=packages build with ToT clang; NFC for current clang
Change-Id: I5a40e502db201615f45a7e4720105bebef2f2b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2102905
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
The flags that we use to generate clang tidy warnings have gotten
out of sync with the flags the Android team uses. This CL fixes
that.
BUG=None
TEST=None
Change-Id: I766af02fee111e2e2233612e8352de1fb0802c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2088431
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
|
|
Chrome OS code now is clean of following warnings:
"-Wreorder-init-list" and "-return-stack-address" so
stop disabling them.
BUG=chromium:1057384
TEST=warnings tested by CL:1898670
Change-Id: I568cf93a9e836ba936ea976312e9a78b5c473157
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2081707
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
This will gracefully handle cases where a warning enforced with -Werror
got stricter in upstream.
This change also needs updates to golden testdata. No additional tests
added since this is covered by existing tests.
Originally reviewed in https://android-review.googlesource.com/c/1244796.
BUG=b:149836702
TEST=go test
Change-Id: I94624deb258b15e131387377b99bfb1747dca1a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2079548
Tested-by: Pirama Arumuga Nainar <pirama@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
There are several places go scrtips launching and generating python
related code. This patch makes sure they are python 3 compatible.
BUG=chromium:1042452, chromium:1011676
TEST=Passed all python and go tests.
Change-Id: Ie531ceedb14ca2af94bd26f59ba4cab399ef1e6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2054081
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Zhizhou Yang <zhizhouy@google.com>
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Auto-Submit: Zhizhou Yang <zhizhouy@google.com>
|
|
Update paths used in test cases.
BUG=chromium:1042452
TEST=verified locally.
Change-Id: I0ddca454280f91508b632785ec9b417328e2ab3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2018235
Tested-by: Jian Cai <jiancai@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Exporting BISECT_STAGE to POPULATE_GOOD currently makes the wrapper fail
to build any files with the error message of "ModuleNotFoundError: No
module named 'bisect_driver'". This patch fixes the issue by adding
search path for bisect_driver.py explicitly.
BUG=chromium:1042452
TEST=verified locally.
Change-Id: I7c73459b377d9011c7087a9e241db378ffb216e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2003947
Tested-by: Jian Cai <jiancai@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
This adds the ability to add flags to the compiler command that
cannot be overridden by the user (e.g. when we MUST turn off a warning).
It adds '-Wno-implicit-int-float-conversion as such a flag for
llvm-next.
BUG=chromium:1018778
TEST='go test' passes
Change-Id: Ic57747be9719be83d3c5f7d7b4f4263f69f4de61
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1881725
Reviewed-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
|
|
os.UserHomeDir is not available in the Go version in Cros SDK.
Replace by explicit env value of "HOME".
BUG=None
TEST=go test
Change-Id: Ia0da2d9bce042510fcc1b14cb074dadfe4d0f2f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1856381
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
|
|
Add "poison-system-directories" warning in llvm-next builds.
Treat as an error.
BUG=None
TEST=not tested
Change-Id: Iaca80da6f38d27fe8e98a67c6701a7884d2ca5b2
Reviewed-on: https://chromium-review.googlesource.com/1839120
Tested-by: Denis Nikitin <denik@chromium.org>
Commit-Ready: Denis Nikitin <denik@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
|
|
BUG=chromium:773875
TEST=unit test
Change-Id: I94f99977f823e098aae39c79b9e01603fd84f5fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1832309
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Also removes the capability of defining the old
wrapper path now that we are getting close to
landing it.
BUG=chromium:773875
TEST=golden tests and comparison against old wrapper.
Change-Id: I543ddb1651edf2a269917f8afb5a667129bc3561
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1826986
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|