Age | Commit message (Collapse) | Author |
|
This CL add the Wno-unused-but-set-variable flag back into the compiler
wrapper. It was previously removed, but there are still occurances of
the warning and so we were never able to bundle that change into
chromoumos-overlay/llvm. An attempt to revert the original CL failed due
to a merge conflict.
BUG=b:227655984
TEST=None
Change-Id: Ic148a6ae577d5e4394249693ce9b09b95cb9df16
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3868978
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
|
|
With CL:3710850, pie will be defaults for clang and GCC
(cross-compiles). No need to manage them separately.
BUG=b:190047257
TEST=go test
Change-Id: Icf8e74d6a31c5de678ec9a6a5c321a17a0154d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3722436
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
|
|
Wimplicit-int has been promoted to be an default error
even with Wno-error. Disable the error by default since it is breaking
a lot of packages.
BUG=b:231987783
TEST=cq
Change-Id: If88877cb63cdd5c392fcf05c2940751547466213
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3642338
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
|
|
This CL sorts clang flags, and puts ones shared across all CrOS
configurations into their own textual blocks. This should make factoring
these out into their own function not require golden updates, which
makes verifying the CL that actually _does_ that simpler.
BUG=b:232114933
TEST=go test
Change-Id: I7dc6110d680505d4ad2af98709730e85c386ae5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639682
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
|
|
Since order doesn't matter, make this sorted. Otherwise, these are all
shared, so no point in repeating them.
BUG=b:232114933
TEST=go test
Change-Id: Ide3c620de9018fed3fe8d898b21b3d5d4f42700f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639281
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
|
|
Wimplicit-function-declaration has been promoted to be an default error
even with Wno-error. Disable the error by default since it is breaking
a lot of packages.
BUG=b:230345382
TEST=cq
Change-Id: Ib46b0b47a3e1dea3797739370a4d9cf92a4d25f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3637117
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
|
|
Use unwindlib=libunwind to match current production
wrapper.
BUG=None
TEST=go test
Change-Id: I6cdace48ed871ac87a093addf2b96b86ee5153c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3621381
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
|
|
This change has been in chromiumos-overlay for a while now, but it
apparently wasn't ever committed to toolchain-utils.
BUG=b:209649372
TEST=This has been in prod for ages.
Change-Id: Ied0b519f2f30ef275e921f41e6dbdee9c9442d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3321723
Tested-by: Christopher Di Bella <cjdb@google.com>
Auto-Submit: Christopher Di Bella <cjdb@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
|
|
This CL adds -Wno-unused-but-set-variable to clang post flags to prevent
these warnings from blocking the LLVM uprev.
BUG=b:195433889
TEST=cq
Change-Id: I5195412183e2684aecd20b6ff2c3345f8b8b9dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3235575
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org>
Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
|
|
Do not add static-libgcc to compiler command line if user
is passing {shared|static}-libgcc.
BUG=b:187794119
TEST=CQ
Change-Id: Iecd969dd11632837013bea71df9547bd08bbf30c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3064572
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Auto-Submit: Manoj Gupta <manojgupta@chromium.org>
|
|
Update compiler wrapper for migrating the wrappers from
gcc to llvm ebuild.
This assumes that clang wrappers now live in /usr/bin/
instead of /usr/x86-64-pc-linux-gnu/... and is no longer
co-located with gcc wrappers.
BUG=b:186803617
TEST=CQ, SDK tryjobs
Change-Id: I60082913dbf5a3c6ce992ea951955086b280af43
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3046721
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
BUG=b:191618957
TEST=wrapper test
Change-Id: I4340173ae681a6c5f022a3b1f1e890d2c9ee8b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3036676
Commit-Queue: Luis Lozano <llozano@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Auto-Submit: Luis Lozano <llozano@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
|
|
This is in preparation for our migration to libunwind.
BUG=b:187785190
TEST=Tested locally and on CQ
Disallow-Recycled-Builds: test-failures
Change-Id: I1b11d54de3d9550086ead05c3880f149e2e2f839
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2945100
Tested-by: Christopher Di Bella <cjdb@google.com>
Tested-by: Luis Lozano <llozano@chromium.org>
Auto-Submit: Christopher Di Bella <cjdb@google.com>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
|
|
ToT clang needs --prefix is needed to find the correct tools.
BUG=chromium:1182224
TEST=Updated compiler wrapper in SimpleChrome, nacl builds.
Change-Id: I8073e1a5482a23f38bb1e0d88e2b31ee2d97fa6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2721199
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Also update the golden tests appropriately.
BUG=chromium:924760
TEST=Already tested/committed in llvm/files/compiler-wrapper.
Change-Id: I0cac1f60874d7c473a3a79e37c0eddbe3e5dfed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2683254
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
|
|
pass "-fcommon" to GCC to match clang. This is needed
since GCC 10 defaults to "-fno-common".
BUG=chromium:1171833
TEST=go test
Change-Id: Iceac503c8cc14afc1837c6952100189f45d2b567
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2657043
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
The new Clang version has a number of new warnings which we disable. This CL
makes those apply to llvm (current) as well as llvm-next.
BUG=None
TEST=go test
Change-Id: I1f4929580953003d21676e7e72af4577592fb217
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2561725
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
|
|
LLVM implemented some flags that used to not be supported. Remove these
flags from unsupported flags in the wrapper.
BUG=chromium:1112929
TEST=tested locally.
Change-Id: If91df0d35ac3db926067d3e0c5e213f6c5e3f390
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2346956
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Jian Cai <jiancai@google.com>
|
|
Since we now have crashArtifactsDir as a more abstract concept, it seems
good to apply '-fcrash-diagnostics-dir=' based on that, rather than
having it as an explicit clang flag.
BUG=chromium:1113442
TEST=FIXME
Change-Id: I147779d7cf8806b3bc712c2998446158e87ec967
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2343975
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
|
|
LLVM is currently build with DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=ON on
Chrome OS. This is however not reflected in clang crash diagnoses.
Adding -fexperimental-new-pass-manager to help with reproducibility on
4c.
BUG=chromium:1111103
TEST=CQ tests.
Change-Id: Ie01431dff397e982469e29c9132e21374354762d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2327414
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Jian Cai <jiancai@google.com>
|
|
-grecord-gcc-switches causes the compiler and compiler flags to be
stored in the produced debug information. This causes Goma builds to
be non-deterministic, because the compiler path differs depending
on whether the compiler was run locally or on Goma. This, in turn,
causes cache pollution and needless work. Since we are not in
fact using the information stored by -grecord-gcc-switches, this
change disables it. We can re-enable it when we want to start
using the information, provided we come up with another way to
avoid the issues described earlier.
BUG=chromium:1103065
TEST=Build an object file in chromeos-chrome and check that info is absent
Change-Id: Ib8022a3a1baf2e4b5d3d9d1453deb67f539baff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2290624
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Tested-by: Bob Haarman <inglorion@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tiancong Wang <tcwang@google.com>
|
|
Redirect all diagnoses of clang crashes to a dedicated directory using
fcrash-diagnostics-dir so we can upload these files to the cloud. The
flag was added to clangPostFlags to overwite redirection done on package
level.
BUG=chromium:1056904
TEST=None
Change-Id: I78bfc77d7f3af8556b4308f2e71407d627627747
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2251038
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Jian Cai <jiancai@google.com>
Tested-by: Jian Cai <jiancai@google.com>
|
|
This reverts commit 3b2358092e00ab7904a873b516ac6aac832c2277.
According to crrev.com/c/2171058, the fix in chromium could work.
Will wait till the patch submitted in chromium and CrOS uprevs to
merge the change into CrOS.
Reason for revert: The workaround is not needed anymore.
Original change's description:
> wrapper: Temporarily disable -Wmax-tokens
>
> As reported in crbug.com/1072209, -Wmax-tokens is causing latest
> chrome fail to build. While we are blocked by Chrome uprevs, we
> want to update the compiler by disabling the warning, until it's
> fixed properly on upstream Chrome.
>
> BUG=chromium:1072209
> TEST=Local testing in CrOS
>
> Change-Id: I082dd342a802e80250d0fca7c4b15afb4e972e7e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2161770
> Commit-Queue: Tiancong Wang <tcwang@google.com>
> Tested-by: Tiancong Wang <tcwang@google.com>
> Reviewed-by: George Burgess <gbiv@chromium.org>
Bug: chromium:1072209
Change-Id: I904fb3c4f7d125579667bef675be654a5465fad9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2173949
Tested-by: Tiancong Wang <tcwang@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Tiancong Wang <tcwang@google.com>
|
|
As reported in crbug.com/1072209, -Wmax-tokens is causing latest
chrome fail to build. While we are blocked by Chrome uprevs, we
want to update the compiler by disabling the warning, until it's
fixed properly on upstream Chrome.
BUG=chromium:1072209
TEST=Local testing in CrOS
Change-Id: I082dd342a802e80250d0fca7c4b15afb4e972e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2161770
Commit-Queue: Tiancong Wang <tcwang@google.com>
Tested-by: Tiancong Wang <tcwang@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Clang ToT has switched to "-fno-common" as default to match GCC 10 which
breaks many packages. Upgrading to ToT versions of many packages does not
fix the problem as packages upstream have not fixed them yet.
Pass "-fcommon" in compiler wrapper to workaround this for now.
This does not change the current clang behavior which defaults to
"-fcommon" so this is a NFC.
BUG=chromium:1060413
TEST=packages build with ToT clang; NFC for current clang
Change-Id: I5a40e502db201615f45a7e4720105bebef2f2b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2102905
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
|
|
Chrome OS code now is clean of following warnings:
"-Wreorder-init-list" and "-return-stack-address" so
stop disabling them.
BUG=chromium:1057384
TEST=warnings tested by CL:1898670
Change-Id: I568cf93a9e836ba936ea976312e9a78b5c473157
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2081707
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
BUG=chromium:1001317
TEST=In progress
Change-Id: I78481d2ca3f555d670e7e5972e547f94d2be22a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1888745
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
|
|
Match the changes to python wrapper in CL:1686078.
Also add small fix for echo path, it should be /bin/echo
instead of /usr/bin/echo.
BUG=chromium:979909
TEST=go test
Change-Id: I5e626febd5abab4f9824aba1e158f264bf75be9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1803778
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
|
|
BUG=chromium:773875
TEST=unit test
Change-Id: I442afcfac00bcdbdfa33b739087af12987c57584
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1772176
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
These change were accidentally added in crrev/c/1757222.
The local presubmit didn't catch them as I had crrev/c/1754085
ontop in the branch.
BUG=chromium:773875
TEST=unit test
Change-Id: If8703ea3ff412135a36d76027b3393da044bf504
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1757087
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Tobias Bosch <tbosch@google.com>
|
|
BUG=chromium:773875
TEST=unit test
Change-Id: I150eb18a5d765d43ee7a2341767ff41f6641c6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1757222
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Especially for:
- calling the wrapper with absolute path
- calling the wrapper in a deep directory
- calling a symlinked wrapper
BUG=chromium:773875
TEST=unit test
Change-Id: Ib01562d6c40d8d2ae0c439081fc04625663dcd07
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1752524
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Previously, a golden file contained multiple names sections.
This change splits these into separate files, making
changes easier to compare.
BUG=chromium:773875
TEST=unit test
Change-Id: Icffec335601297f504f98c4ff1654238f7838080
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1752523
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|