Age | Commit message (Collapse) | Author |
|
This will gracefully handle cases where a warning enforced with -Werror
got stricter in upstream.
This change also needs updates to golden testdata. No additional tests
added since this is covered by existing tests.
Originally reviewed in https://android-review.googlesource.com/c/1244796.
BUG=b:149836702
TEST=go test
Change-Id: I94624deb258b15e131387377b99bfb1747dca1a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2079548
Tested-by: Pirama Arumuga Nainar <pirama@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
There are several places go scrtips launching and generating python
related code. This patch makes sure they are python 3 compatible.
BUG=chromium:1042452, chromium:1011676
TEST=Passed all python and go tests.
Change-Id: Ie531ceedb14ca2af94bd26f59ba4cab399ef1e6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2054081
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Zhizhou Yang <zhizhouy@google.com>
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Auto-Submit: Zhizhou Yang <zhizhouy@google.com>
|
|
Update paths used in test cases.
BUG=chromium:1042452
TEST=verified locally.
Change-Id: I0ddca454280f91508b632785ec9b417328e2ab3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2018235
Tested-by: Jian Cai <jiancai@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Exporting BISECT_STAGE to POPULATE_GOOD currently makes the wrapper fail
to build any files with the error message of "ModuleNotFoundError: No
module named 'bisect_driver'". This patch fixes the issue by adding
search path for bisect_driver.py explicitly.
BUG=chromium:1042452
TEST=verified locally.
Change-Id: I7c73459b377d9011c7087a9e241db378ffb216e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2003947
Tested-by: Jian Cai <jiancai@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
BUG=chromium:1001317
TEST=In progress
Change-Id: I78481d2ca3f555d670e7e5972e547f94d2be22a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1888745
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
|
|
This adds the ability to add flags to the compiler command that
cannot be overridden by the user (e.g. when we MUST turn off a warning).
It adds '-Wno-implicit-int-float-conversion as such a flag for
llvm-next.
BUG=chromium:1018778
TEST='go test' passes
Change-Id: Ic57747be9719be83d3c5f7d7b4f4263f69f4de61
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1881725
Reviewed-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
|
|
Also consolidates most of the android specific logic
into one place so it's clear which flags are used
and which ones are not.
Also detects wrapping of clang-tidy for future
special casing.
BUG=chromium:773875
TEST=unit tests, golden tests
TEST=android's test_compiler.py --with-tidy
Change-Id: Ic83340ba63ec3ea4c3c174069d3dc017ecbcdd72
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1866603
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Useing sanitizers and coverage together in new pass manager
causes clang to crash.
Avoid the crash by disabling new pass manager in these cases.
BUG=chromium:1013622
TEST=go test
Change-Id: Ifc787e9f288891e3e1b68c791f0ddaa508d8c816
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1856379
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
os.UserHomeDir is not available in the Go version in Cros SDK.
Replace by explicit env value of "HOME".
BUG=None
TEST=go test
Change-Id: Ia0da2d9bce042510fcc1b14cb074dadfe4d0f2f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1856381
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
|
|
Android uses the wrapper also for clang-tidy.
TEST=golden tests
BUG=chromium:773875
Change-Id: I17534b44b1bc7e6b60002f2660966f27d70301ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1854899
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Tobias Bosch <tbosch@google.com>
|
|
Add "poison-system-directories" warning in llvm-next builds.
Treat as an error.
BUG=None
TEST=not tested
Change-Id: Iaca80da6f38d27fe8e98a67c6701a7884d2ca5b2
Reviewed-on: https://chromium-review.googlesource.com/1839120
Tested-by: Denis Nikitin <denik@chromium.org>
Commit-Ready: Denis Nikitin <denik@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
|
|
The old android wrapper supports to use a fallback
compiler in case of errors. This replicates this
logic.
See
https://cs.corp.google.com/android/toolchain/llvm_android/compiler_wrapper.py.
BUG=chromium:773875
TEST=unit test, golden tests comparing to old wrapper
Change-Id: Iff7281e6e21c4834f9a4493884ed7b3d66b87967
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1833898
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
BUG=chromium:773875
TEST=unit test
Change-Id: I94f99977f823e098aae39c79b9e01603fd84f5fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1832309
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
This is used by Android. To keep the wrappers in sync,
we also support it on ChromeOS.
BUG=chromium:773875
TEST=golden tests and comparison against old andorid wrapper.
Change-Id: I02d7456ead1c94327eb6810aeef4d106596518ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1831789
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Tobias Bosch <tbosch@google.com>
|
|
BUG=chromium:773875
TEST=golden tests and comparison against old andorid wrapper.
Change-Id: Ic11be4bc1399adcbf9c50134928aceda45e936ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1831787
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Also removes the capability of defining the old
wrapper path now that we are getting close to
landing it.
BUG=chromium:773875
TEST=golden tests and comparison against old wrapper.
Change-Id: I543ddb1651edf2a269917f8afb5a667129bc3561
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1826986
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Match the changes to python wrapper in CL:1686078.
Also add small fix for echo path, it should be /bin/echo
instead of /usr/bin/echo.
BUG=chromium:979909
TEST=go test
Change-Id: I5e626febd5abab4f9824aba1e158f264bf75be9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1803778
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Tobias Bosch <tbosch@google.com>
|
|
BUG=chromium:773875
TEST=unit test
Change-Id: I442afcfac00bcdbdfa33b739087af12987c57584
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1772176
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
BUG=chromium:773875
TEST=golden tests, emerge-lakitu sys-kernel/linux-headers
Change-Id: I205059a9f61484caaf69ed340fd42a47531e00f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1762344
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
BUG=chromium:773875
TEST=golden tests and compare to old wrapper
Change-Id: Iac9f45390cbe6076d3e3851da85de7d27fe11ed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1762376
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Tested-by: Tobias Bosch <tbosch@google.com>
|
|
BUG=chromium:773875
TEST=unit tests, compile cross-armv7m-cros-eabi/newlib
Change-Id: Ia98442a69b01cff87c52b6ac84dc39c47d5e998e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1760465
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
These change were accidentally added in crrev/c/1757222.
The local presubmit didn't catch them as I had crrev/c/1754085
ontop in the branch.
BUG=chromium:773875
TEST=unit test
Change-Id: If8703ea3ff412135a36d76027b3393da044bf504
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1757087
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Tobias Bosch <tbosch@google.com>
|
|
BUG=chromium:773875
TEST=unit test
Change-Id: I150eb18a5d765d43ee7a2341767ff41f6641c6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1757222
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Especially for:
- calling the wrapper with absolute path
- calling the wrapper in a deep directory
- calling a symlinked wrapper
BUG=chromium:773875
TEST=unit test
Change-Id: Ib01562d6c40d8d2ae0c439081fc04625663dcd07
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1752524
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Previously, a golden file contained multiple names sections.
This change splits these into separate files, making
changes easier to compare.
BUG=chromium:773875
TEST=unit test
Change-Id: Icffec335601297f504f98c4ff1654238f7838080
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1752523
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
This change adds support for the gcc host wrapper.
The implementation is verified via comparing to the old
gcc host wrapper in the golden tests.
BUG=chromium:773875
TEST=unit test
Change-Id: I3af98b81dba6d9299183db01e967003be860972c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1710537
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
This change adds support for the clang host wrapper.
The implementation is verified via comparing to the old
clang host wrapper in the golden tests.
BUG=chromium:773875
TEST=unit test
Change-Id: I48284736014ab4b66bfd7e31e88ffd23956007bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1708750
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
Old wrapper changes:
https://chromium.git.corp.google.com/chromiumos/overlays/chromiumos-overlay/+/bebf19ee4322c26d7cb548c8f4419dfe1c6e3c11
https://chromium.git.corp.google.com/chromiumos/overlays/chromiumos-overlay/+/cc6e225d3894f99b320584b2f41ff6a68f76d6a7
BUG=chromium:773875
TEST=unit test
Change-Id: I927bcb6082d1b67ca9efde0001e43e0a0a36c3b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1710403
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
- Golden files can be updated via the new "-updategolden" test flag.
- Golden files contain the wrapper command, commands executed by the wrapper
stdout, stderr, exitcode of the wrapper
- The commands in the golden files are also compared to the old wrapper
to make sure they are correct. We are also mocking less things in
the old wrapper now, allowing to compare against differnet wrappers via
golden tests in the future (e.g. clang_host_wrapper).
- Unit tests are no longer diffing against the old wrapper.
BUG=chromium:773875
TEST=unit test
Change-Id: I0755bfe11cd499474820c9354412d39a0fa04401
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1702633
Tested-by: Tobias Bosch <tbosch@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
|