aboutsummaryrefslogtreecommitdiff
path: root/cros_utils
AgeCommit message (Collapse)Author
2019-10-16toolchain-utils: fix a unittest failure in cros_utilsZhizhou Yang
no_pseudo_terminal_test always failed when running tests in toolchain-utils. This is caused by that strace cannot run without sudo permision. This patch fixes it. TEST=Passed unittest. BUG=None Change-Id: Ife8f13dc04cd515eff207ea73716e04cbdc7b8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1863626 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com>
2019-10-15toolchain-utils: change naming related to AFE lockZhizhou Yang
After introducing the new locking mechanism, the behavior of AFELockManager totally changed. This file changed the naming of all related code in toochain-utils. This patch also changed the behavior of locks_dir option, deprecated the use_file_lock option explicitly. TEST=Tested with different DUT types. BUG=chromium:1006434 Change-Id: Ib15efce54ec4d4c5c2a18fecca3f350248462035 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1863530 Reviewed-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Denis Nikitin <denik@chromium.org> Commit-Queue: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com>
2019-09-27toolchain-utils: remove AFE local server codeZhizhou Yang
We used to have local server for AFE locking mechanism to lock non-lab machines. But this local server was not supported since long time ago. This patch removes all local server related code from AFE locking. Note that there will be another CLs to deal with issues in http://crbug.com/1006434#c1 TEST=Passed crosperf local tests with different type of machines. BUG=chromium:1006434 Change-Id: I47dbca73edd3e493496fd13ba0b3de705dc11513 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1822029 Reviewed-by: Caroline Tice <cmtice@chromium.org> Commit-Queue: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com>
2019-08-16cros_utils: add an ExitStack utilityGeorge Burgess IV
Python3 has a really handy tool called ExitStack. It's meant to make context managers a bit more dynamic in what they can do. Sadly, Python2 doesn't have this. This CL adds a simple implementation of ExitStack to our utilities. We want this feature now, and the hope is that when we move to Python3, we'll be able to just mass-replace contextlib3 with contextlib, and everything will Just Work. BUG=None TEST=Unittest Change-Id: I1e20271da598c86c00531821e1053bc33ecc2f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1757218 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2019-08-14cros_utils: Fix blacklisted R79-12384.0.0 imageDenis Nikitin
Replaced comparison of the image revision with list comparison. Added unittest for GetLatestImage. BUG=chromium:992242 TEST=unittest passes Change-Id: I085a2a31ff89f02f71c093e7ac3726250b909229 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1754442 Commit-Queue: Denis Nikitin <denik@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Denis Nikitin <denik@chromium.org>
2019-08-11cros_utils: Add R79-12384.0.0 image to blacklistDenis Nikitin
R79-12384.0.0 image was made by mistake and way ahead of current master revision numbering. This makes the image always the latest one until R79 branch is released. The change blacklists "R79-12384.0.0" image when searching for the latest one in chromeos-image-archive. BUG=chromium:992242 TEST=not tested Change-Id: I45be6441f54d642dd2636b5231114e95faf491a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1745544 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
2019-08-02command_executer: Pass custom env in ChrootRunCommand.Manoj Gupta
Previous CL:1733646 missed the case of ChrootRunCommand. Add the custom env to it as well. BUG=None TEST=unit tests. Change-Id: I3e09d89cb40550d52de3d880c6b6b4d6f0e71d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1733649 Reviewed-by: Zhizhou Yang <zhizhouy@google.com> Tested-by: Manoj Gupta <manojgupta@chromium.org>
2019-08-02command_executer: Allow passing custom os env.Manoj Gupta
It is currently tedious to pass custom env variables to command executer e.g. when there is a need to pass an env variable for use inside chroot command. Allow passing an env variable directly to command_executer. Includes formatting changes done by running yapf. BUG=None TEST=unit tests Change-Id: I1bd286b89f3938c1c2e8384c2b9f3bdea05f3dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1733646 Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org>
2019-07-25toolchain-utils: remove all xrangesGeorge Burgess IV
This removes all mention of xrange from toolchain-utils (modulo ones being changed in other CLs that are in flight). It's now an apparent lint error to use xrange, and it hinders our move to python3. As commented on If90d26664c70ccb73750f17573b89933fdb048f4, xrange -> range in python2 is really only a space concern (or speed in pathological cases), so migrations of this nature are generally super straightforward. I glanced at each of these callsites, and none of them appear to be pathological, so my hope is that this should all be Just Fine :) (Also fun to note that this includes a .diff file that has python code embedded in it.) BUG=None TEST=Presubmit tests Change-Id: Ic9f3ac3a5044d7a07da8a249bc505278d98203de Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1717130 Commit-Queue: George Burgess <gbiv@chromium.org> Commit-Queue: Luis Lozano <llozano@chromium.org> Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> Reviewed-by: George Burgess <gbiv@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
2019-07-09toolchain-utils: migrate Telemetry tests results from chartjson to histogramsJian Cai
Shift to histograms as charjson format is being deprected for Telemtry tests BUG=chromium:967868 TEST=Local tests. Change-Id: I0645c6f10a93a454cc50090d2b790c9f386d9358 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1691318 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Jian Cai <jiancai@google.com>
2019-03-20setup_board: Update usagesAlex Klein
BUG=chromium:893748 TEST=precq CQ-DEPEND=CL:1409763 Change-Id: I661c527c4a53864595d02f3302dbc9047692a042 Reviewed-on: https://chromium-review.googlesource.com/1407709 Commit-Ready: Alex Klein <saklein@chromium.org> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org>
2019-03-15crosperf: Feature to ignore min and max value in resultsZhizhou Yang
This patch provides an option for user to ignore min and max value in the results when generating report. User can use this feature by specifying `ignore_min_max: True` (which by default is False) in experiment file. When values count in a single test is smaller than 3, we automatically ignore this option for it, and print out a warning. BUG=chromium:938758 TEST=Tested with examples in general/cwp mode report generation. Passed all unit tests. Change-Id: I36a4c4d99836c201cdd2f2f9f2a4b1a4ffdaa47d Reviewed-on: https://chromium-review.googlesource.com/1521054 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Zhizhou Yang <zhizhouy@google.com>
2019-03-06crosperf: replace cpu cycles in report with samplesZhizhou Yang
What we collected from benchmark run actually are samples from perf tool, so "cpu cycles" is not a accurate name. BUG=chromium:936573 TEST=Tested with cwp and general mode on eve; Passed all unittests. Change-Id: I35533cea0987c4e1b112498cc1b0271eaab665ae Reviewed-on: https://chromium-review.googlesource.com/1495963 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2019-02-26toolchain-utils: Launch tryjobs from chroot.Manoj Gupta
This is to workaround a bug in launching tryjobs from outside chroot. BUG=None TEST=can launch tryjobs Change-Id: Ie0d48e9f8f487ef9a9eeebd627948492f65fed31 Reviewed-on: https://chromium-review.googlesource.com/c/1490571 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org>
2019-01-26[toolchain-utils] Increase timeout for tryjobs.Manoj Gupta
Toolchain trybob images are taking longer to build and causing performance jobsto hit a timout limit. This CL increases the timeout limit to 12 hours. BUG=chromium:925534 TEST=None Change-Id: Icbb8c56d70f135a574a7176b2f3b5dd5c4504710 Reviewed-on: https://chromium-review.googlesource.com/c/1436497 Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2019-01-22crosperf: fix bug in perf table generatingZhizhou Yang
This patch fixes a bug in perf table generating, by removing an unused argument from AddLabelName(). TEST=passed local unit tests and a sample test on device. BUG=chromium:923143 Change-Id: I16fb0d1baaa76be523073de1e9768c1b1ee799d6 Reviewed-on: https://chromium-review.googlesource.com/1419298 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2018-12-29crosperf: unit test for CPU cycles table generatorZhizhou Yang
This patch added unit test for CPU table generation in tabulator.py TEST=passed all unit tests in cros_utils and crosperf BUG=chromium:917484 CQ-DEPEND=CL:1389035 Change-Id: Ib10bea1470fca1c5dbab8ad39b9684dd473a6183 Reviewed-on: https://chromium-review.googlesource.com/1392428 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2018-12-29crosperf: Fix bugs and nit in report generationZhizhou Yang
Fixed two parts in source code to make unit test pass: 1) Without unit, cpu cycles still should multiply by weight 2) Do not try to access cwp_dso from experiment in BenchmarkResult object, because there is method to generate report without running experiment. One nit to change the name of TableGenerator used for CPU cycle report. TEST=passed all unit tests in crosperf BUG=chromium:902785 CQ-DEPEND=CL:1376571 Change-Id: I8308b0287d60e77542ac60f5ecd5734907e51e01 Reviewed-on: https://chromium-review.googlesource.com/1389035 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2018-12-28crosperf: Generate report for cwp approximationZhizhou Yang
TODO: unit tests needed. This patch trys to generate a new type of report when cwp_dso is specified. The report will: 1) Generate a new summary table at benchmark level with weighted cpu cycle data. 2) Do not generate perf table. 3) Generate a full table with only cpu cycles in it. TEST=generated correct report with a normal run and two cwp_dso runs: one succeeded run and one with failures. BUG=chromium:902785 Change-Id: I0c62000c6690c66d50a7a4de3cfc280853b134e2 Reviewed-on: https://chromium-review.googlesource.com/1376571 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2018-12-12Revert "[toolchain-utils] Add tryjob flags to build Chrome from 9999 ebuild."Manoj Gupta
This reverts commit 115acfa5fc88d4aa4eb9158e41be534439952a33. Reason for revert: No need to test chrome 9999 ebuild anymore. Original change's description: > [toolchain-utils] Add tryjob flags to build Chrome from 9999 ebuild. > > This CL updates the nightly tryjobs to build Chrome using the > 9999 ebuild, to work with the CL that updates Chrome to not use > ThinLTO caching, so we can test LLD with our nightly builders. > > BUG=None > TEST=Tested a tryjob with those flags and that CL, and it worked. > > Change-Id: I3b1e77de6d1ead54f1696dc49987a37dd8db50ad > Reviewed-on: https://chromium-review.googlesource.com/1345889 > Commit-Ready: Caroline Tice <cmtice@chromium.org> > Tested-by: Caroline Tice <cmtice@chromium.org> > Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Bug: chromium:701659 Change-Id: I1138ed7ed0dd23103f6202140f4eb5385ae567b4 Reviewed-on: https://chromium-review.googlesource.com/1372264 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2018-12-08toolchain-utils: Handle the missing artifact_url error more gracefully.Manoj Gupta
Mark status as fail if artifact_url field is null. This will make the builder errors easier to spot. BUG=chromium:912617 TEST=Tested a dummy job. Change-Id: I5896ce00a7b9f9a9b27329e1f509560b8e27d56f Reviewed-on: https://chromium-review.googlesource.com/1366375 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2018-11-24[toolchain-utils] Increase timeout for buildbot tryjobs.Caroline Tice
Recent infrastructure changes have added some stages to our trybot jobs making them take longer, and causing them to hit our timeout limit. This CL increases the timeout limit. BUG=chromium:908188 TEST=None Change-Id: I19bab9d5ee8d0d4074575a1a719fa23fe5de6704 Reviewed-on: https://chromium-review.googlesource.com/1349479 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2018-11-22[toolchain-utils] Add tryjob flags to build Chrome from 9999 ebuild.Caroline Tice
This CL updates the nightly tryjobs to build Chrome using the 9999 ebuild, to work with the CL that updates Chrome to not use ThinLTO caching, so we can test LLD with our nightly builders. BUG=None TEST=Tested a tryjob with those flags and that CL, and it worked. Change-Id: I3b1e77de6d1ead54f1696dc49987a37dd8db50ad Reviewed-on: https://chromium-review.googlesource.com/1345889 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2018-09-27Fix 'from' field for sendgmr emails.Caroline Tice
The from field will now be the user who runs the tool, rather than the file name (required due to changing rules for sendgmr). BUG=chromium:889540 TEST=Successfully ran crosperf and received email. Change-Id: I273b9e229a80f5cc61447a0e844abda71c3d0f99 Reviewed-on: https://chromium-review.googlesource.com/1246477 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2018-08-08Increase timeout for slower builders.Luis A. Lozano
Some of our slower builder (with latest_toolchain) are taking around 8 hours. This CL increases the timeout for such situations. BUG=chromium:870916 TESTS=None Change-Id: I8c15e4ecbd71f76bca65c6adcabd74df8da79660 Reviewed-on: https://chromium-review.googlesource.com/1167965 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2018-08-07import toolchain_utils.shMike Frysinger
This is the only repo that uses these funcs anymore, so move them here so we can delete the source file entirely. BUG=None TEST=precq passes Change-Id: Ie3cfa2168783999f3a02df20957755ae4c6c46af Reviewed-on: https://chromium-review.googlesource.com/1163163 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2018-04-18[toolchain-utils] Remove one last description reference.Caroline Tice
Previous CL, removing '--remote-description' flag, missed two uses which this CL deletes. BUG=chromium:833542 TEST=In progress. Change-Id: I37d06e12af815e063d2cd0bac71737356cdd15a5 Reviewed-on: https://chromium-review.googlesource.com/1017909 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2018-04-16[toolchain-utils] Remove --remote-description flag.Caroline Tice
The cros tryjob command no longer recognizes this flag so we need to remove it from our scripts. BUG=chromium:833542 TEST=Tested with launching the rotating builders on chrotomation2. Change-Id: Ifcf62ae7073d84a9f58e12c29dcce5cdf9108e9f Reviewed-on: https://chromium-review.googlesource.com/1014369 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2018-04-16[toolchain-utils] Add info to rotating builder logs.Caroline Tice
Due to recent changes in the tryjob launching system, the current rotating builder logs are empty. This CL causes the command and resulting buildbucket_id to be printed, and therefore go into the logs, so the sheriffs have some way of finding out what boards were built and what the buildbucket ids were for the builds. Also fix some format errors (forced by commit hook). BUG=chromium:833195 TEST=Tested for the last two nights on chrotomation2. Change-Id: Ic8e18baf1bc3f39af574d673962e43e830356210 Reviewed-on: https://chromium-review.googlesource.com/1013227 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2018-04-11buildbot_utils: fix a typo.Yunlian Jiang
BUG=None TEST=None. Change-Id: Ib0ba6a3cf9bee432b93dc2b96f96e2c4c8a8944d Reviewed-on: https://chromium-review.googlesource.com/1007488 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2018-04-10buildbot_utils: change method to get buildbucketidYunlian Jiang
The infrastructure team changed the output of cros tryjob, we need to change accordingly to get the buildbucketid from the output. BUG=none TEST=ParseTryjobBuildbucketId can get the buildbucketid from the new output. Change-Id: I389355cb4fae72b21859167e9e191cbcebfc64ae Reviewed-on: https://chromium-review.googlesource.com/1006187 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2018-03-13cros_utils/buildbot_utils: GetTrybotImage should return a partial URLTing-Yuan Huang
It should return a partial URL which is appended to xbuddy://remote/ in crosperf's exp file. BUG=chromium:807029 TEST=cros_utils/buildbot_utils_unittest.py buildbot_test_toolchains.py Change-Id: I1297b4ce586173d8ad97f6c30f989f826050e72b Reviewed-on: https://chromium-review.googlesource.com/959361 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2018-03-09cros_utils/buildbot_utils: leverage `cros buildresult`Ting-Yuan Huang
Originally it sends a http request to some magic URL and parse the contents. Now there is a `cros buildresult` available for use. BUG=chromium:807029 TEST=cros_utils/buildbot_utils_unittest.py buildbot_test_toolchains.py Change-Id: I33441859afd675c1a6b70d3d1f4e2348d54cbd77 Reviewed-on: https://chromium-review.googlesource.com/954052 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-11-27Add '-tryjob' suffix to build name.Yunlian Jiang
We got some errors like These configs are not tryjob safe: link-llvm-next-toolchain Consider these configs instead: link-llvm-next-toolchain-tryjob when lauching tryjobs to get the image. This CL fixes that. BUG=none TEST=The build name is changed. Change-Id: I56ef66dfb1071367b78ee8a7335552cdae5a5b44 Reviewed-on: https://chromium-review.googlesource.com/791391 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-11-21Add '-tryjob' suffix to build name.Yunlian Jiang
We got some errors like These configs are not tryjob safe: lumpy-release Consider these configs instead: lumpy-release-tryjob when lauching tryjobs to get the image. This CL fixes that. BUG=none TEST=the build name is set to lumpy-release-tryjob. Change-Id: I30086001e3937c956983f7c31b038b4a09b3ecec Reviewed-on: https://chromium-review.googlesource.com/781441 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-11-07[toolchain-utils] Fix security issue.Caroline Tice
Remove the chromeos-toolchain-credentials.json file, which should not be in a publicly visible repo. Update the buildbot_test_* scripts to take an argument for the directory containing the credentials file. Update the buildbot_utils.py file to use the credentials file argument, and to default to the location in our role account. BUG=782452 TEST=With some code commented out, did basic testing of flag/options to make sure they work as expected. Change-Id: I47a98a69b9ba8d2704d25abc37fe4447fa6ba343 Reviewed-on: https://chromium-review.googlesource.com/757901 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-08-18Move cbuildbot flags to tryjob flagsTing-Yuan Huang
They are now available and needn't to be pass through. BUG=chromium:756100 TEST=buildbot_test_toolchains.py Change-Id: Icece6e74faa8966067346a3a5fc111c9fdb5e431 Reviewed-on: https://chromium-review.googlesource.com/622309 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org>
2017-08-16Switching from cbuildbot to cros tryjobTing-Yuan Huang
BUG=chromium:756100 TEST=buildbot_test_toolchains.py, buildbot_test_llvm.py Change-Id: Ie275b960afdb2ed7183a763302af70c3f2bc1092 Reviewed-on: https://chromium-review.googlesource.com/617404 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-05-31Verify manifest is in paladin before trying to use it.Caroline Tice
With increasing frequency the lumpy nightly test fails very early because it ends up trying to get a manifest that only exists in Android, not in ChromeOS. This CL adds code to verify the manifest version actually exists in the paladins list before trying to use it. BUG=chromium:726778 TEST=Tested this code in the nightly build tests and it worked. Change-Id: I86f8eb9c8e28fd4a404bc63d49d8d9fb27de8b3b Reviewed-on: https://chromium-review.googlesource.com/517266 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-04-25buildbot_test_toolchains: get latest instead green vanilla buildTing-Yuan Huang
So as to work around the problem that some builders' latest green builds are too old. BUG=chromium:714890 TEST=Tested _GetVanillaImageName locally. Change-Id: I06571f3d55743fb56977d7ef56a51fcddfdda62e Reviewed-on: https://chromium-review.googlesource.com/486086 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>
2017-04-14[toolchain-utils] Remove --do-not-use-buildbucket flagCaroline Tice
This implements the correct way to find the remote description so that we do not need to disable the buildbucket authentication. BUG=chromium:711430 TEST=Launched nightly buildbot job and it was able to find correct build log. Change-Id: I0a2e16ec284bae46af684daf3abcbbea1b9c3fe9 Reviewed-on: https://chromium-review.googlesource.com/478010 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-04-13[toolchain-utils] Workaround for new bug in cbuildbot.Caroline Tice
There's a regression/bug in the cbuildbot stuff that is causing all of our cbuildbot jobs to be unable to find their build records, which causes them to fail. Adding the flag '--do-not-use-buildbucket' is a workaround that temporarily fixes this problem. This CL adds that flag to all of our cbuildbot jobs. BUG=chromium:711430 TEST=Launched cbuildbots with & without this flag; saw the problem without the flag; with the flag the problme was gone. Change-Id: I75219dad55e762ce2d5f0e3b6d885a8e91be014e Reviewed-on: https://chromium-review.googlesource.com/477391 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
2017-04-08[toolchain-utils] Fix remaining lint errors in toolchain-utils.Caroline Tice
In addition to fixing the lint errors, this also fixes the Python formatting issues (ran tc_pyformat on nearly all the files). BUG=chromium:570450 TEST=Ran all crosperf & bisect tool unit tests. Ran afe_lock_machine.py (check machine status) Ran full crosperf test (octane, speedometer, BootPerf) on alex. Change-Id: Ic86f9192801ac67769f3de30f1c5f0d203ce0831 Reviewed-on: https://chromium-review.googlesource.com/471886 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-03-16Use bash as the default shell for command execution in crosperf.Manoj Gupta
subprocess.Popen defaults to /bin/sh, however, the intended behavior is running them with bash. BUG=None TEST=Synatx error in . remote_access.sh is gone. Crosperf unit tests passed. Change-Id: I059ba9736e5ad3023b5c0a2201f6b40d11ddbe6e Reviewed-on: https://chromium-review.googlesource.com/452862 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org>
2017-03-10Reformat cros_utils/command_executer.py using latest tc_pyformat.Manoj Gupta
This is to avoid reviewing unnecessary white space changes later on. BUG=None TEST=Crosperf Unit Tests Passed Change-Id: I0beea920e7c2a385220de26022403333a374ef67 Reviewed-on: https://chromium-review.googlesource.com/453104 Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
2017-01-04Add llvm_next_builder to list of known builders.Caroline Tice
This will fix the problem with rotating builders; they were updated to use the llvm_next builder, but this script was not updated to use llvm_next. BUG=chromium:674804 TEST=Tested in role account on chrotomation2, launching rotating builder. Change-Id: Ifd4ba57cf403feae0b0b84c8b21accb34987ecbc Reviewed-on: https://chromium-review.googlesource.com/424893 Reviewed-by: Yunlian Jiang <yunlian@chromium.org> Commit-Queue: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org>
2017-01-03buildbot_utils.py: do not get build_id for async build.Yunlian Jiang
The build_id is not useful for async builds, so there is no need to try to get it. BUG=chromium:674804 TEST=None Change-Id: If5781955834ca35958b1efead2dd9628e7a905de Reviewed-on: https://chromium-review.googlesource.com/424794 Reviewed-by: Ting-Yuan Huang <laszio@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org>
2016-12-15buildbot_test_toolchains: Use LATEST-master as control groupTing-Yuan Huang
Rather than finding the official image with exact the same version as the trybot image, let's just use the latest one since trybot always get lastest or latest + 1. This also solves the problem that the official image specified may not exist. BUG=chromium:674652 TEST=Tested ToolchainComparator._GetVanillaImageName locally. Change-Id: I44fbceb99d8f6cf3187366c075c2a9522869b5a5 Reviewed-on: https://chrome-internal-review.googlesource.com/312516 Commit-Ready: Ting-Yuan Huang <laszio@google.com> Tested-by: Ting-Yuan Huang <laszio@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-12-12toolchain-utils: add build link to daily trybot logs.Yunlian Jiang
This adds build link to daily trybot logs. It also waits 2 hours before polling the building status to trybot. BUG=chromium:673419 TEST=The build link is added in the log. Change-Id: I8fc0ea413ee0f40b398d6eb80c3308c5a1e7d793 Reviewed-on: https://chrome-internal-review.googlesource.com/311042 Commit-Ready: Yunlian Jiang <yunlian@google.com> Tested-by: Yunlian Jiang <yunlian@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-11-14[toolchain-utils] Use new system for accessing build logs.Caroline Tice
The old system for accessing build logs is being deprecated and turned off. This CL switches over to using the new recommended system for accessing build log records. BUG=chromium:664537 TEST=Tested in my account & role account. Change-Id: Id964c43ce09df9c52a6337ea57fb469423c3cf51 Reviewed-on: https://chrome-internal-review.googlesource.com/304258 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 17:56:15 +0000