aboutsummaryrefslogtreecommitdiff
path: root/crosperf/download_images_unittest.py
AgeCommit message (Collapse)Author
2019-04-18crosperf: generate perf report with correct debug filesZhizhou Yang
This patch fixes the issue in chromium:946588. This patch makes perf report no longer use hard code debug directories. There are several different situations: 1) When running tests on a downloaded image, it will download debug.tgz from gs, extract it to debug_files in /tmp. Options --symfs and --vmlinux will depend on this directory, and throw a warning to user that --kallsyms cannot be applied. 2) If running with downloaded image and debug.tgz could not work, then we will try to use local build, but give user a warning that it may not match real symbols well. 3) When running tests with local build, try to find debug info from /build/$board directory. Thus, this patch added a new field in label, called 'debug_path', if this is manually set in experiment file, then crosperf will directly use the location. Downloading of debug.tgz will only happen when perf_args is set in global settings. TEST=Passed all unit tests, tested with eve and sand. BUG=chromium:946588 Change-Id: I7f35d1216d912c8526d5501748f951face1273aa Reviewed-on: https://chromium-review.googlesource.com/1561780 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-04-08[toolchain-utils] Fix remaining lint errors in toolchain-utils.Caroline Tice
In addition to fixing the lint errors, this also fixes the Python formatting issues (ran tc_pyformat on nearly all the files). BUG=chromium:570450 TEST=Ran all crosperf & bisect tool unit tests. Ran afe_lock_machine.py (check machine status) Ran full crosperf test (octane, speedometer, BootPerf) on alex. Change-Id: Ic86f9192801ac67769f3de30f1c5f0d203ce0831 Reviewed-on: https://chromium-review.googlesource.com/471886 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
2017-01-11Fix test_that run for non-telemtry tests.Manoj Gupta
Do not add the autotest_dir argument to test_that for non-telemetry tests. Minor change: Remove a leftover print from download_images unit test. BUG: chromium:679001 TEST:crosperf unit tests Change-Id: I0ff5365902af40097b61ae57d7c0d8d43ea308a8 Reviewed-on: https://chromium-review.googlesource.com/426073 Reviewed-by: Caroline Tice <cmtice@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
2017-01-04Reduce cros_sdk calls in crosperf.Manoj Gupta
Improves crosperf performance by reducing calls to ChrootRunCommand, Instead use RunCommand. BUG: chromium:564889 TEST:crosperf unit tests Change-Id: I0705273d1126b81167d7a789514771122a71b8d3 Reviewed-on: https://chromium-review.googlesource.com/424088 Reviewed-by: Caroline Tice <cmtice@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org>
2016-11-10Crosperf: Remove tar file after uncompressing imageManoj Gupta
Remove downloaded chromium image.tar.xz file after uncompression. Change 2 step untar and uncompress to 1. Catch exceptions during uncompression to avoid having a corrupted bin file if uncompression is interrupted. BUG: chromium:663426 TEST: crosperf unit tests pass Change-Id: I82f674a26bf99cb3491e7db770664c73c004a93b Reviewed-on: https://chrome-internal-review.googlesource.com/303875 Commit-Ready: Manoj Gupta <manojgupta@google.com> Tested-by: Manoj Gupta <manojgupta@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-11-07Download autotest files with crosperf and add autotest path to test_thatManoj Gupta
when running non-telemetry tests BUG: chromium:647429 TEST:crosperf unit tests, sample experiment file that runs WebGl_Aquarium Change-Id: I067e350fee36596ce269b954773c39a3868632aa Reviewed-on: https://chrome-internal-review.googlesource.com/302296 Commit-Ready: Manoj Gupta <manojgupta@google.com> Tested-by: Manoj Gupta <manojgupta@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-11-01Update formatting of files before committing changes for autotest. No ↵Manoj Gupta
functional change. BUG: chromium:647429 TEST: crosperf unit tests Change-Id: I827f9ec4d00a0d8c1ae8a9930d7832289e694dc8 Reviewed-on: https://chrome-internal-review.googlesource.com/301457 Commit-Ready: Manoj Gupta <manojgupta@google.com> Tested-by: Manoj Gupta <manojgupta@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-09-13crosperf+cros_utils: Swap to #!/usr/bin/env.George Burgess IV
`cros lint` was recently updated to complain about using #!/usr/bin/python{,2,3} directly. Instead, it prefers /usr/bin/env python{2,3} now. BUG=None TEST=./run_tests.sh passes; linter seems much happier with crosperf. Change-Id: I9b88a7af1f8e03b7c870781c3d8dc1b872a3dfc3 Reviewed-on: https://chrome-internal-review.googlesource.com/286341 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-02-19refactor and add some checks to image downloading code.Luis Lozano
The nightly testing is failing in misterious ways while downloading images for testing. I am adding a check for the image after "gsutil cp" and, in the process, refactored the code a little. BUG=None TEST=run_tests Change-Id: I3e84ee9f2ea3b9b66cc96bf723bd1bcb94f26af7 Reviewed-on: https://chrome-internal-review.googlesource.com/248966 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Han Shen <shenhan@google.com>
2015-12-29crosperf: fix lint warnings.Yunlian Jiang
BUG=chromium:570454 TEST=unittest passes, lint warning is gone. Change-Id: I4801d560990ad2ed20e30d5cefd5f1ec2c6c5a3d Reviewed-on: https://chrome-internal-review.googlesource.com/243408 Commit-Ready: Yunlian Jiang <yunlian@google.com> Tested-by: Yunlian Jiang <yunlian@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2015-12-21crosperf: fix lint errors.Yunlian Jiang
BUG=chromium:570454 TEST=it is lint clean. Change-Id: I6d13788e7f5f75c2c2478e9d9b1343e21b56e53f Reviewed-on: https://chrome-internal-review.googlesource.com/242947 Commit-Queue: Yunlian Jiang <yunlian@google.com> Trybot-Ready: Yunlian Jiang <yunlian@google.com> Tested-by: Yunlian Jiang <yunlian@google.com> Reviewed-by: Han Shen <shenhan@google.com>
2015-12-16Run pyformat on all the toolchain-utils files.Luis Lozano
This gets rid of a lot of lint issues. Ran by doing this: for f in *.py; do echo -n "$f " ; if [ -x $f ]; then pyformat -i --remove_trailing_comma --yapf --force_quote_type=double $f ; else pyformat -i --remove_shebang --remove_trailing_comma --yapf --force_quote_type=double $f ; fi ; done BUG=chromium:567921 TEST=Ran simple crosperf run. Change-Id: I59778835fdaa5f706d2e1765924389f9e97433d1 Reviewed-on: https://chrome-internal-review.googlesource.com/242031 Reviewed-by: Luis Lozano <llozano@chromium.org> Commit-Queue: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2015-12-14Crosperf: Finish fixing unittest problems.Caroline Tice
This patch finishes fixing the unittest problems. They now all work. BUG=chromium:538397 TEST=./run_tests.sh now completes with no errors. Change-Id: Ie501437d199bfafc8a84cd2a95862550992c2cb8 Reviewed-on: https://chrome-internal-review.googlesource.com/241925 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2015-12-09crosperf: use cros_utils instead of utils.Yunlian Jiang
We got some lint warnings about some module is not in utils. So we change the name. This CL creates a symbolic link cros_utils from utils. Once we are sure that we clean all the code, we can rename the utils to cros_utils directly. BUG=chromium:567921 chromium:568195 TEST=the lint warning is gone. Change-Id: I776e45c7bdd75d1f065ea5797f3bcff457203ca2 Reviewed-on: https://chrome-internal-review.googlesource.com/241457 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2015-06-24Make crosperf unit tests executable.cmtice
BUG=None TEST=None Change-Id: I77e305e4e8711c86116838fd77fcc93fac2c7dc1 Reviewed-on: https://chrome-internal-review.googlesource.com/219922 Reviewed-by: Caroline Tice <cmtice@google.com> Commit-Queue: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com>
2014-05-08Add unittesting for download_images.py (and translate_xbuddy.py).cmtice
This re-structures the code in download_images.py, for easier unit testing, and adds unit tests for download_images. The download_images_buildid_test.py tests translate_xbuddy.py as well. BUG=None TEST=Ran crosperf tests for official & trybot images with new download_images.py file; Ran both unittest files. Change-Id: Ib6ea17d5bd8ed8c87c403a7b1eef49237e5414b8 Reviewed-on: https://chrome-internal-review.googlesource.com/162866 Reviewed-by: Caroline Tice <cmtice@google.com> Commit-Queue: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 05:59:54 +0000