Age | Commit message (Collapse) | Author |
|
Normally we don't do this, but enough changes have accumulated that
we're doing a tree-wide one-off update of the name & style.
BUG=chromium:1098010
TEST=`repo upload` works
Change-Id: Icb42e5012a87920c2cd13b666fb3e55e7e4fb3b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3891080
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
|
|
These are only useful when we're running code in a Python 2.7
interpreter. Since we no longer support python2, drop these.
BUG=b:244644217
TEST=run_tests_for.py shows no new failures
Change-Id: Ief9a12b87a560ab38ca71668636874bcb434a0b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3877339
Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: George Burgess <gbiv@chromium.org>
|
|
This autoformats all Python code with our new Python formatter, `black`.
BUG=b:244644217
TEST=None
Change-Id: I15ee49233d98fb6295c0c53c129bbf8e78e0d9ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3877337
Tested-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: George Burgess <gbiv@chromium.org>
|
|
Result of running `sed -ri 's/Chrom(ium|e) OS/Chrom\1OS/g' $(find -type
f)`.
BUG=None
TEST=None
Change-Id: I59be92537aa19bc989f52b585e307e76dbde401b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3600147
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
|
|
This patch migrates crosperf and its utils to python 3.
TEST=Passed presubmit check; tested with simple experiment locally.
BUG=chromium:1011676
Change-Id: Ib2a9f9c7cf6a1bb1d0b42a1dd3d9e3cbb4d70a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2003796
Tested-by: Zhizhou Yang <zhizhouy@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Commit-Queue: Zhizhou Yang <zhizhouy@google.com>
Auto-Submit: Zhizhou Yang <zhizhouy@google.com>
|
|
In global settings added optional arguments:
"cooldown_time" - wait time prior running a benchmark (default: 0),
"cooldown_temp" - temperature threshold for waiting (default: 40),
"governor" - CPU governor (default: performance),
"cpu_usage" - Restrict CPU usage to specific configurations (default: all).
"turbostat" argument is moved from benchmark to global settings.
Current CL does not apply configurations.
Instead it just propagates parameters to SuiteRunner class
through "dut_config" dictionary.
BUG=chromium:966514
TEST=Unitest and local HW tests passed.
Change-Id: I1b2a65883e5176fdde49c9858ebe62a097df89cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1778515
Tested-by: Denis Nikitin <denik@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
|
|
In crrev.com/c/1398522, we disabled ASLR in crosperf by default. In
that CL, there's no unittest support and other crosperf unittest
might fail because of the CL. This patch is to fix the errors in
unittest and also add unittests for the newly added functionalities.
BUG=chromium:930332
TEST=Unittests pass
Change-Id: I332604245ea2ee1100a498ce021530572e7609ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/1497036
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Tested-by: Tiancong Wang <tcwang@google.com>
|
|
Now that multiple iters inside a single run all report the correct
pass/fail status, update the unittest to reflect that (is has been
broken now for about a month).
BUG=chromium:723807
TEST=ran unittest with fix and it passes now.
Change-Id: Ie92034bbf073b73ce820f28c238f99192840197f
Reviewed-on: https://chromium-review.googlesource.com/508277
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
|
|
In addition to fixing the lint errors, this also fixes the Python
formatting issues (ran tc_pyformat on nearly all the files).
BUG=chromium:570450
TEST=Ran all crosperf & bisect tool unit tests.
Ran afe_lock_machine.py (check machine status)
Ran full crosperf test (octane, speedometer, BootPerf) on alex.
Change-Id: Ic86f9192801ac67769f3de30f1c5f0d203ce0831
Reviewed-on: https://chromium-review.googlesource.com/471886
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
|
|
`cros lint` was recently updated to complain about
using #!/usr/bin/python{,2,3} directly. Instead, it prefers
/usr/bin/env python{2,3} now.
BUG=None
TEST=./run_tests.sh passes; linter seems much happier with crosperf.
Change-Id: I9b88a7af1f8e03b7c870781c3d8dc1b872a3dfc3
Reviewed-on: https://chrome-internal-review.googlesource.com/286341
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
|
|
As part of playing with results_report (so I could make it less
ChromeOS-dependent), I started refactoring results_organizer, which is
only used by results_report.
This was the result. The goal was to make it easier to understand what,
exactly, results_organizer is trying to do.
BUG=chromium:641098
TEST=./test_all.sh passes.
Change-Id: I8e53175fbc1ded6f23631550223905b3321376ca
Reviewed-on: https://chrome-internal-review.googlesource.com/280815
Commit-Ready: George Burgess <gbiv@google.com>
Tested-by: George Burgess <gbiv@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
|
|
BUG=chromium:632098
TEST=cros lint [files]
Change-Id: Ieac300bf7cb3b560fd8caaaacc3714696ca5567f
Reviewed-on: https://chrome-internal-review.googlesource.com/272616
Commit-Ready: Ting-Yuan Huang <laszio@google.com>
Tested-by: Ting-Yuan Huang <laszio@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
|
|
This gets rid of a lot of lint issues.
Ran by doing this:
for f in *.py; do echo -n "$f " ; if [ -x $f ]; then pyformat -i
--remove_trailing_comma --yapf --force_quote_type=double $f ; else
pyformat -i --remove_shebang --remove_trailing_comma --yapf
--force_quote_type=double $f ; fi ; done
BUG=chromium:567921
TEST=Ran simple crosperf run.
Change-Id: I59778835fdaa5f706d2e1765924389f9e97433d1
Reviewed-on: https://chrome-internal-review.googlesource.com/242031
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@google.com>
|
|
BUG=chromium:567883
TEST=these three test passes.
Change-Id: Ia8692cdee660802450d528d40c9a6b457a1cba31
Reviewed-on: https://chrome-internal-review.googlesource.com/241176
Commit-Ready: Yunlian Jiang <yunlian@google.com>
Tested-by: Yunlian Jiang <yunlian@google.com>
Reviewed-by: Caroline Tice <cmtice@google.com>
|
|
Fix the parameters to the various unittests so they match recent
changes and the unittests all pass again.
BUG=None
TEST=I ran all the unittests with the changes.
Change-Id: I083b5127a2ade8f1dbaf2bb173d82183871cb7c7
Reviewed-on: https://chrome-internal-review.googlesource.com/159915
Reviewed-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Caroline Tice <cmtice@google.com>
Tested-by: Caroline Tice <cmtice@google.com>
|
|
This fixes several issues for unittesting.
Now unittest seems to be working.
BUG=None
TEST=crosperf/run_tests.sh passes.
Change-Id: I1dcef7ba55d45fbd00e453f749a8b10dea0332e6
Reviewed-on: https://chrome-internal-review.googlesource.com/145635
Reviewed-by: Caroline Tice <cmtice@google.com>
Commit-Queue: Yunlian Jiang <yunlian@google.com>
Tested-by: Yunlian Jiang <yunlian@google.com>
|
|
BUG=None
TEST=Unittest passes.
Change-Id: I1fda414c1379af40cd1efc13461ed34aafe11847
Reviewed-on: https://gerrit-int.chromium.org/38326
Reviewed-by: Luis Lozano <llozano@chromium.org>
Tested-by: Yunlian Jiang <yunlian@google.com>
Commit-Queue: Yunlian Jiang <yunlian@google.com>
|