aboutsummaryrefslogtreecommitdiff
path: root/crosperf
AgeCommit message (Collapse)Author
2016-09-08crosperf: Make results_report more general.George Burgess IV
The goal of this patch is to allow us to use results_report to generate non-ChromeOS-specific results reports. It's meant to be a nop for regular crosperf runs (except that, in HTML report generation, whitespace in the HTML itself will look a bit different.) Moreover, results_report used to shuffle Experiments around, each of which, unsurprisingly, contained *tons* of data about an experiment. So, part of this patch was reducing results_report's reliance on Experiments, in favor of a new type, BenchmarkResult. Some parts of results_report still rely on Experiments, but only to provide *extra* data. The minimum amount of data needed to make a results report is contained in a BenchmarkResult, and there's a convenient API we can use to make a BenchmarkResult out of an Experiment. This patch also does a massive refactor of results_report, because lots of the code was mildly more icky than it is with this patch applied. The refactor-for-prettiness and refactor-for-BenchmarkResults kind of go hand-in-hand, so it's really hard to split them out. The only part that's not so difficult to split out is the refactor to results_report_templates, but the value of splitting that out is questionable (to me). Speaking of which, all HTML magicks that were in results_report is now in results_report_templates, and now use *actual* Templates. It -- and HTMLReportGenerator -- are hopefully more readable as a result. Next, this makes JSONRsultsReport's GetReport() return a string containing JSON data, rather than calling a callback to write that string to a file. Finally, this includes a change to perf_table. Namely, its removal. It was otherwise unused, and I couldn't get it to even work, so I cleaned it up, made a perf report parser (because I couldn't get the cros_utils one to work, either...), and made sure it functions. If we're able to produce perf reports that cros_utils can parse, I'm happy to back my new parser out; I was primarily using it so I could be sure I didn't break HTML report generation. BUG=chromium:641098 TEST=./run_tests.sh passes Change-Id: I437de9eb39e00c9dd5c223ecd27feaaab544a6fd Reviewed-on: https://chrome-internal-review.googlesource.com/282217 Commit-Ready: George Burgess <gbiv@google.com> Tested-by: George Burgess <gbiv@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-31crosperf: fix appears to have succeeded but returned no results errorYunlian Jiang
This fixes the error appears to have succeeded but returned no results for a set of benchmarks. BUG=chromium:642525 TEST=the results appear for these benchmarks Change-Id: Icad1e1da5881f664cdd96b4cfc3e9ac590db087d Reviewed-on: https://chrome-internal-review.googlesource.com/282696 Commit-Ready: Yunlian Jiang <yunlian@google.com> Tested-by: Yunlian Jiang <yunlian@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-29crosperf: Fix a failing test.George Burgess IV
An earlier commit added extra spacing between remotes in crosperf/default_remotes. This resulted in experiment_factory_unittests.py reporting that there were 5 remotes in some cases (2 of which were ''), since we were splitting on one space. It seems sensible to split on any amount of whitespace, instead. BUG=None TEST=./run_tests.sh passes. Change-Id: I95bd85ba92e5e1f5b30b0273b1b4a6c8853b1995 Reviewed-on: https://chrome-internal-review.googlesource.com/281538 Commit-Ready: George Burgess <gbiv@google.com> Tested-by: George Burgess <gbiv@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-26crosperf: refactor results_organizer; NFC.George Burgess IV
As part of playing with results_report (so I could make it less ChromeOS-dependent), I started refactoring results_organizer, which is only used by results_report. This was the result. The goal was to make it easier to understand what, exactly, results_organizer is trying to do. BUG=chromium:641098 TEST=./test_all.sh passes. Change-Id: I8e53175fbc1ded6f23631550223905b3321376ca Reviewed-on: https://chrome-internal-review.googlesource.com/280815 Commit-Ready: George Burgess <gbiv@google.com> Tested-by: George Burgess <gbiv@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-26crosperf: update lab machine names.Rahul Chaudhry
Updated default_remotes to reflect the latest locations of all toolchain machines from https://sites.google.com/a/google.com/englabs/resources/infrastructure/chromeos/chromeos-devices/special-duts/toolchain BUG=chromium:639389 TEST=None Change-Id: I1da60a961560551a6a63f92f38798f7153197089 Reviewed-on: https://chrome-internal-review.googlesource.com/281375 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-24crosperf: fix telemetry results parsing.Yunlian Jiang
New telemetry results provide multiple values for a single key. This CL uses the average value to make crosperf work. BUG=chromium:639896 TEST=run crosperf with 2 iterations of speedometer. Change-Id: I32e7a00a57dbbe995915af0c32918f1d680ae484 Reviewed-on: https://chrome-internal-review.googlesource.com/279057 Commit-Ready: Yunlian Jiang <yunlian@google.com> Tested-by: Yunlian Jiang <yunlian@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-19[crosperf] Fix reading from cache.Caroline Tice
The read-from-cache code needed to be updated to deal with the new telemetry results format, as did the code for generating json reports (for archiving in the database). BUG=chromium:639106 TEST=Tested with crosperf reading from cache & generating json results. Change-Id: I2c97e5b393583048cc74559d065f498c0f0675a1 Reviewed-on: https://chrome-internal-review.googlesource.com/278298 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-08-19[crosperf] Update lab machine names/locations.Caroline Tice
This CL updates the lab machine names & locations now that they have been moved. BUG=chromium:639389 TEST=pinged all the machines Change-Id: Id30c8635ea3b33e789294f731f28ee2a88b5f17a Reviewed-on: https://chrome-internal-review.googlesource.com/278119 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-08-17[crosperf] Fix telemetry results parsing.Caroline Tice
Many telemetry results fields now contain multiple values. This CL fixes crosperf to accomodate that. BUG=None TEST=Ran crosperf with change and it worked. Change-Id: Iccb8926223c8447b72d51f413756f5dbc09f89de Reviewed-on: https://chrome-internal-review.googlesource.com/276817 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-08-16[crosperf] Change 'page_cycler.' to 'page_cycler_v2.' everywhere.Caroline Tice
Telemetry is switching to using page_cyler_v2 and will stop supporting old page_cycler soon. This CL switches everything in toolchain-utils to reference page_cycler_v2. BUG=None TEST=Ran unittests in crosperf with no issues. Change-Id: I0e3ce29bfaf483507a9ba528c6c7c5a8fa00f00e Reviewed-on: https://chrome-internal-review.googlesource.com/271598 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-10[crosperf] Update parsing of telemetry json file.Caroline Tice
They've updated the format of the output in the json file. This updates crosperf to work with either the old or the new format. BUG=None TEST=./run_tests and ran crosperf successfully. Change-Id: I0b22f4c740943c55c0c521ab715e0b70fbbdfc69 Reviewed-on: https://chrome-internal-review.googlesource.com/274195 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-08-10Random nit fixes in crosperf; NFC.George Burgess IV
This also removes results_sorter.py, which seems to be unused and untested. TEST=./run_tests.sh passes BUG=None Change-Id: I926affb23c78a8a0aedea4ab279da590f8cf93b5 Reviewed-on: https://chrome-internal-review.googlesource.com/273995 Commit-Ready: George Burgess <gbiv@google.com> Tested-by: George Burgess <gbiv@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-08Tiny refactor of a function; NFC.George Burgess IV
TEST=./run_tests.sh passes BUG=None Change-Id: I15220e3ac0f3b6b8a932e2d8dcfaf105be7a9794 Reviewed-on: https://chrome-internal-review.googlesource.com/273450 Commit-Ready: George Burgess <gbiv@google.com> Tested-by: George Burgess <gbiv@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-08-05[Crosperf] Fix lint errors.Caroline Tice
This fixes the crosper lint errors that were assigned to me. BUG=chromium:632110 TEST=ran run_tests.sh; did full crosperf run. Change-Id: I68d136c7399eb4befa2e36e7f513612ca5e53769 Reviewed-on: https://chrome-internal-review.googlesource.com/272755 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-08-02crosperf: fix lint warningsTing-Yuan Huang
BUG=chromium:632098 TEST=cros lint [files] Change-Id: Ieac300bf7cb3b560fd8caaaacc3714696ca5567f Reviewed-on: https://chrome-internal-review.googlesource.com/272616 Commit-Ready: Ting-Yuan Huang <laszio@google.com> Tested-by: Ting-Yuan Huang <laszio@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29crosperf: fix lint warnings.Yunlian Jiang
This fixes the lint warnings from these four files. BUG=chromium:632108 TEST=the lint warnings are gone. Change-Id: Ia923a1e9b8b5ec5d48a02caa1f8ed611857f0ec5 Reviewed-on: https://chrome-internal-review.googlesource.com/272021 Commit-Ready: Yunlian Jiang <yunlian@google.com> Tested-by: Yunlian Jiang <yunlian@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29toolchain-utils: remove uses of deprecated-module 'optparse'.Rahul Chaudhry
BUG=chromium:632109 TEST='./run_tests.py passes' Change-Id: I30393ff8f835f7a9a414b8b1785fa600cb6f50f0 Reviewed-on: https://chrome-internal-review.googlesource.com/272174 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29toolchain-utils: fix *-docstring-* lint errors.Rahul Chaudhry
BUG=chromium:632109 TEST='./run_tests.py passes' Change-Id: I008ad5784bf58fdf58c92f7246862a8e141b4cb0 Reviewed-on: https://chrome-internal-review.googlesource.com/272173 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29toolchain-utils: fix unused-import lint errors.Rahul Chaudhry
BUG=chromium:632109 TEST='./run_tests.py passes' Change-Id: I7c2c9fc3881f3c59ac2a495c836863dcd693402b Reviewed-on: https://chrome-internal-review.googlesource.com/272172 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29toolchain-utils: fix missing-print-function lint warnings.Rahul Chaudhry
BUG=chromium:632109 TEST='./run_tests.py passes' Change-Id: Ie6881fb543cc145c9c09dd83f6b8a70c2f3083bd Reviewed-on: https://chrome-internal-review.googlesource.com/272171 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29toolchain-utils: fix bad-shebang lint error.Rahul Chaudhry
BUG=chromium:632109 TEST='./run_tests.py passes' Change-Id: I893f820e6e6fac2f08db364bb4ce238421a48791 Reviewed-on: https://chrome-internal-review.googlesource.com/272170 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29toolchain-utils: make file formatting conform to tc_pyformat.Rahul Chaudhry
BUG=chromium:632109 TEST=None Change-Id: Ie3da2fa8707478b60e51a237adac7da11e180f9f Reviewed-on: https://chrome-internal-review.googlesource.com/272169 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29toolchain-utils: fix results_cache_unittest.pyRahul Chaudhry
The test was failing with "RuntimeError: Could not run find command!". It broke after https://chrome-internal-review.googlesource.com/#/c/270698 which added GetResultsFile(). This CL adds the Fake version for testing. BUG=None TEST='./results_cache_unittest.py passes' Change-Id: I2bb92a394c8756bfb30941ce12e87396b22efe02 Reviewed-on: https://chrome-internal-review.googlesource.com/272168 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-29toolchain-utils: fix benchmark_run_unittest.pyRahul Chaudhry
The 'show_all' argument for CreateFromRun was removed in https://chrome-internal-review.googlesource.com/#/c/255303 BUG=None TEST='./benchmark_run_unittest.py passes' Change-Id: I984393d4db5bf98f0f273c25e366bb31a3e9b845 Reviewed-on: https://chrome-internal-review.googlesource.com/272167 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-07-27[crosperf] Clean up exceptions.Caroline Tice
Found all instances of 'raise Exception' and changed them to raise something slightly more specific. Changed a few 'except Exception' statements appropriately as well. BUG=chromium:566255 TEST=None Change-Id: If2666bd55838342bc71431e5e6ab2157c2c9e125 Reviewed-on: https://chrome-internal-review.googlesource.com/270731 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-07-25[crosperf] Get telemetry results from file instead of stdout.Caroline Tice
This CL fixes crosperf to read the telemetry json results file for getting its results, rather than parsing stdout. BUG=chromium:620464 TEST=Successfully got results for octane, kraken & speedometer on daisy. Change-Id: I5bf8cf143688d83ca38c6453006360a45e945544 Reviewed-on: https://chrome-internal-review.googlesource.com/270698 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-07-25[toolchain-utils] Finish switching utils/ to cros_utils/.Caroline Tice
This CL finishes switching the subdirectory from 'utils' to 'cros_utils'. It changes all the remaining import statements to use 'cros_utils'; it removes the 'cros_utils' symlink, and it renames the 'utils' subdirectory to 'cros_utils'. BUG=chromium:568195 TEST=ran crosperf & binary search tool unittests. Change-Id: I7427f8bfb2ddac3a4b6108e46782039059684382 Reviewed-on: https://chrome-internal-review.googlesource.com/270396 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Cassidy Burden <cburden@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-06-30[crosperf] Add more tests for results_report.George Burgess IV
With this patch, all of the classes in results_report have tests. The tests aren't overly extensive, but we can always improve on them later. This also includes a few small cleanups of parts of machine_manager, and results_report. BUG=None TEST=./run_tests.sh Change-Id: I9613579d4f8c1079b452e1a0a2edf47b189ac1cd Reviewed-on: https://chrome-internal-review.googlesource.com/268057 Commit-Ready: George Burgess <gbiv@google.com> Tested-by: George Burgess <gbiv@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-06-29[crosperf] Add results_report tests, minor refactors.George Burgess IV
This adds unit tests for results_report.JSONResultsReport and results_report.ParseChromeosImage. The test for the former aren't as extensive as they could be, but I hope to add more in the future. This also simplifies ParseChromeosImage, and does a few refactors to JSONResultsReport. This also fixes all of `cros lint`'s complaints about results_report. BUG=None TEST=./run_tests.sh Change-Id: Ice4267a5ff2e10df6690595c6b80db1ee1977d50 Reviewed-on: https://chrome-internal-review.googlesource.com/267665 Commit-Ready: George Burgess <gbiv@google.com> Tested-by: George Burgess <gbiv@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-06-29[crosperf] Fix setting descriptions; NFC.George Burgess IV
This also removes an unused import, and adds a few docstrings/etc. to make `cros lint` happy. BUG=None TEST=./run_tests.sh Change-Id: I0279a0db1d1cb1a1bc655a06bfc6b33d87495610 Reviewed-on: https://chrome-internal-review.googlesource.com/267277 Commit-Ready: George Burgess <gbiv@google.com> Tested-by: George Burgess <gbiv@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-06-09[crosperf] Fix default result for telemetry tests.Ting-Yuan Huang
The tests fixed are: smoothness.tough_webgl_cases page_cycler.typical_25 The names of the default summary fields for these tests have changed, which makes crosperf fail since it can't find the right result fields. This CL fixes that problem. BUG=chromium:618224 TEST=Tested locally Change-Id: I1f3a8eed476732f967d5a628bea0f9fe358ed3e9 Reviewed-on: https://chrome-internal-review.googlesource.com/263236 Commit-Ready: Ting-Yuan Huang <laszio@google.com> Tested-by: Ting-Yuan Huang <laszio@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
2016-05-26[Crosperf] Update machine names.Caroline Tice
Update default_remotes to reflect the new names/locations of our lab lumpy machines. BUG=None TEST=ping'd & ssh'd into the new names/locations. Change-Id: Icc75361359ede9cf0aeb398563dd9939320a3531 Reviewed-on: https://chrome-internal-review.googlesource.com/260566 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-05-16[crosperf] Update machine locations.Caroline Tice
This updates the default_remotes file so the machines reflect the new names/locations for the HW lab (the machines got moved). BUG=chromium:612170 TEST=Pinged the new machines; ssh'd into them to verify them; looked at them on the AFE web site. Change-Id: Ib27612555e6d8441bec4670d76fd4cf7b2b7b5a7 Reviewed-on: https://chrome-internal-review.googlesource.com/258934 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-05-12crosperf: Add script to measure overhead of some perf commandsDavid Sharp
BUG=none TEST=Ran the script Change-Id: I07d998df4e43e632308c90ea336c228c34b7a2a7 Reviewed-on: https://chrome-internal-review.googlesource.com/258705 Commit-Ready: David Sharp <dhsharp@google.com> Tested-by: David Sharp <dhsharp@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-04-15Fix error with json reports with multi-valued results.Caroline Tice
BUG=None TEST=Tested in in role account. Change-Id: I502dda87f9a3647e8bea61a54f587813eb18b755 Reviewed-on: https://chrome-internal-review.googlesource.com/255739 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-04-14[crosperf] Fix more lint errors.Caroline Tice
BUG=chromium:567921 Test=Tested in my directory. Change-Id: Ibe128dd030887e0372380fb8f95a5e37ee63feeb Reviewed-on: https://chrome-internal-review.googlesource.com/255303 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-04-13Fix Crosperf to deal with a list of values being returned.Caroline Tice
BUG=None TEST=Tested in my tree. Change-Id: I85e5729f857e7771e4a59a3879081e6504a1fb44 Reviewed-on: https://chrome-internal-review.googlesource.com/255298 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Han Shen <shenhan@google.com>
2016-03-31Update default remotes for new lumpy location.Caroline Tice
The HW lab has moved one of the lumpy machines. This CL updates default_remotes to reflect the new lumpy machine name. BUG=None TEST=looked at new machine on AFE. Change-Id: Ia05a3928d6b4ed251662a3d0a51d4248d632634d Reviewed-on: https://chrome-internal-review.googlesource.com/253100 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-03-31[crosperf] Update to use new telemetry json output, if present.Caroline Tice
Autotest and telemetry and have changed their output and now put out a json file instead of the old keyvals file. This CL updates Crosperf to check for both kinds of output file and do the right thing with either. BUG=chromium:597099 TEST=Tested in nightly tests. Change-Id: Ic7dc9d63d87917f50ff7f817bea7c1512594eb07 Reviewed-on: https://chrome-internal-review.googlesource.com/253019 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-03-30[crosperf] Don't fail completely on missing result field.Caroline Tice
After running to completion, while generating the json report Crosperf sometimes tries to look for a result field that should be there but isn't. Previously this would cause a runtime exception and Crosperf would fail without generating any reports at all. This CL fixes that (now a report still gets generated, without the one missing field). BUG=None TEST=Tested this in nightly tests. Change-Id: I35043e8c90fad6dbb5bfd5dede1905a2238bd3b7 Reviewed-on: https://chrome-internal-review.googlesource.com/253035 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Han Shen <shenhan@google.com>
2016-03-26Update default_remotes to reflect new machine locations.Caroline Tice
The stumpy & parrot chromebooks in the HW lab have been moved again; this CL reflects their latest locations. BUG=chromium:597689 TEST=Verified the new machines via the AFE website. Change-Id: Iecb6186adcf242e53727857f81b1012f39c8798c Reviewed-on: https://chrome-internal-review.googlesource.com/252406 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-03-24Update default_remotes to reflect new machine locations.Caroline Tice
The stumpy & parrot chromebooks in the HW lab have been moved; this CL reflects their new locations. BUG=chromium:597689 TEST=Verified the new machines via the AFE website. Change-Id: Ia000621a117d923cb7d18442cf4ae9bbf66bbda5 Reviewed-on: https://chrome-internal-review.googlesource.com/252186 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-03-09Add new parrots/stumpys to default_remoteLuis Lozano
See b/27522806 BUG=None TEST=None Change-Id: I81ed220c5c37b447bab78295f435baac359ff3cc Reviewed-on: https://chrome-internal-review.googlesource.com/250685 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-03-05[crosperf] Fix missing chrome_version problem (v2).Caroline Tice
When generating the json reports, occasionally the chrome_version comes up blank (this can happen when reading some results from the cache, for example). A blank chrome_version messes up our dremel database scripts. This CL updates the read-cache scenario to find the chrome_version in the cache keys (human-readable) file. BUG=chromium:591494 TEST=Tested with experiment that was generating blank Chrome versions and this fixed the problem. Change-Id: I29985581aa00bc30fb65720fb9d197f1475445e4 Reviewed-on: https://chrome-internal-review.googlesource.com/249960 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-02-27toolchain-utils: fix remaining cros lint errors.Rahul Chaudhry
BUG=chromium:570458 TEST='crosperf/run_tests.sh' passes. Change-Id: I5566349cc97233e1ddb6d98121cd6f44e14bf0a9 Reviewed-on: https://chrome-internal-review.googlesource.com/249482 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-02-22[crosperf] Fix default result for smoothness.tough_webgl_cases.Caroline Tice
The name of the default summary field for this test has changed, which makes crosperf fail since it can't find the right result field. This CL fixes that problem. BUG=None TEST=Tested with nightly testd on chrotomation2. Change-Id: I049c8abd2dd30b64aec8be65feb56b31115a4921 Reviewed-on: https://chrome-internal-review.googlesource.com/249130 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Yunlian Jiang <yunlian@google.com>
2016-02-19[crosperf] Fix recent change that is searching for wrong path.Caroline Tice
The recent fixes added a check for the downloaded image that uses the wrong filename (checks for the untar'd & uncompressed image). This CL fixes this new bug. BUG=None TEST=Tested crosperf with this fix and downloading images now works again. Change-Id: Iebdb0cfb65885dbaf4a184bae89049f31739e302 Reviewed-on: https://chrome-internal-review.googlesource.com/248987 Commit-Ready: Caroline Tice <cmtice@google.com> Tested-by: Caroline Tice <cmtice@google.com> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-02-19refactor and add some checks to image downloading code.Luis Lozano
The nightly testing is failing in misterious ways while downloading images for testing. I am adding a check for the image after "gsutil cp" and, in the process, refactored the code a little. BUG=None TEST=run_tests Change-Id: I3e84ee9f2ea3b9b66cc96bf723bd1bcb94f26af7 Reviewed-on: https://chrome-internal-review.googlesource.com/248966 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Han Shen <shenhan@google.com>
2016-02-18[crosperf] Remove media.tough_video_cases from nightly tests.Caroline Tice
media.tough_video_cases does not have any good result field to use and it has too high a stddev/mean to be a reliable test. This CL removes it from our nightly test set. BUG=None TEST=None Change-Id: Id80a9dd11de36a1fed01d7735f32e98908c7e1b0 Reviewed-on: https://chrome-internal-review.googlesource.com/248615 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org>
2016-02-13toolchain-utils: fix bare-except lint warning.Rahul Chaudhry
"using a bare except: is almost never a good idea" - https://docs.python.org/2/howto/doanddont.html#except BUG=chromium:570458 TEST='crosperf/run_tests.sh' passes. Change-Id: I2222fbc0fdc116961388c67b51ee259b49d0be88 Reviewed-on: https://chrome-internal-review.googlesource.com/248233 Commit-Ready: Rahul Chaudhry <rahulchaudhry@google.com> Tested-by: Rahul Chaudhry <rahulchaudhry@google.com> Reviewed-by: Caroline Tice <cmtice@google.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 09:06:29 +0000