From 92fff664338311355a744616074c58d9c98527b5 Mon Sep 17 00:00:00 2001 From: Manoj Gupta Date: Thu, 28 Jan 2021 10:28:06 -0800 Subject: compiler_wrapper: Add "-fcommon" to GCC pass "-fcommon" to GCC to match clang. This is needed since GCC 10 defaults to "-fno-common". BUG=chromium:1171833 TEST=go test Change-Id: Iceac503c8cc14afc1837c6952100189f45d2b567 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2657043 Reviewed-by: George Burgess Tested-by: Manoj Gupta --- .../testdata/cros_hardened_golden/clangtidy.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'compiler_wrapper/testdata/cros_hardened_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_golden/clangtidy.json index 06e114cb..60aa339b 100644 --- a/compiler_wrapper/testdata/cros_hardened_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_golden/clangtidy.json @@ -33,7 +33,6 @@ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", "-fno-addrsig", - "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -45,6 +44,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", + "-fcommon", "-fstack-protector-strong", "-fPIE", "-pie", @@ -68,7 +68,6 @@ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", "-fno-addrsig", - "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -80,6 +79,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", + "-fcommon", "-fstack-protector-strong", "-fPIE", "-pie", @@ -133,7 +133,6 @@ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", "-fno-addrsig", - "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -145,6 +144,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", + "-fcommon", "-fstack-protector-strong", "-fPIE", "-pie", @@ -169,7 +169,6 @@ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", "-fno-addrsig", - "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -181,6 +180,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", + "-fcommon", "-fstack-protector-strong", "-fPIE", "-pie", @@ -236,7 +236,6 @@ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", "-fno-addrsig", - "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -248,6 +247,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", + "-fcommon", "-fstack-protector-strong", "-fPIE", "-pie", @@ -275,7 +275,6 @@ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", "-fno-addrsig", - "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -287,6 +286,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", + "-fcommon", "-fstack-protector-strong", "-fPIE", "-pie", @@ -343,7 +343,6 @@ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", "-fno-addrsig", - "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -355,6 +354,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", + "-fcommon", "-fstack-protector-strong", "-fPIE", "-pie", @@ -379,7 +379,6 @@ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", "-fno-addrsig", - "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -391,6 +390,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", + "-fcommon", "-fstack-protector-strong", "-fPIE", "-pie", -- cgit v1.2.3