From b74b4717a13bc4d55ead27ca834c2c2550385fb5 Mon Sep 17 00:00:00 2001 From: Manoj Gupta Date: Sat, 29 Feb 2020 07:52:14 -0800 Subject: compiler_wrapper: Stop disabling two warnings. Chrome OS code now is clean of following warnings: "-Wreorder-init-list" and "-return-stack-address" so stop disabling them. BUG=chromium:1057384 TEST=warnings tested by CL:1898670 Change-Id: I568cf93a9e836ba936ea976312e9a78b5c473157 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2081707 Tested-by: Manoj Gupta Reviewed-by: George Burgess --- .../cros_hardened_llvmnext_golden/clangtidy.json | 16 ---------------- 1 file changed, 16 deletions(-) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index d75eb527..b047adec 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -40,9 +40,7 @@ "-Wno-section", "-static-libgcc", "-fuse-ld=lld", - "-Wno-reorder-init-list", "-Wno-final-dtor-non-final-class", - "-Wno-return-stack-address", "-Werror=poison-system-directories", "-fstack-protector-strong", "-fPIE", @@ -71,9 +69,7 @@ "-Wno-section", "-static-libgcc", "-fuse-ld=lld", - "-Wno-reorder-init-list", "-Wno-final-dtor-non-final-class", - "-Wno-return-stack-address", "-Werror=poison-system-directories", "-fstack-protector-strong", "-fPIE", @@ -132,9 +128,7 @@ "-Wno-section", "-static-libgcc", "-fuse-ld=lld", - "-Wno-reorder-init-list", "-Wno-final-dtor-non-final-class", - "-Wno-return-stack-address", "-Werror=poison-system-directories", "-fstack-protector-strong", "-fPIE", @@ -164,9 +158,7 @@ "-Wno-section", "-static-libgcc", "-fuse-ld=lld", - "-Wno-reorder-init-list", "-Wno-final-dtor-non-final-class", - "-Wno-return-stack-address", "-Werror=poison-system-directories", "-fstack-protector-strong", "-fPIE", @@ -227,9 +219,7 @@ "-Wno-section", "-static-libgcc", "-fuse-ld=lld", - "-Wno-reorder-init-list", "-Wno-final-dtor-non-final-class", - "-Wno-return-stack-address", "-Werror=poison-system-directories", "-fstack-protector-strong", "-fPIE", @@ -262,9 +252,7 @@ "-Wno-section", "-static-libgcc", "-fuse-ld=lld", - "-Wno-reorder-init-list", "-Wno-final-dtor-non-final-class", - "-Wno-return-stack-address", "-Werror=poison-system-directories", "-fstack-protector-strong", "-fPIE", @@ -326,9 +314,7 @@ "-Wno-section", "-static-libgcc", "-fuse-ld=lld", - "-Wno-reorder-init-list", "-Wno-final-dtor-non-final-class", - "-Wno-return-stack-address", "-Werror=poison-system-directories", "-fstack-protector-strong", "-fPIE", @@ -358,9 +344,7 @@ "-Wno-section", "-static-libgcc", "-fuse-ld=lld", - "-Wno-reorder-init-list", "-Wno-final-dtor-non-final-class", - "-Wno-return-stack-address", "-Werror=poison-system-directories", "-fstack-protector-strong", "-fPIE", -- cgit v1.2.3 From 30171e1539d5f63491365d6363a74791d7d0432e Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Wed, 4 Mar 2020 13:13:47 -0800 Subject: compiler-wrapper: Update clang-tidy flags to match Android. The flags that we use to generate clang tidy warnings have gotten out of sync with the flags the Android team uses. This CL fixes that. BUG=None TEST=None Change-Id: I766af02fee111e2e2233612e8352de1fb0802c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2088431 Reviewed-by: George Burgess Reviewed-by: Manoj Gupta Commit-Queue: Caroline Tice Tested-by: Caroline Tice --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index b047adec..dcaed1e5 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -26,7 +26,7 @@ "cmd": { "path": "../../usr/bin/clang-tidy", "args": [ - "-checks=*,google*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-build-using-namespace,-google-default-arguments,-google-explicit-constructor,-google-readability*,-google-runtime-int,-google-runtime-references,-hicpp-avoid-c-arrays,-hicpp-braces-around-statements,-hicpp-no-array-decay,-hicpp-signed-bitwise,-hicpp-uppercase-literal-suffix,-hicpp-use-auto,-llvm-namespace-comment,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", + "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", "main.cc", "--", "-resource-dir=someResourceDir", @@ -114,7 +114,7 @@ "cmd": { "path": "../../usr/bin/clang-tidy", "args": [ - "-checks=*,google*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-build-using-namespace,-google-default-arguments,-google-explicit-constructor,-google-readability*,-google-runtime-int,-google-runtime-references,-hicpp-avoid-c-arrays,-hicpp-braces-around-statements,-hicpp-no-array-decay,-hicpp-signed-bitwise,-hicpp-uppercase-literal-suffix,-hicpp-use-auto,-llvm-namespace-comment,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", + "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", "main.cc", "--", "-resource-dir=someResourceDir", @@ -205,7 +205,7 @@ "cmd": { "path": "../../usr/bin/clang-tidy", "args": [ - "-checks=*,google*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-build-using-namespace,-google-default-arguments,-google-explicit-constructor,-google-readability*,-google-runtime-int,-google-runtime-references,-hicpp-avoid-c-arrays,-hicpp-braces-around-statements,-hicpp-no-array-decay,-hicpp-signed-bitwise,-hicpp-uppercase-literal-suffix,-hicpp-use-auto,-llvm-namespace-comment,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", + "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", "main.cc", "--", "-resource-dir=someResourceDir", @@ -300,7 +300,7 @@ "cmd": { "path": "../../usr/bin/clang-tidy", "args": [ - "-checks=*,google*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-build-using-namespace,-google-default-arguments,-google-explicit-constructor,-google-readability*,-google-runtime-int,-google-runtime-references,-hicpp-avoid-c-arrays,-hicpp-braces-around-statements,-hicpp-no-array-decay,-hicpp-signed-bitwise,-hicpp-uppercase-literal-suffix,-hicpp-use-auto,-llvm-namespace-comment,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", + "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", "main.cc", "--", "-resource-dir=someResourceDir", -- cgit v1.2.3 From 99b3ff928b1c000980d331f30174614484095d37 Mon Sep 17 00:00:00 2001 From: Manoj Gupta Date: Fri, 13 Mar 2020 10:33:13 -0700 Subject: compiler_wrapper: Add "-fcommon" to clang invocations Clang ToT has switched to "-fno-common" as default to match GCC 10 which breaks many packages. Upgrading to ToT versions of many packages does not fix the problem as packages upstream have not fixed them yet. Pass "-fcommon" in compiler wrapper to workaround this for now. This does not change the current clang behavior which defaults to "-fcommon" so this is a NFC. BUG=chromium:1060413 TEST=packages build with ToT clang; NFC for current clang Change-Id: I5a40e502db201615f45a7e4720105bebef2f2b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2102905 Reviewed-by: George Burgess Commit-Queue: Manoj Gupta Tested-by: Manoj Gupta --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index dcaed1e5..26abab87 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -34,6 +34,7 @@ "-Qunused-arguments", "-grecord-gcc-switches", "-fno-addrsig", + "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -63,6 +64,7 @@ "-Qunused-arguments", "-grecord-gcc-switches", "-fno-addrsig", + "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -122,6 +124,7 @@ "-Qunused-arguments", "-grecord-gcc-switches", "-fno-addrsig", + "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -152,6 +155,7 @@ "-Qunused-arguments", "-grecord-gcc-switches", "-fno-addrsig", + "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -213,6 +217,7 @@ "-Qunused-arguments", "-grecord-gcc-switches", "-fno-addrsig", + "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -246,6 +251,7 @@ "-Qunused-arguments", "-grecord-gcc-switches", "-fno-addrsig", + "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -308,6 +314,7 @@ "-Qunused-arguments", "-grecord-gcc-switches", "-fno-addrsig", + "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", @@ -338,6 +345,7 @@ "-Qunused-arguments", "-grecord-gcc-switches", "-fno-addrsig", + "-fcommon", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", "-Wno-unknown-warning-option", -- cgit v1.2.3 From 3b2358092e00ab7904a873b516ac6aac832c2277 Mon Sep 17 00:00:00 2001 From: Tiancong Wang Date: Wed, 22 Apr 2020 14:07:55 -0700 Subject: wrapper: Temporarily disable -Wmax-tokens As reported in crbug.com/1072209, -Wmax-tokens is causing latest chrome fail to build. While we are blocked by Chrome uprevs, we want to update the compiler by disabling the warning, until it's fixed properly on upstream Chrome. BUG=chromium:1072209 TEST=Local testing in CrOS Change-Id: I082dd342a802e80250d0fca7c4b15afb4e972e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2161770 Commit-Queue: Tiancong Wang Tested-by: Tiancong Wang Reviewed-by: George Burgess --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index 26abab87..f165726b 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -43,6 +43,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -73,6 +74,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -133,6 +135,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -164,6 +167,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -226,6 +230,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -260,6 +265,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -323,6 +329,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -354,6 +361,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", -- cgit v1.2.3 From 4ceeb16b9162334c929d7232e5b7a2c96e9189f7 Mon Sep 17 00:00:00 2001 From: Tiancong Wang Date: Thu, 30 Apr 2020 17:38:09 +0000 Subject: Revert "wrapper: Temporarily disable -Wmax-tokens" This reverts commit 3b2358092e00ab7904a873b516ac6aac832c2277. According to crrev.com/c/2171058, the fix in chromium could work. Will wait till the patch submitted in chromium and CrOS uprevs to merge the change into CrOS. Reason for revert: The workaround is not needed anymore. Original change's description: > wrapper: Temporarily disable -Wmax-tokens > > As reported in crbug.com/1072209, -Wmax-tokens is causing latest > chrome fail to build. While we are blocked by Chrome uprevs, we > want to update the compiler by disabling the warning, until it's > fixed properly on upstream Chrome. > > BUG=chromium:1072209 > TEST=Local testing in CrOS > > Change-Id: I082dd342a802e80250d0fca7c4b15afb4e972e7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2161770 > Commit-Queue: Tiancong Wang > Tested-by: Tiancong Wang > Reviewed-by: George Burgess Bug: chromium:1072209 Change-Id: I904fb3c4f7d125579667bef675be654a5465fad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2173949 Tested-by: Tiancong Wang Reviewed-by: Manoj Gupta Commit-Queue: Tiancong Wang --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 -------- 1 file changed, 8 deletions(-) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index f165726b..26abab87 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -43,7 +43,6 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -74,7 +73,6 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -135,7 +133,6 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -167,7 +164,6 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -230,7 +226,6 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -265,7 +260,6 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -329,7 +323,6 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", @@ -361,7 +354,6 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-Wno-max-tokens", "-fstack-protector-strong", "-fPIE", "-pie", -- cgit v1.2.3 From dc996b9cd333b330ca79985a93f9a71995676a71 Mon Sep 17 00:00:00 2001 From: Jian Cai Date: Wed, 17 Jun 2020 15:27:24 -0700 Subject: compiler_wrapper: redirect clang crash dignoses Redirect all diagnoses of clang crashes to a dedicated directory using fcrash-diagnostics-dir so we can upload these files to the cloud. The flag was added to clangPostFlags to overwite redirection done on package level. BUG=chromium:1056904 TEST=None Change-Id: I78bfc77d7f3af8556b4308f2e71407d627627747 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2251038 Reviewed-by: Manoj Gupta Commit-Queue: Jian Cai Tested-by: Jian Cai --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index 26abab87..b8b786db 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -43,6 +43,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -73,6 +74,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -133,6 +135,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -164,6 +167,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -226,6 +230,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -260,6 +265,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -323,6 +329,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -354,6 +361,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", -- cgit v1.2.3 From 94fd622c652b7aa46f2ca24d3a0efe93c7fde040 Mon Sep 17 00:00:00 2001 From: Bob Haarman Date: Thu, 9 Jul 2020 17:14:53 -0700 Subject: compiler_wrapper: remove -grecord-gcc-switches -grecord-gcc-switches causes the compiler and compiler flags to be stored in the produced debug information. This causes Goma builds to be non-deterministic, because the compiler path differs depending on whether the compiler was run locally or on Goma. This, in turn, causes cache pollution and needless work. Since we are not in fact using the information stored by -grecord-gcc-switches, this change disables it. We can re-enable it when we want to start using the information, provided we come up with another way to avoid the issues described earlier. BUG=chromium:1103065 TEST=Build an object file in chromeos-chrome and check that info is absent Change-Id: Ib8022a3a1baf2e4b5d3d9d1453deb67f539baff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2290624 Commit-Queue: Bob Haarman Tested-by: Bob Haarman Reviewed-by: George Burgess Reviewed-by: Tiancong Wang --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 -------- 1 file changed, 8 deletions(-) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index b8b786db..eae5c3d9 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -32,7 +32,6 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -63,7 +62,6 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -124,7 +122,6 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -156,7 +153,6 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -219,7 +215,6 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -254,7 +249,6 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -318,7 +312,6 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", @@ -350,7 +343,6 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-grecord-gcc-switches", "-fno-addrsig", "-fcommon", "-Wno-tautological-constant-compare", -- cgit v1.2.3 From d1a9a25c3b25e5eb3623c2ca1f5428673ca2ee37 Mon Sep 17 00:00:00 2001 From: Jian Cai Date: Wed, 29 Jul 2020 18:03:33 -0700 Subject: compiler_wrapper: add -fexperimental-new-pass-manager LLVM is currently build with DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=ON on Chrome OS. This is however not reflected in clang crash diagnoses. Adding -fexperimental-new-pass-manager to help with reproducibility on 4c. BUG=chromium:1111103 TEST=CQ tests. Change-Id: Ie01431dff397e982469e29c9132e21374354762d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2327414 Reviewed-by: George Burgess Reviewed-by: Manoj Gupta Tested-by: Jian Cai --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index eae5c3d9..59642459 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -43,6 +43,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", + "-fexperimental-new-pass-manager", "-fstack-protector-strong", "-fPIE", "-pie", @@ -73,6 +74,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", + "-fexperimental-new-pass-manager", "-fstack-protector-strong", "-fPIE", "-pie", @@ -133,6 +135,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", + "-fexperimental-new-pass-manager", "-fstack-protector-strong", "-fPIE", "-pie", @@ -164,6 +167,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", + "-fexperimental-new-pass-manager", "-fstack-protector-strong", "-fPIE", "-pie", @@ -226,6 +230,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", + "-fexperimental-new-pass-manager", "-fstack-protector-strong", "-fPIE", "-pie", @@ -260,6 +265,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", + "-fexperimental-new-pass-manager", "-fstack-protector-strong", "-fPIE", "-pie", @@ -323,6 +329,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", + "-fexperimental-new-pass-manager", "-fstack-protector-strong", "-fPIE", "-pie", @@ -354,6 +361,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", + "-fexperimental-new-pass-manager", "-fstack-protector-strong", "-fPIE", "-pie", -- cgit v1.2.3 From 1713d258a4eaa8a52a7216971bf4b40b36b27aee Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Fri, 7 Aug 2020 19:17:52 -0700 Subject: compiler_wrapper: use crashArtifactsDir to apply clang opts Since we now have crashArtifactsDir as a more abstract concept, it seems good to apply '-fcrash-diagnostics-dir=' based on that, rather than having it as an explicit clang flag. BUG=chromium:1113442 TEST=FIXME Change-Id: I147779d7cf8806b3bc712c2998446158e87ec967 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2343975 Reviewed-by: Manoj Gupta Tested-by: George Burgess --- .../cros_hardened_llvmnext_golden/clangtidy.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index 59642459..b526ec7c 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -42,8 +42,8 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fexperimental-new-pass-manager", + "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -73,8 +73,8 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fexperimental-new-pass-manager", + "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -134,8 +134,8 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fexperimental-new-pass-manager", + "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -166,8 +166,8 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fexperimental-new-pass-manager", + "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -229,8 +229,8 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fexperimental-new-pass-manager", + "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -264,8 +264,8 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fexperimental-new-pass-manager", + "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -328,8 +328,8 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fexperimental-new-pass-manager", + "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -360,8 +360,8 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fexperimental-new-pass-manager", + "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", -- cgit v1.2.3 From 243ce37bf481923dafd7cb30c860aa65744914f1 Mon Sep 17 00:00:00 2001 From: Jian Cai Date: Mon, 10 Aug 2020 18:35:12 -0700 Subject: compiler_wrapper: remove some flags from unsupport clang flags LLVM implemented some flags that used to not be supported. Remove these flags from unsupported flags in the wrapper. BUG=chromium:1112929 TEST=tested locally. Change-Id: If91df0d35ac3db926067d3e0c5e213f6c5e3f390 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2346956 Reviewed-by: Manoj Gupta Tested-by: Jian Cai --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index b526ec7c..219a8b2f 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -51,6 +51,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-mno-movbe", "-B../../bin", "-target", "x86_64-cros-linux-gnu" @@ -82,6 +83,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-mno-movbe", "-B../../bin", "-target", "x86_64-cros-linux-gnu" @@ -143,6 +145,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-mno-movbe", "-B../../bin", "-target", "x86_64-cros-linux-gnu" @@ -175,6 +178,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-mno-movbe", "-B../../bin", "-target", "x86_64-cros-linux-gnu" @@ -238,6 +242,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-mno-movbe", "-B../../bin", "-target", "x86_64-cros-linux-gnu" @@ -273,6 +278,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-mno-movbe", "-B../../bin", "-target", "x86_64-cros-linux-gnu" @@ -337,6 +343,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-mno-movbe", "-B../../bin", "-target", "x86_64-cros-linux-gnu" @@ -369,6 +376,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-mno-movbe", "-B../../bin", "-target", "x86_64-cros-linux-gnu" -- cgit v1.2.3 From 8a9125c6e22cd83cbccc41434780e953890adeb1 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Tue, 22 Sep 2020 08:34:51 -0700 Subject: toolchain-utils: Update compiler wrapper to disable warning. This CL updates toolchain-utils to match recent compiler wrapper changes in sys-devel/llvm/files. It's purpose is to disable the new warning -Wcompound-token-split-by-space. Also update golden tests appropriately. BUG=chromium:1130080 TEST=Previous CL already tessted/committed. Change-Id: I261250dc7ed6f1be7c3aa4652d793c924e1dc18d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2423619 Commit-Queue: Caroline Tice Commit-Queue: George Burgess Tested-by: Caroline Tice Auto-Submit: Caroline Tice Reviewed-by: George Burgess --- .../testdata/cros_hardened_llvmnext_golden/clangtidy.json | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index 219a8b2f..b0526836 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -51,6 +51,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-Wno-compound-token-split-by-space", "-mno-movbe", "-B../../bin", "-target", @@ -83,6 +84,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-Wno-compound-token-split-by-space", "-mno-movbe", "-B../../bin", "-target", @@ -145,6 +147,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-Wno-compound-token-split-by-space", "-mno-movbe", "-B../../bin", "-target", @@ -178,6 +181,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-Wno-compound-token-split-by-space", "-mno-movbe", "-B../../bin", "-target", @@ -242,6 +246,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-Wno-compound-token-split-by-space", "-mno-movbe", "-B../../bin", "-target", @@ -278,6 +283,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-Wno-compound-token-split-by-space", "-mno-movbe", "-B../../bin", "-target", @@ -343,6 +349,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-Wno-compound-token-split-by-space", "-mno-movbe", "-B../../bin", "-target", @@ -376,6 +383,7 @@ "-fno-omit-frame-pointer", "main.cc", "-Wno-implicit-int-float-conversion", + "-Wno-compound-token-split-by-space", "-mno-movbe", "-B../../bin", "-target", -- cgit v1.2.3 From d8187c7c4ba1296034498fc657aef0e032e2a96f Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Mon, 5 Oct 2020 08:41:41 -0700 Subject: toolchain-utils: Sync compiler wrapper changes with llvm changes. This updates the compiler wrapper flags to match recent updates to compiler wrapper in sys-devel/llvm (for llvm-next). BUG=chromium:1133468 TEST=None Change-Id: Ibab9f0e1d0e35db3ba838e70a812efe2d5137a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2448871 Reviewed-by: Manoj Gupta Commit-Queue: Caroline Tice Tested-by: Caroline Tice --- .../cros_hardened_llvmnext_golden/clangtidy.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json index b0526836..06e114cb 100644 --- a/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_llvmnext_golden/clangtidy.json @@ -43,6 +43,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fexperimental-new-pass-manager", + "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", @@ -52,6 +53,7 @@ "main.cc", "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -76,6 +78,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fexperimental-new-pass-manager", + "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", @@ -85,6 +88,7 @@ "main.cc", "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -139,6 +143,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fexperimental-new-pass-manager", + "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", @@ -148,6 +153,7 @@ "main.cc", "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -173,6 +179,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fexperimental-new-pass-manager", + "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", @@ -182,6 +189,7 @@ "main.cc", "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -238,6 +246,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fexperimental-new-pass-manager", + "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", @@ -247,6 +256,7 @@ "main.cc", "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -275,6 +285,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fexperimental-new-pass-manager", + "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", @@ -284,6 +295,7 @@ "main.cc", "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -341,6 +353,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fexperimental-new-pass-manager", + "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", @@ -350,6 +363,7 @@ "main.cc", "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -375,6 +389,7 @@ "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", "-fexperimental-new-pass-manager", + "-Wno-compound-token-split-by-macro", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", @@ -384,6 +399,7 @@ "main.cc", "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", -- cgit v1.2.3