From dc996b9cd333b330ca79985a93f9a71995676a71 Mon Sep 17 00:00:00 2001 From: Jian Cai Date: Wed, 17 Jun 2020 15:27:24 -0700 Subject: compiler_wrapper: redirect clang crash dignoses Redirect all diagnoses of clang crashes to a dedicated directory using fcrash-diagnostics-dir so we can upload these files to the cloud. The flag was added to clangPostFlags to overwite redirection done on package level. BUG=chromium:1056904 TEST=None Change-Id: I78bfc77d7f3af8556b4308f2e71407d627627747 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2251038 Reviewed-by: Manoj Gupta Commit-Queue: Jian Cai Tested-by: Jian Cai --- .../testdata/cros_hardened_noccache_golden/bisect.json | 3 +++ .../testdata/cros_hardened_noccache_golden/clang_path.json | 12 ++++++++++++ .../testdata/cros_hardened_noccache_golden/clangtidy.json | 8 ++++++++ .../cros_hardened_noccache_golden/force_disable_werror.json | 5 +++++ .../cros_hardened_noccache_golden/gcc_clang_syntax.json | 4 ++++ 5 files changed, 32 insertions(+) (limited to 'compiler_wrapper/testdata/cros_hardened_noccache_golden') diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/bisect.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/bisect.json index e9bc3661..dfe8c0c0 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/bisect.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/bisect.json @@ -37,6 +37,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -94,6 +95,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -154,6 +156,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/clang_path.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/clang_path.json index c21d6198..c8a0e101 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/clang_path.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/clang_path.json @@ -27,6 +27,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -73,6 +74,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -119,6 +121,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -165,6 +168,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -218,6 +222,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -277,6 +282,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -335,6 +341,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -383,6 +390,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -426,6 +434,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -469,6 +478,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -512,6 +522,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -558,6 +569,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/clangtidy.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/clangtidy.json index 26abab87..b8b786db 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/clangtidy.json @@ -43,6 +43,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -73,6 +74,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -133,6 +135,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -164,6 +167,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -226,6 +230,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -260,6 +265,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -323,6 +329,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -354,6 +361,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/force_disable_werror.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/force_disable_werror.json index ce35f311..9700b128 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/force_disable_werror.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/force_disable_werror.json @@ -30,6 +30,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -76,6 +77,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -108,6 +110,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -158,6 +161,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -190,6 +194,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", diff --git a/compiler_wrapper/testdata/cros_hardened_noccache_golden/gcc_clang_syntax.json b/compiler_wrapper/testdata/cros_hardened_noccache_golden/gcc_clang_syntax.json index f716dde3..3b31be3c 100644 --- a/compiler_wrapper/testdata/cros_hardened_noccache_golden/gcc_clang_syntax.json +++ b/compiler_wrapper/testdata/cros_hardened_noccache_golden/gcc_clang_syntax.json @@ -28,6 +28,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -96,6 +97,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -164,6 +166,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", @@ -216,6 +219,7 @@ "-fuse-ld=lld", "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", + "-fcrash-diagnostics-dir=/tmp/clang_crash_diagnostics", "-fstack-protector-strong", "-fPIE", "-pie", -- cgit v1.2.3