From 58bd94f0cf7bba9b91e24d75e991f098723d81ee Mon Sep 17 00:00:00 2001 From: Manoj Gupta Date: Mon, 9 May 2022 20:21:03 -0700 Subject: compiler_wrapper: Disable warning implicit-function-declaration Wimplicit-function-declaration has been promoted to be an default error even with Wno-error. Disable the error by default since it is breaking a lot of packages. BUG=b:230345382 TEST=cq Change-Id: Ib46b0b47a3e1dea3797739370a4d9cf92a4d25f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3637117 Tested-by: Manoj Gupta Auto-Submit: Manoj Gupta Reviewed-by: George Burgess Commit-Queue: Manoj Gupta --- .../testdata/cros_nonhardened_golden/clangtidy.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json index dc641c96..8a9edab6 100644 --- a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json @@ -42,6 +42,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", + "-Wno-error=implicit-function-declaration", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -51,7 +52,6 @@ "-Wno-compound-token-split-by-space", "-Wno-string-concatenation", "-Wno-deprecated-copy", - "-Wno-unused-but-set-variable", "-mno-movbe", "-B../../bin", "-target", @@ -75,6 +75,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", + "-Wno-error=implicit-function-declaration", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -84,7 +85,6 @@ "-Wno-compound-token-split-by-space", "-Wno-string-concatenation", "-Wno-deprecated-copy", - "-Wno-unused-but-set-variable", "-mno-movbe", "-B../../bin", "-target", @@ -138,6 +138,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", + "-Wno-error=implicit-function-declaration", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -147,7 +148,6 @@ "-Wno-compound-token-split-by-space", "-Wno-string-concatenation", "-Wno-deprecated-copy", - "-Wno-unused-but-set-variable", "-mno-movbe", "-B../../bin", "-target", @@ -172,6 +172,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", + "-Wno-error=implicit-function-declaration", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -181,7 +182,6 @@ "-Wno-compound-token-split-by-space", "-Wno-string-concatenation", "-Wno-deprecated-copy", - "-Wno-unused-but-set-variable", "-mno-movbe", "-B../../bin", "-target", @@ -237,6 +237,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", + "-Wno-error=implicit-function-declaration", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -246,7 +247,6 @@ "-Wno-compound-token-split-by-space", "-Wno-string-concatenation", "-Wno-deprecated-copy", - "-Wno-unused-but-set-variable", "-mno-movbe", "-B../../bin", "-target", @@ -274,6 +274,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", + "-Wno-error=implicit-function-declaration", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -283,7 +284,6 @@ "-Wno-compound-token-split-by-space", "-Wno-string-concatenation", "-Wno-deprecated-copy", - "-Wno-unused-but-set-variable", "-mno-movbe", "-B../../bin", "-target", @@ -340,6 +340,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", + "-Wno-error=implicit-function-declaration", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -349,7 +350,6 @@ "-Wno-compound-token-split-by-space", "-Wno-string-concatenation", "-Wno-deprecated-copy", - "-Wno-unused-but-set-variable", "-mno-movbe", "-B../../bin", "-target", @@ -374,6 +374,7 @@ "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", + "-Wno-error=implicit-function-declaration", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -383,7 +384,6 @@ "-Wno-compound-token-split-by-space", "-Wno-string-concatenation", "-Wno-deprecated-copy", - "-Wno-unused-but-set-variable", "-mno-movbe", "-B../../bin", "-target", -- cgit v1.2.3 From ea4a522b15b2e1b22ad7b97c8b91f0791c426edc Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Tue, 10 May 2022 11:44:23 -0700 Subject: compiler_wrapper: factor clangPostFlags into a function; sort Since order doesn't matter, make this sorted. Otherwise, these are all shared, so no point in repeating them. BUG=b:232114933 TEST=go test Change-Id: Ide3c620de9018fed3fe8d898b21b3d5d4f42700f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639281 Reviewed-by: Jordan Abrahams-Whitehead Commit-Queue: George Burgess Tested-by: George Burgess --- .../cros_nonhardened_golden/clangtidy.json | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-) (limited to 'compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json index 8a9edab6..742e6a3a 100644 --- a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json @@ -48,10 +48,10 @@ "--prefix=../../bin/x86_64-cros-linux-gnu-", "main.cc", "-L/usr/x86_64-cros-linux-gnu/usr/lib64", - "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", - "-Wno-string-concatenation", "-Wno-deprecated-copy", + "-Wno-implicit-int-float-conversion", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -81,10 +81,10 @@ "--prefix=../../bin/x86_64-cros-linux-gnu-", "main.cc", "-L/usr/x86_64-cros-linux-gnu/usr/lib64", - "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", - "-Wno-string-concatenation", "-Wno-deprecated-copy", + "-Wno-implicit-int-float-conversion", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -144,10 +144,10 @@ "--prefix=../../bin/x86_64-cros-linux-gnu-", "main.cc", "-L/usr/x86_64-cros-linux-gnu/usr/lib64", - "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", - "-Wno-string-concatenation", "-Wno-deprecated-copy", + "-Wno-implicit-int-float-conversion", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -178,10 +178,10 @@ "--prefix=../../bin/x86_64-cros-linux-gnu-", "main.cc", "-L/usr/x86_64-cros-linux-gnu/usr/lib64", - "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", - "-Wno-string-concatenation", "-Wno-deprecated-copy", + "-Wno-implicit-int-float-conversion", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -243,10 +243,10 @@ "--prefix=../../bin/x86_64-cros-linux-gnu-", "main.cc", "-L/usr/x86_64-cros-linux-gnu/usr/lib64", - "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", - "-Wno-string-concatenation", "-Wno-deprecated-copy", + "-Wno-implicit-int-float-conversion", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -280,10 +280,10 @@ "--prefix=../../bin/x86_64-cros-linux-gnu-", "main.cc", "-L/usr/x86_64-cros-linux-gnu/usr/lib64", - "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", - "-Wno-string-concatenation", "-Wno-deprecated-copy", + "-Wno-implicit-int-float-conversion", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -346,10 +346,10 @@ "--prefix=../../bin/x86_64-cros-linux-gnu-", "main.cc", "-L/usr/x86_64-cros-linux-gnu/usr/lib64", - "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", - "-Wno-string-concatenation", "-Wno-deprecated-copy", + "-Wno-implicit-int-float-conversion", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", @@ -380,10 +380,10 @@ "--prefix=../../bin/x86_64-cros-linux-gnu-", "main.cc", "-L/usr/x86_64-cros-linux-gnu/usr/lib64", - "-Wno-implicit-int-float-conversion", "-Wno-compound-token-split-by-space", - "-Wno-string-concatenation", "-Wno-deprecated-copy", + "-Wno-implicit-int-float-conversion", + "-Wno-string-concatenation", "-mno-movbe", "-B../../bin", "-target", -- cgit v1.2.3 From 5cab4b87ccc87292502d74a222f4c005bc300ad8 Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Tue, 10 May 2022 11:53:14 -0700 Subject: compiler_wrapper: sort clangFlags; partition for dedup This CL sorts clang flags, and puts ones shared across all CrOS configurations into their own textual blocks. This should make factoring these out into their own function not require golden updates, which makes verifying the CL that actually _does_ that simpler. BUG=b:232114933 TEST=go test Change-Id: I7dc6110d680505d4ad2af98709730e85c386ae5d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3639682 Reviewed-by: Jordan Abrahams-Whitehead Tested-by: George Burgess Commit-Queue: George Burgess --- .../cros_nonhardened_golden/clangtidy.json | 112 ++++++++++----------- 1 file changed, 56 insertions(+), 56 deletions(-) (limited to 'compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json index 742e6a3a..3bb4a8aa 100644 --- a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json @@ -32,17 +32,17 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-fdebug-default-version=5", - "-Wno-tautological-constant-compare", - "-Wno-tautological-unsigned-enum-zero-compare", - "-Wno-unknown-warning-option", - "-Wno-section", - "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-final-dtor-non-final-class", + "-Wno-tautological-constant-compare", + "-Wno-tautological-unsigned-enum-zero-compare", + "-Wno-unknown-warning-option", + "-fdebug-default-version=5", + "-fexperimental-new-pass-manager", + "-Wno-section", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -65,17 +65,17 @@ "args": [ "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-fdebug-default-version=5", - "-Wno-tautological-constant-compare", - "-Wno-tautological-unsigned-enum-zero-compare", - "-Wno-unknown-warning-option", - "-Wno-section", - "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-final-dtor-non-final-class", + "-Wno-tautological-constant-compare", + "-Wno-tautological-unsigned-enum-zero-compare", + "-Wno-unknown-warning-option", + "-fdebug-default-version=5", + "-fexperimental-new-pass-manager", + "-Wno-section", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -128,17 +128,17 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-fdebug-default-version=5", - "-Wno-tautological-constant-compare", - "-Wno-tautological-unsigned-enum-zero-compare", - "-Wno-unknown-warning-option", - "-Wno-section", - "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-final-dtor-non-final-class", + "-Wno-tautological-constant-compare", + "-Wno-tautological-unsigned-enum-zero-compare", + "-Wno-unknown-warning-option", + "-fdebug-default-version=5", + "-fexperimental-new-pass-manager", + "-Wno-section", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -162,17 +162,17 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-fdebug-default-version=5", - "-Wno-tautological-constant-compare", - "-Wno-tautological-unsigned-enum-zero-compare", - "-Wno-unknown-warning-option", - "-Wno-section", - "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-final-dtor-non-final-class", + "-Wno-tautological-constant-compare", + "-Wno-tautological-unsigned-enum-zero-compare", + "-Wno-unknown-warning-option", + "-fdebug-default-version=5", + "-fexperimental-new-pass-manager", + "-Wno-section", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -227,17 +227,17 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-fdebug-default-version=5", - "-Wno-tautological-constant-compare", - "-Wno-tautological-unsigned-enum-zero-compare", - "-Wno-unknown-warning-option", - "-Wno-section", - "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-final-dtor-non-final-class", + "-Wno-tautological-constant-compare", + "-Wno-tautological-unsigned-enum-zero-compare", + "-Wno-unknown-warning-option", + "-fdebug-default-version=5", + "-fexperimental-new-pass-manager", + "-Wno-section", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -264,17 +264,17 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-fdebug-default-version=5", - "-Wno-tautological-constant-compare", - "-Wno-tautological-unsigned-enum-zero-compare", - "-Wno-unknown-warning-option", - "-Wno-section", - "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-final-dtor-non-final-class", + "-Wno-tautological-constant-compare", + "-Wno-tautological-unsigned-enum-zero-compare", + "-Wno-unknown-warning-option", + "-fdebug-default-version=5", + "-fexperimental-new-pass-manager", + "-Wno-section", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -330,17 +330,17 @@ "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-fdebug-default-version=5", - "-Wno-tautological-constant-compare", - "-Wno-tautological-unsigned-enum-zero-compare", - "-Wno-unknown-warning-option", - "-Wno-section", - "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-final-dtor-non-final-class", + "-Wno-tautological-constant-compare", + "-Wno-tautological-unsigned-enum-zero-compare", + "-Wno-unknown-warning-option", + "-fdebug-default-version=5", + "-fexperimental-new-pass-manager", + "-Wno-section", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", @@ -364,17 +364,17 @@ "../../usr/bin/clang", "--sysroot=/usr/x86_64-cros-linux-gnu", "-Qunused-arguments", - "-fdebug-default-version=5", - "-Wno-tautological-constant-compare", - "-Wno-tautological-unsigned-enum-zero-compare", - "-Wno-unknown-warning-option", - "-Wno-section", - "-Wno-final-dtor-non-final-class", "-Werror=poison-system-directories", - "-fexperimental-new-pass-manager", "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-final-dtor-non-final-class", + "-Wno-tautological-constant-compare", + "-Wno-tautological-unsigned-enum-zero-compare", + "-Wno-unknown-warning-option", + "-fdebug-default-version=5", + "-fexperimental-new-pass-manager", + "-Wno-section", "-fcrash-diagnostics-dir=/tmp/stable/clang_crash_diagnostics", "-static-libgcc", "--prefix=../../bin/x86_64-cros-linux-gnu-", -- cgit v1.2.3 From 76b677b89b385083ab2b243308e745abb6b4261c Mon Sep 17 00:00:00 2001 From: Manoj Gupta Date: Wed, 11 May 2022 11:59:37 -0700 Subject: compiler_wrapper: Disable warning implicit-int Wimplicit-int has been promoted to be an default error even with Wno-error. Disable the error by default since it is breaking a lot of packages. BUG=b:231987783 TEST=cq Change-Id: If88877cb63cdd5c392fcf05c2940751547466213 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3642338 Tested-by: Manoj Gupta Reviewed-by: George Burgess Commit-Queue: George Burgess Auto-Submit: Manoj Gupta --- compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json index 3bb4a8aa..30f9466d 100644 --- a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json @@ -36,6 +36,7 @@ "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-error=implicit-int", "-Wno-final-dtor-non-final-class", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", @@ -69,6 +70,7 @@ "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-error=implicit-int", "-Wno-final-dtor-non-final-class", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", @@ -132,6 +134,7 @@ "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-error=implicit-int", "-Wno-final-dtor-non-final-class", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", @@ -166,6 +169,7 @@ "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-error=implicit-int", "-Wno-final-dtor-non-final-class", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", @@ -231,6 +235,7 @@ "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-error=implicit-int", "-Wno-final-dtor-non-final-class", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", @@ -268,6 +273,7 @@ "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-error=implicit-int", "-Wno-final-dtor-non-final-class", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", @@ -334,6 +340,7 @@ "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-error=implicit-int", "-Wno-final-dtor-non-final-class", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", @@ -368,6 +375,7 @@ "-Wno-compound-token-split-by-macro", "-Wno-deprecated-declarations", "-Wno-error=implicit-function-declaration", + "-Wno-error=implicit-int", "-Wno-final-dtor-non-final-class", "-Wno-tautological-constant-compare", "-Wno-tautological-unsigned-enum-zero-compare", -- cgit v1.2.3 From 0665748ca334615e7f41978c36b8fba7817ed2c7 Mon Sep 17 00:00:00 2001 From: Ryan Beltran Date: Thu, 1 Sep 2022 17:51:48 +0000 Subject: compiler_wrapper: redisable unused-but-set-var This CL add the Wno-unused-but-set-variable flag back into the compiler wrapper. It was previously removed, but there are still occurances of the warning and so we were never able to bundle that change into chromoumos-overlay/llvm. An attempt to revert the original CL failed due to a merge conflict. BUG=b:227655984 TEST=None Change-Id: Ic148a6ae577d5e4394249693ce9b09b95cb9df16 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3868978 Commit-Queue: Ryan Beltran Reviewed-by: George Burgess Tested-by: Ryan Beltran Reviewed-by: Manoj Gupta --- compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json index 30f9466d..830abee6 100644 --- a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json @@ -51,6 +51,7 @@ "-L/usr/x86_64-cros-linux-gnu/usr/lib64", "-Wno-compound-token-split-by-space", "-Wno-deprecated-copy", + "-Wno-unused-but-set-variable", "-Wno-implicit-int-float-conversion", "-Wno-string-concatenation", "-mno-movbe", @@ -85,6 +86,7 @@ "-L/usr/x86_64-cros-linux-gnu/usr/lib64", "-Wno-compound-token-split-by-space", "-Wno-deprecated-copy", + "-Wno-unused-but-set-variable", "-Wno-implicit-int-float-conversion", "-Wno-string-concatenation", "-mno-movbe", @@ -149,6 +151,7 @@ "-L/usr/x86_64-cros-linux-gnu/usr/lib64", "-Wno-compound-token-split-by-space", "-Wno-deprecated-copy", + "-Wno-unused-but-set-variable", "-Wno-implicit-int-float-conversion", "-Wno-string-concatenation", "-mno-movbe", @@ -184,6 +187,7 @@ "-L/usr/x86_64-cros-linux-gnu/usr/lib64", "-Wno-compound-token-split-by-space", "-Wno-deprecated-copy", + "-Wno-unused-but-set-variable", "-Wno-implicit-int-float-conversion", "-Wno-string-concatenation", "-mno-movbe", @@ -250,6 +254,7 @@ "-L/usr/x86_64-cros-linux-gnu/usr/lib64", "-Wno-compound-token-split-by-space", "-Wno-deprecated-copy", + "-Wno-unused-but-set-variable", "-Wno-implicit-int-float-conversion", "-Wno-string-concatenation", "-mno-movbe", @@ -288,6 +293,7 @@ "-L/usr/x86_64-cros-linux-gnu/usr/lib64", "-Wno-compound-token-split-by-space", "-Wno-deprecated-copy", + "-Wno-unused-but-set-variable", "-Wno-implicit-int-float-conversion", "-Wno-string-concatenation", "-mno-movbe", @@ -355,6 +361,7 @@ "-L/usr/x86_64-cros-linux-gnu/usr/lib64", "-Wno-compound-token-split-by-space", "-Wno-deprecated-copy", + "-Wno-unused-but-set-variable", "-Wno-implicit-int-float-conversion", "-Wno-string-concatenation", "-mno-movbe", @@ -390,6 +397,7 @@ "-L/usr/x86_64-cros-linux-gnu/usr/lib64", "-Wno-compound-token-split-by-space", "-Wno-deprecated-copy", + "-Wno-unused-but-set-variable", "-Wno-implicit-int-float-conversion", "-Wno-string-concatenation", "-mno-movbe", -- cgit v1.2.3 From 6b285afc5e9caadeb6741efe872981ffdbb3bfe1 Mon Sep 17 00:00:00 2001 From: Christopher Di Bella Date: Tue, 9 Aug 2022 23:46:12 +0000 Subject: compiler-wrapper: adds an IWYU component This first patch makes it possible to run IWYU as a part of the build process. It's not currently possible for us to make changes to packages: this functionality will appear in a later CL. BUG=b:237320348 TEST=Tested locally Change-Id: I00610284143cf478b242b2c0ca1c05e2c8d43de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3820351 Reviewed-by: Ryan Beltran Auto-Submit: Christopher Di Bella Commit-Queue: Ryan Beltran Tested-by: Christopher Di Bella --- compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json index 830abee6..3d5078df 100644 --- a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json @@ -27,7 +27,7 @@ "path": "../../usr/bin/clang-tidy", "args": [ "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", - "main.cc", + "", "--", "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", @@ -127,7 +127,7 @@ "path": "../../usr/bin/clang-tidy", "args": [ "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", - "main.cc", + "", "--", "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", @@ -230,7 +230,7 @@ "path": "../../usr/bin/clang-tidy", "args": [ "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", - "main.cc", + "", "--", "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", @@ -337,7 +337,7 @@ "path": "../../usr/bin/clang-tidy", "args": [ "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", - "main.cc", + "", "--", "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", -- cgit v1.2.3 From 537f2ecfe7bc9eb996cd4abedae26bf699ab54dd Mon Sep 17 00:00:00 2001 From: Manoj Gupta Date: Tue, 1 Nov 2022 17:48:50 +0000 Subject: Revert "compiler-wrapper: adds an IWYU component" This reverts commit 6b285afc5e9caadeb6741efe872981ffdbb3bfe1. Reason for revert: Likely erroneous change. Original change's description: > compiler-wrapper: adds an IWYU component > > This first patch makes it possible to run IWYU as a part of the build > process. It's not currently possible for us to make changes to packages: > this functionality will appear in a later CL. > > BUG=b:237320348 > TEST=Tested locally > > Change-Id: I00610284143cf478b242b2c0ca1c05e2c8d43de4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3820351 > Reviewed-by: Ryan Beltran > Auto-Submit: Christopher Di Bella > Commit-Queue: Ryan Beltran > Tested-by: Christopher Di Bella Bug: b:237320348 Change-Id: Ia563382c3302b2a4c69942db95d315088763f97c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3995401 Auto-Submit: Manoj Gupta Commit-Queue: Ryan Beltran Commit-Queue: Rubber Stamper Bot-Commit: Rubber Stamper Reviewed-by: Ryan Beltran --- compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json') diff --git a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json index 3d5078df..830abee6 100644 --- a/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json +++ b/compiler_wrapper/testdata/cros_nonhardened_golden/clangtidy.json @@ -27,7 +27,7 @@ "path": "../../usr/bin/clang-tidy", "args": [ "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", - "", + "main.cc", "--", "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", @@ -127,7 +127,7 @@ "path": "../../usr/bin/clang-tidy", "args": [ "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", - "", + "main.cc", "--", "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", @@ -230,7 +230,7 @@ "path": "../../usr/bin/clang-tidy", "args": [ "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", - "", + "main.cc", "--", "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", @@ -337,7 +337,7 @@ "path": "../../usr/bin/clang-tidy", "args": [ "-checks=*,-bugprone-narrowing-conversions,-cppcoreguidelines-*,-fuchsia-*,-google-readability*,-google-runtime-references,-hicpp-*,-llvm-*,-misc-non-private-member-variables-in-classes,-misc-unused-parameters,-modernize-*,-readability-*", - "", + "main.cc", "--", "-resource-dir=someResourceDir", "--sysroot=/usr/x86_64-cros-linux-gnu", -- cgit v1.2.3