From 036c9233742004aa773a374df381b1cf137484f5 Mon Sep 17 00:00:00 2001 From: Luis Lozano Date: Thu, 10 Dec 2015 10:47:01 -0800 Subject: crosperf: RunCommand should return one type of object. Cleaned up the interfaces for the RunCommand routines. These were returning different types (int or tuple) depending on the value of the return_ouput parameter. Returning different unrelated types from a routine is bad practice. Linter complains about this with several warnings like this: "Attempting to unpack a non-sequence defined at line XY of utils.command_executer" BUG=chromium:566256 TEST=ran crosperf with a example experiment file Ran run_tests. Change-Id: Ibb83ab9322c87558077fc4937ef5c0686bbe5417 Reviewed-on: https://chrome-internal-review.googlesource.com/241459 Commit-Ready: Luis Lozano Tested-by: Luis Lozano Reviewed-by: Han Shen --- crosperf/download_images.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crosperf/download_images.py') diff --git a/crosperf/download_images.py b/crosperf/download_images.py index 72f3fb04..8fecf8b3 100644 --- a/crosperf/download_images.py +++ b/crosperf/download_images.py @@ -28,8 +28,8 @@ class ImageDownloader(object): # image name. command = ("cd ~/trunk/src/third_party/toolchain-utils/crosperf; " "python translate_xbuddy.py '%s'" % xbuddy_label) - retval, build_id_tuple_str, _ = self._ce.ChrootRunCommand(chromeos_root, - command, True) + retval, build_id_tuple_str, _ = self._ce.ChrootRunCommandWOutput( + chromeos_root, command) if not build_id_tuple_str: raise MissingImage ("Unable to find image for '%s'" % xbuddy_label) -- cgit v1.2.3