From 2844e62d0405e009f4a57093eedab9c37416e54c Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Thu, 28 Jan 2021 12:40:22 -0800 Subject: llvm_tools: make the lexan 4c uploader ignore old clang(s) Lexan saw a crash from clang 9.0.0 uploaded to their bucket. There's ~nothing we care to do about these crashes, and 4c even fails to parse the header of them. Seems best to warn & ignore these cases automatically (if an actual _user_ wants this functionality, 4c can easily be fixed, but I doubt anyone cares) No test is provided since submit_test_case has quite a few side-effects. Doesn't seem worth splitting it or mocking a lot to add an automated test for this peephole. BUG=None TEST=manually ran on chrotomation Change-Id: Iae131913e7b9494015262e41af8ad4193c9d62f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2657875 Reviewed-by: Manoj Gupta Tested-by: George Burgess --- llvm_tools/upload_lexan_crashes_to_forcey_test.py | 24 +++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'llvm_tools/upload_lexan_crashes_to_forcey_test.py') diff --git a/llvm_tools/upload_lexan_crashes_to_forcey_test.py b/llvm_tools/upload_lexan_crashes_to_forcey_test.py index 3c9c0d4b..937cbf8e 100755 --- a/llvm_tools/upload_lexan_crashes_to_forcey_test.py +++ b/llvm_tools/upload_lexan_crashes_to_forcey_test.py @@ -7,6 +7,7 @@ """Tests for upload_lexan_crashes_to_forcey.""" import datetime +import os import unittest import unittest.mock @@ -117,6 +118,29 @@ class Test(unittest.TestCase): ), ]) + @unittest.mock.patch( + 'upload_lexan_crashes_to_forcey.download_and_unpack_test_case') + @unittest.mock.patch('subprocess.run') + def test_test_case_submission_functions(self, subprocess_run_mock, + download_and_unpack_mock): + mock_gs_url = 'gs://foo/bar/baz' + + def side_effect(gs_url: str, tempdir: str) -> None: + self.assertEqual(gs_url, mock_gs_url) + + with open(os.path.join(tempdir, 'test_case.c'), 'w') as f: + # All we need is an empty file here. + pass + + with open( + os.path.join(tempdir, 'test_case.sh'), 'w', encoding='utf-8') as f: + f.write('# Crash reproducer for clang version 9.0.0 (...)\n') + f.write('clang something or other\n') + + download_and_unpack_mock.side_effect = side_effect + upload_lexan_crashes_to_forcey.submit_test_case(mock_gs_url, '4c') + subprocess_run_mock.assert_not_called() + if __name__ == '__main__': unittest.main() -- cgit v1.2.3