1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
|
// Copyright 2019 The Chromium OS Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
package main
import (
"bytes"
"encoding/json"
"io"
"io/ioutil"
"os"
"strings"
"syscall"
)
const numWErrorEstimate = 30
func shouldForceDisableWerror(env env, cfg *config) bool {
if cfg.isAndroidWrapper {
return cfg.useLlvmNext
}
value, _ := env.getenv("FORCE_DISABLE_WERROR")
return value != ""
}
func disableWerrorFlags(originalArgs []string) []string {
extraArgs := []string{"-Wno-error"}
newArgs := make([]string, 0, len(originalArgs)+numWErrorEstimate)
for _, flag := range originalArgs {
if strings.HasPrefix(flag, "-Werror=") {
extraArgs = append(extraArgs, strings.Replace(flag, "-Werror", "-Wno-error", 1))
}
if !strings.Contains(flag, "-warnings-as-errors") {
newArgs = append(newArgs, flag)
}
}
return append(newArgs, extraArgs...)
}
func isLikelyAConfTest(cfg *config, cmd *command) bool {
// Android doesn't do mid-build `configure`s, so we don't need to worry about this there.
if cfg.isAndroidWrapper {
return false
}
for _, a := range cmd.Args {
// The kernel, for example, will do configure tests with /dev/null as a source file.
if a == "/dev/null" || strings.HasPrefix(a, "conftest.c") {
return true
}
}
return false
}
func doubleBuildWithWNoError(env env, cfg *config, originalCmd *command) (exitCode int, err error) {
originalStdoutBuffer := &bytes.Buffer{}
originalStderrBuffer := &bytes.Buffer{}
// TODO: This is a bug in the old wrapper that it drops the ccache path
// during double build. Fix this once we don't compare to the old wrapper anymore.
if originalCmd.Path == "/usr/bin/ccache" {
originalCmd.Path = "ccache"
}
getStdin, err := prebufferStdinIfNeeded(env, originalCmd)
if err != nil {
return 0, wrapErrorwithSourceLocf(err, "prebuffering stdin: %v", err)
}
originalExitCode, err := wrapSubprocessErrorWithSourceLoc(originalCmd,
env.run(originalCmd, getStdin(), originalStdoutBuffer, originalStderrBuffer))
if err != nil {
return 0, err
}
// The only way we can do anything useful is if it looks like the failure
// was -Werror-related.
originalStdoutBufferBytes := originalStdoutBuffer.Bytes()
shouldRetry := originalExitCode != 0 &&
!isLikelyAConfTest(cfg, originalCmd) &&
(bytes.Contains(originalStderrBuffer.Bytes(), []byte("-Werror")) ||
bytes.Contains(originalStdoutBufferBytes, []byte("warnings-as-errors")) ||
bytes.Contains(originalStdoutBufferBytes, []byte("clang-diagnostic-")))
if !shouldRetry {
originalStdoutBuffer.WriteTo(env.stdout())
originalStderrBuffer.WriteTo(env.stderr())
return originalExitCode, nil
}
retryStdoutBuffer := &bytes.Buffer{}
retryStderrBuffer := &bytes.Buffer{}
retryCommand := &command{
Path: originalCmd.Path,
Args: disableWerrorFlags(originalCmd.Args),
EnvUpdates: originalCmd.EnvUpdates,
}
retryExitCode, err := wrapSubprocessErrorWithSourceLoc(retryCommand,
env.run(retryCommand, getStdin(), retryStdoutBuffer, retryStderrBuffer))
if err != nil {
return 0, err
}
// If -Wno-error fixed us, pretend that we never ran without -Wno-error. Otherwise, pretend
// that we never ran the second invocation.
if retryExitCode != 0 {
originalStdoutBuffer.WriteTo(env.stdout())
originalStderrBuffer.WriteTo(env.stderr())
return originalExitCode, nil
}
retryStdoutBuffer.WriteTo(env.stdout())
retryStderrBuffer.WriteTo(env.stderr())
lines := []string{}
if originalStderrBuffer.Len() > 0 {
lines = append(lines, originalStderrBuffer.String())
}
if originalStdoutBuffer.Len() > 0 {
lines = append(lines, originalStdoutBuffer.String())
}
outputToLog := strings.Join(lines, "\n")
jsonData := warningsJSONData{
Cwd: env.getwd(),
Command: append([]string{originalCmd.Path}, originalCmd.Args...),
Stdout: outputToLog,
}
// Write warning report to stdout for Android. On Android,
// double-build can be requested on remote builds as well, where there
// is no canonical place to write the warnings report.
if cfg.isAndroidWrapper {
stdout := env.stdout()
io.WriteString(stdout, "<LLVM_NEXT_ERROR_REPORT>")
if err := json.NewEncoder(stdout).Encode(jsonData); err != nil {
return 0, wrapErrorwithSourceLocf(err, "error in json.Marshal")
}
io.WriteString(stdout, "</LLVM_NEXT_ERROR_REPORT>")
return retryExitCode, nil
}
// All of the below is basically logging. If we fail at any point, it's
// reasonable for that to fail the build. This is all meant for FYI-like
// builders in the first place.
// Buildbots use a nonzero umask, which isn't quite what we want: these directories should
// be world-readable and world-writable.
oldMask := syscall.Umask(0)
defer syscall.Umask(oldMask)
// Allow root and regular users to write to this without issue.
if err := os.MkdirAll(cfg.newWarningsDir, 0777); err != nil {
return 0, wrapErrorwithSourceLocf(err, "error creating warnings directory %s", cfg.newWarningsDir)
}
// Have some tag to show that files aren't fully written. It would be sad if
// an interrupted build (or out of disk space, or similar) caused tools to
// have to be overly-defensive.
incompleteSuffix := ".incomplete"
// Coming up with a consistent name for this is difficult (compiler command's
// SHA can clash in the case of identically named files in different
// directories, or similar); let's use a random one.
tmpFile, err := ioutil.TempFile(cfg.newWarningsDir, "warnings_report*.json"+incompleteSuffix)
if err != nil {
return 0, wrapErrorwithSourceLocf(err, "error creating warnings file")
}
if err := tmpFile.Chmod(0666); err != nil {
return 0, wrapErrorwithSourceLocf(err, "error chmoding the file to be world-readable/writeable")
}
enc := json.NewEncoder(tmpFile)
if err := enc.Encode(jsonData); err != nil {
_ = tmpFile.Close()
return 0, wrapErrorwithSourceLocf(err, "error writing warnings data")
}
if err := tmpFile.Close(); err != nil {
return 0, wrapErrorwithSourceLocf(err, "error closing warnings file")
}
if err := os.Rename(tmpFile.Name(), tmpFile.Name()[:len(tmpFile.Name())-len(incompleteSuffix)]); err != nil {
return 0, wrapErrorwithSourceLocf(err, "error removing incomplete suffix from warnings file")
}
return retryExitCode, nil
}
// Struct used to write JSON. Fileds have to be uppercase for the json
// encoder to read them.
type warningsJSONData struct {
Cwd string `json:"cwd"`
Command []string `json:"command"`
Stdout string `json:"stdout"`
}
|
