1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
|
package main
import (
"encoding/json"
"errors"
"fmt"
"io"
"io/ioutil"
"os"
"path/filepath"
"strings"
"testing"
)
func TestOmitDoubleBuildForSuccessfulCall(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.must(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
if ctx.cmdCount != 1 {
t.Errorf("expected 1 call. Got: %d", ctx.cmdCount)
}
})
}
func TestOmitDoubleBuildForGeneralError(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.cmdMock = func(cmd *command, stdout io.Writer, stderr io.Writer) error {
return errors.New("someerror")
}
stderr := ctx.mustFail(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
if err := verifyInternalError(stderr); err != nil {
t.Fatal(err)
}
if !strings.Contains(stderr, "someerror") {
t.Errorf("unexpected error. Got: %s", stderr)
}
if ctx.cmdCount != 1 {
t.Errorf("expected 1 call. Got: %d", ctx.cmdCount)
}
})
}
func TestDoubleBuildWithWNoErrorFlag(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.cmdMock = func(cmd *command, stdout io.Writer, stderr io.Writer) error {
switch ctx.cmdCount {
case 1:
if err := verifyArgCount(cmd, 0, "-Wno-error"); err != nil {
return err
}
fmt.Fprint(stderr, "-Werror originalerror")
return newExitCodeError(1)
case 2:
if err := verifyArgCount(cmd, 1, "-Wno-error"); err != nil {
return err
}
return nil
default:
t.Fatalf("unexpected command: %#v", cmd)
return nil
}
}
ctx.must(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
if ctx.cmdCount != 2 {
t.Errorf("expected 2 calls. Got: %d", ctx.cmdCount)
}
})
}
func TestDoubleBuildWithWNoErrorAndCCache(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.cfg.useCCache = true
ctx.cmdMock = func(cmd *command, stdout io.Writer, stderr io.Writer) error {
switch ctx.cmdCount {
case 1:
// TODO: This is a bug in the old wrapper that it drops the ccache path
// during double build. Fix this once we don't compare to the old wrapper anymore.
if err := verifyPath(cmd, "ccache"); err != nil {
return err
}
fmt.Fprint(stderr, "-Werror originalerror")
return newExitCodeError(1)
case 2:
if err := verifyPath(cmd, "ccache"); err != nil {
return err
}
return nil
default:
t.Fatalf("unexpected command: %#v", cmd)
return nil
}
}
ctx.must(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
if ctx.cmdCount != 2 {
t.Errorf("expected 2 calls. Got: %d", ctx.cmdCount)
}
})
}
func TestForwardStdoutAndStderrWhenDoubleBuildSucceeds(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.cmdMock = func(cmd *command, stdout io.Writer, stderr io.Writer) error {
switch ctx.cmdCount {
case 1:
fmt.Fprint(stdout, "originalmessage")
fmt.Fprint(stderr, "-Werror originalerror")
return newExitCodeError(1)
case 2:
fmt.Fprint(stdout, "retrymessage")
fmt.Fprint(stderr, "retryerror")
return nil
default:
t.Fatalf("unexpected command: %#v", cmd)
return nil
}
}
ctx.must(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
if err := verifyNonInternalError(ctx.stderrString(), "retryerror"); err != nil {
t.Error(err)
}
if !strings.Contains(ctx.stdoutString(), "retrymessage") {
t.Errorf("unexpected stdout. Got: %s", ctx.stdoutString())
}
})
}
func TestForwardStdoutAndStderrWhenDoubleBuildFails(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.cmdMock = func(cmd *command, stdout io.Writer, stderr io.Writer) error {
switch ctx.cmdCount {
case 1:
fmt.Fprint(stdout, "originalmessage")
fmt.Fprint(stderr, "-Werror originalerror")
return newExitCodeError(3)
case 2:
fmt.Fprint(stdout, "retrymessage")
fmt.Fprint(stderr, "retryerror")
return newExitCodeError(5)
default:
t.Fatalf("unexpected command: %#v", cmd)
return nil
}
}
exitCode := callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc))
if exitCode != 5 {
t.Errorf("unexpected exitcode. Got: %d", exitCode)
}
if err := verifyNonInternalError(ctx.stderrString(), "-Werror originalerror"); err != nil {
t.Error(err)
}
if !strings.Contains(ctx.stdoutString(), "originalmessage") {
t.Errorf("unexpected stdout. Got: %s", ctx.stdoutString())
}
})
}
func TestForwardGeneralErrorWhenDoubleBuildFails(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.cmdMock = func(cmd *command, stdout io.Writer, stderr io.Writer) error {
switch ctx.cmdCount {
case 1:
fmt.Fprint(stderr, "-Werror originalerror")
return newExitCodeError(3)
case 2:
return errors.New("someerror")
default:
t.Fatalf("unexpected command: %#v", cmd)
return nil
}
}
stderr := ctx.mustFail(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
if err := verifyInternalError(stderr); err != nil {
t.Error(err)
}
if !strings.Contains(stderr, "someerror") {
t.Errorf("unexpected stderr. Got: %s", stderr)
}
})
}
func TestOmitLogWarningsIfNoDoubleBuild(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.must(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
if ctx.cmdCount != 1 {
t.Errorf("expected 1 call. Got: %d", ctx.cmdCount)
}
if loggedWarnings := readLoggedWarnings(ctx); loggedWarnings != nil {
t.Errorf("expected no logged warnings. Got: %#v", loggedWarnings)
}
})
}
func TestLogWarningsWhenDoubleBuildSucceeds(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.cmdMock = func(cmd *command, stdout io.Writer, stderr io.Writer) error {
switch ctx.cmdCount {
case 1:
fmt.Fprint(stdout, "originalmessage")
fmt.Fprint(stderr, "-Werror originalerror")
return newExitCodeError(1)
case 2:
fmt.Fprint(stdout, "retrymessage")
fmt.Fprint(stderr, "retryerror")
return nil
default:
t.Fatalf("unexpected command: %#v", cmd)
return nil
}
}
ctx.must(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
loggedWarnings := readLoggedWarnings(ctx)
if loggedWarnings == nil {
t.Fatal("expected logged warnings")
}
if loggedWarnings.Cwd != ctx.getwd() {
t.Fatalf("unexpected cwd. Got: %s", loggedWarnings.Cwd)
}
loggedCmd := &command{
Path: loggedWarnings.Command[0],
Args: loggedWarnings.Command[1:],
}
if err := verifyPath(loggedCmd, "usr/bin/clang"); err != nil {
t.Error(err)
}
if err := verifyArgOrder(loggedCmd, "--sysroot=.*", mainCc); err != nil {
t.Error(err)
}
})
}
func TestLogWarningsWhenDoubleBuildFails(t *testing.T) {
withForceDisableWErrorTestContext(t, func(ctx *testContext) {
ctx.cmdMock = func(cmd *command, stdout io.Writer, stderr io.Writer) error {
switch ctx.cmdCount {
case 1:
fmt.Fprint(stdout, "originalmessage")
fmt.Fprint(stderr, "-Werror originalerror")
return newExitCodeError(1)
case 2:
fmt.Fprint(stdout, "retrymessage")
fmt.Fprint(stderr, "retryerror")
return newExitCodeError(1)
default:
t.Fatalf("unexpected command: %#v", cmd)
return nil
}
}
ctx.mustFail(callCompiler(ctx, ctx.cfg, ctx.newCommand(clangX86_64, mainCc)))
loggedWarnings := readLoggedWarnings(ctx)
if loggedWarnings == nil {
t.Fatal("expected logged warnings")
}
})
}
func withForceDisableWErrorTestContext(t *testing.T, work func(ctx *testContext)) {
withTestContext(t, func(ctx *testContext) {
ctx.env = []string{"FORCE_DISABLE_WERROR=1"}
work(ctx)
})
}
func readLoggedWarnings(ctx *testContext) *warningsJSONData {
files, err := ioutil.ReadDir(ctx.cfg.newWarningsDir)
if err != nil {
if _, ok := err.(*os.PathError); ok {
return nil
}
ctx.t.Fatal(err)
}
if len(files) != 1 {
ctx.t.Fatalf("expected 1 warning log file. Got: %s", files)
}
data, err := ioutil.ReadFile(filepath.Join(ctx.cfg.newWarningsDir, files[0].Name()))
if err != nil {
ctx.t.Fatal(err)
}
jsonData := warningsJSONData{}
if err := json.Unmarshal(data, &jsonData); err != nil {
ctx.t.Fatal(err)
}
return &jsonData
}
|
