1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
|
package main
import (
"bytes"
"fmt"
"io"
"io/ioutil"
"os"
"path/filepath"
"reflect"
"regexp"
"sort"
"strings"
"text/template"
)
const forwardToOldWrapperFilePattern = "old_wrapper_forward"
const compareToOldWrapperFilePattern = "old_wrapper_compare"
// Whether the command should be executed by the old wrapper as we don't
// support it yet.
func shouldForwardToOldWrapper(env env, inputCmd *command) bool {
switch {
case env.getenv("GETRUSAGE") != "":
fallthrough
case env.getenv("BISECT_STAGE") != "":
return true
}
return false
}
func forwardToOldWrapper(env env, cfg *config, inputCmd *command) (exitCode int, err error) {
oldWrapperCfg, err := newOldWrapperConfig(env, cfg, inputCmd)
if err != nil {
return 0, err
}
return callOldWrapper(env, oldWrapperCfg, inputCmd, forwardToOldWrapperFilePattern, env.stdout(), env.stderr())
}
func compareToOldWrapper(env env, cfg *config, inputCmd *command, newCmdResults []*commandResult, newExitCode int) error {
oldWrapperCfg, err := newOldWrapperConfig(env, cfg, inputCmd)
if err != nil {
return err
}
oldWrapperCfg.LogCmds = true
oldWrapperCfg.MockCmds = cfg.mockOldWrapperCmds
newCmds := []*command{}
for _, cmdResult := range newCmdResults {
oldWrapperCfg.CmdResults = append(oldWrapperCfg.CmdResults, oldWrapperCmdResult{
Stdout: cmdResult.stdout,
Stderr: cmdResult.stderr,
Exitcode: cmdResult.exitCode,
})
newCmds = append(newCmds, cmdResult.cmd)
}
oldWrapperCfg.OverwriteConfig = cfg.overwriteOldWrapperCfg
stderrBuffer := bytes.Buffer{}
oldExitCode, err := callOldWrapper(env, oldWrapperCfg, inputCmd, compareToOldWrapperFilePattern, &bytes.Buffer{}, &stderrBuffer)
if err != nil {
return err
}
differences := []string{}
if oldExitCode != newExitCode {
differences = append(differences, fmt.Sprintf("exit codes differ: old %d, new %d", oldExitCode, newExitCode))
}
oldCmds, stderr := parseOldWrapperCommands(stderrBuffer.String())
if cmdDifferences := diffCommands(oldCmds, newCmds); cmdDifferences != "" {
differences = append(differences, cmdDifferences)
}
if len(differences) > 0 {
return newErrorwithSourceLocf("wrappers differ:\n%s\nOld stderr:%s",
strings.Join(differences, "\n"),
stderr,
)
}
return nil
}
func parseOldWrapperCommands(stderr string) (cmds []*command, remainingStderr string) {
allStderrLines := strings.Split(stderr, "\n")
remainingStderrLines := []string{}
for _, line := range allStderrLines {
const commandPrefix = "command:"
const envupdatePrefix = ".EnvUpdate:"
envUpdateIdx := strings.Index(line, envupdatePrefix)
if strings.Index(line, commandPrefix) == 0 {
if envUpdateIdx == -1 {
envUpdateIdx = len(line) - 1
}
args := strings.Fields(line[len(commandPrefix):envUpdateIdx])
envUpdateStr := line[envUpdateIdx+len(envupdatePrefix):]
envUpdate := strings.Fields(envUpdateStr)
if len(envUpdate) == 0 {
// normalize empty slice to nil to make comparing empty envUpdates
// simpler.
envUpdate = nil
}
cmd := &command{
path: args[0],
args: args[1:],
envUpdates: envUpdate,
}
cmds = append(cmds, cmd)
} else {
remainingStderrLines = append(remainingStderrLines, line)
}
}
remainingStderr = strings.TrimSpace(strings.Join(remainingStderrLines, "\n"))
return cmds, remainingStderr
}
func diffCommands(oldCmds []*command, newCmds []*command) string {
maxLen := len(newCmds)
if maxLen < len(oldCmds) {
maxLen = len(oldCmds)
}
hasDifferences := false
var cmdDifferences []string
for i := 0; i < maxLen; i++ {
var differences []string
if i >= len(newCmds) {
differences = append(differences, "missing command")
} else if i >= len(oldCmds) {
differences = append(differences, "extra command")
} else {
newCmd := newCmds[i]
oldCmd := oldCmds[i]
if newCmd.path != oldCmd.path {
differences = append(differences, "path")
}
if !reflect.DeepEqual(newCmd.args, oldCmd.args) {
differences = append(differences, "args")
}
// Sort the environment as we don't care in which order
// it was modified.
newEnvUpdates := newCmd.envUpdates
sort.Strings(newEnvUpdates)
oldEnvUpdates := oldCmd.envUpdates
sort.Strings(oldEnvUpdates)
if !reflect.DeepEqual(newEnvUpdates, oldEnvUpdates) {
differences = append(differences, "env updates")
}
}
if len(differences) > 0 {
hasDifferences = true
} else {
differences = []string{"none"}
}
cmdDifferences = append(cmdDifferences,
fmt.Sprintf("Index %d: %s", i, strings.Join(differences, ",")))
}
if hasDifferences {
return fmt.Sprintf("commands differ:\n%s\nOld:%#v\nNew:%#v",
strings.Join(cmdDifferences, "\n"),
dumpCommands(oldCmds),
dumpCommands(newCmds))
}
return ""
}
func dumpCommands(cmds []*command) string {
lines := []string{}
for _, cmd := range cmds {
lines = append(lines, fmt.Sprintf("%#v", cmd))
}
return strings.Join(lines, "\n")
}
// Note: field names are upper case so they can be used in
// a template via reflection.
type oldWrapperConfig struct {
CmdPath string
OldWrapperContent string
RootRelPath string
LogCmds bool
MockCmds bool
CmdResults []oldWrapperCmdResult
OverwriteConfig bool
CommonFlags []string
GccFlags []string
ClangFlags []string
}
type oldWrapperCmdResult struct {
Stdout string
Stderr string
Exitcode int
}
func newOldWrapperConfig(env env, cfg *config, inputCmd *command) (*oldWrapperConfig, error) {
absOldWrapperPath := cfg.oldWrapperPath
if !filepath.IsAbs(absOldWrapperPath) {
absWrapperDir, err := getAbsWrapperDir(env, inputCmd.path)
if err != nil {
return nil, err
}
absOldWrapperPath = filepath.Join(absWrapperDir, cfg.oldWrapperPath)
}
oldWrapperContentBytes, err := ioutil.ReadFile(absOldWrapperPath)
if err != nil {
return nil, wrapErrorwithSourceLocf(err, "failed to read old wrapper")
}
oldWrapperContent := string(oldWrapperContentBytes)
// Disable the original call to main()
oldWrapperContent = strings.ReplaceAll(oldWrapperContent, "__name__", "'none'")
// Inject the value of cfg.useCCache
if !cfg.useCCache {
oldWrapperContent = regexp.MustCompile(`True\s+#\s+@CCACHE_DEFAULT@`).ReplaceAllString(oldWrapperContent, "False #")
}
return &oldWrapperConfig{
CmdPath: inputCmd.path,
OldWrapperContent: oldWrapperContent,
RootRelPath: cfg.rootRelPath,
CommonFlags: cfg.commonFlags,
GccFlags: cfg.gccFlags,
ClangFlags: cfg.clangFlags,
}, nil
}
func callOldWrapper(env env, cfg *oldWrapperConfig, inputCmd *command, filepattern string, stdout io.Writer, stderr io.Writer) (exitCode int, err error) {
mockFile, err := ioutil.TempFile("", filepattern)
if err != nil {
return 0, wrapErrorwithSourceLocf(err, "failed to create tempfile")
}
defer os.Remove(mockFile.Name())
const mockTemplate = `{{.OldWrapperContent}}
import subprocess
init_env = os.environ.copy()
mockResults = [{{range .CmdResults}} {
'stdout': '{{.Stdout}}',
'stderr': '{{.Stderr}}',
'exitcode': {{.Exitcode}},
},{{end}}]
def serialize_cmd(args):
{{if .LogCmds}}
current_env = os.environ
envupdate = [k + "=" + current_env.get(k, '') for k in set(list(current_env.keys()) + list(init_env.keys())) if current_env.get(k, '') != init_env.get(k, '')]
print('command:%s.EnvUpdate:%s' % (' '.join(args), ' '.join(envupdate)), file=sys.stderr)
{{end}}
def check_output_mock(args):
serialize_cmd(args)
{{if .MockCmds}}
result = mockResults.pop(0)
print(result['stderr'], file=sys.stderr)
if result['exitcode']:
raise subprocess.CalledProcessError(result['exitcode'])
return result['stdout']
{{else}}
return old_check_output(args)
{{end}}
old_check_output = subprocess.check_output
subprocess.check_output = check_output_mock
def popen_mock(args, stdout=None, stderr=None):
serialize_cmd(args)
{{if .MockCmds}}
result = mockResults.pop(0)
if stdout is None:
print(result['stdout'], file=sys.stdout)
if stderr is None:
print(result['stderr'], file=sys.stderr)
class MockResult:
def __init__(self, returncode):
self.returncode = returncode
def wait(self):
return self.returncode
def communicate(self):
return (result['stdout'], result['stderr'])
return MockResult(result['exitcode'])
{{else}}
return old_popen(args)
{{end}}
old_popen = subprocess.Popen
subprocess.Popen = popen_mock
def execv_mock(binary, args):
serialize_cmd([binary] + args[1:])
{{if .MockCmds}}
result = mockResults.pop(0)
print(result['stdout'], file=sys.stdout)
print(result['stderr'], file=sys.stderr)
sys.exit(result['exitcode'])
{{else}}
old_execv(binary, args)
{{end}}
old_execv = os.execv
os.execv = execv_mock
sys.argv[0] = '{{.CmdPath}}'
ROOT_REL_PATH = '{{.RootRelPath}}'
{{if .OverwriteConfig}}
FLAGS_TO_ADD=set([{{range .CommonFlags}}'{{.}}',{{end}}])
GCC_FLAGS_TO_ADD=set([{{range .GccFlags}}'{{.}}',{{end}}])
CLANG_FLAGS_TO_ADD=set([{{range .ClangFlags}}'{{.}}',{{end}}])
{{end}}
sys.exit(main())
`
tmpl, err := template.New("mock").Parse(mockTemplate)
if err != nil {
return 0, wrapErrorwithSourceLocf(err, "failed to parse old wrapper template")
}
if err := tmpl.Execute(mockFile, cfg); err != nil {
return 0, wrapErrorwithSourceLocf(err, "failed execute old wrapper template")
}
if err := mockFile.Close(); err != nil {
return 0, wrapErrorwithSourceLocf(err, "failed to close temp file")
}
buf := bytes.Buffer{}
tmpl.Execute(&buf, cfg)
// Note: Using a self executable wrapper does not work due to a race condition
// on unix systems. See https://github.com/golang/go/issues/22315
oldWrapperCmd := &command{
path: "/usr/bin/python2",
args: append([]string{"-S", mockFile.Name()}, inputCmd.args...),
envUpdates: inputCmd.envUpdates,
}
return wrapSubprocessErrorWithSourceLoc(oldWrapperCmd, env.run(oldWrapperCmd, stdout, stderr))
}
|