esys: simplify resubmit path

Recent System API spec (v1.1 rev 24) simplifies command
re-submission in case of TPM RC_RETRY, RC_TESTING or RC_YIELDED
by storing the command header and parameters at the SAPI layer
and allowing the ESAPI invoke TSS_Sys_ExecuteAsync multiple times.
Change the re-submission logic in ESAPI to leverage this new feature.
By doing that, many of the <TYPE>_IN data structures are no longer
needed and can be removed.
Only the input parameters that are used in _Finish() functions
for purposes other than re-submission need to be stored.

Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>

1 files changed, 9 insertions, 18 deletions

diff --git a/src/tss2-esys/api/Esys_NV_SetBits.c b/src/tss2-esys/api/Esys_NV_SetBits.c
index 961ddf65..a66e921b 100644
--- a/src/tss2-esys/api/Esys_NV_SetBits.c
+++ b/src/tss2-esys/api/Esys_NV_SetBits.c
@@ -18,13 +18,9 @@
 /** Store command parameters inside the ESYS_CONTEXT for use during _Finish */
 static void store_input_parameters (
     ESYS_CONTEXT *esysContext,
-    ESYS_TR authHandle,
-    ESYS_TR nvIndex,
-    UINT64 bits)
+    ESYS_TR nvIndex)
 {
-    esysContext->in.NV_SetBits.authHandle = authHandle;
-    esysContext->in.NV_SetBits.nvIndex = nvIndex;
-    esysContext->in.NV_SetBits.bits = bits;
+    esysContext->in.NV.nvIndex = nvIndex;
 }
 
 /** One-Call function for TPM2_NV_SetBits
@@ -178,10 +174,10 @@ Esys_NV_SetBits_Async(
         return r;
     esysContext->state = _ESYS_STATE_INTERNALERROR;
 
-    /* Check and store input parameters */
+    /* Check input parameters */
     r = check_session_feasibility(shandle1, shandle2, shandle3, 1);
     return_state_if_error(r, _ESYS_STATE_INIT, "Check session usage");
-    store_input_parameters(esysContext, authHandle, nvIndex, bits);
+    store_input_parameters(esysContext, nvIndex);
 
     /* Retrieve the metadata objects for provided handles */
     r = esys_GetResourceObject(esysContext, authHandle, &authHandleNode);
@@ -267,7 +263,8 @@ Esys_NV_SetBits_Finish(
     }
 
     /* Check for correct sequence and set sequence to irregular for now */
-    if (esysContext->state != _ESYS_STATE_SENT) {
+    if (esysContext->state != _ESYS_STATE_SENT &&
+        esysContext->state != _ESYS_STATE_RESUBMISSION) {
         LOG_ERROR("Esys called in bad sequence.");
         return TSS2_ESYS_RC_BAD_SEQUENCE;
     }
@@ -285,19 +282,13 @@ Esys_NV_SetBits_Finish(
     if (r == TPM2_RC_RETRY || r == TPM2_RC_TESTING || r == TPM2_RC_YIELDED) {
         LOG_DEBUG("TPM returned RETRY, TESTING or YIELDED, which triggers a "
             "resubmission: %" PRIx32, r);
-        if (esysContext->submissionCount >= _ESYS_MAX_SUBMISSIONS) {
+        if (esysContext->submissionCount++ >= _ESYS_MAX_SUBMISSIONS) {
             LOG_WARNING("Maximum number of (re)submissions has been reached.");
             esysContext->state = _ESYS_STATE_INIT;
             return r;
         }
         esysContext->state = _ESYS_STATE_RESUBMISSION;
-        r = Esys_NV_SetBits_Async(esysContext,
-                                  esysContext->in.NV_SetBits.authHandle,
-                                  esysContext->in.NV_SetBits.nvIndex,
-                                  esysContext->session_type[0],
-                                  esysContext->session_type[1],
-                                  esysContext->session_type[2],
-                                  esysContext->in.NV_SetBits.bits);
+        r = Tss2_Sys_ExecuteAsync(esysContext->sys);
         if (r != TSS2_RC_SUCCESS) {
             LOG_WARNING("Error attempting to resubmit");
             /* We do not set esysContext->state here but inherit the most recent
@@ -336,7 +327,7 @@ Esys_NV_SetBits_Finish(
                           "Received error from SAPI unmarshaling" );
 
 
-    ESYS_TR nvIndex = esysContext->in.NV_Write.nvIndex;
+    ESYS_TR nvIndex = esysContext->in.NV.nvIndex;
         RSRC_NODE_T *nvIndexNode;
     r = esys_GetResourceObject(esysContext, nvIndex, &nvIndexNode);
     return_if_error(r, "get resource");