aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndroid Build Merger (Role) <noreply-android-build-merger@google.com>2019-01-24 22:56:42 +0000
committerAndroid Build Merger (Role) <noreply-android-build-merger@google.com>2019-01-24 22:56:42 +0000
commitbc4bde3bee34b9bbe439dd24d1d5dfacd9ee0c2b (patch)
tree8197fb78a3c98ac05fcc62ce1fff924d806ebd73
parenta709728a6f8aef61cc9db06729ed7a34a903a376 (diff)
parent6eb63e119294ba92f93f03bbda6c4b203f0f87bb (diff)
downloadtremolo-bc4bde3bee34b9bbe439dd24d1d5dfacd9ee0c2b.tar.gz
[automerger] Add some error/overflow checks in codebook handling am: 6eb63e1192
Change-Id: I59dd405294431d6956fdb50e8e80943ab6ef7b98
-rw-r--r--Tremolo/codebook.c17
1 files changed, 12 insertions, 5 deletions
diff --git a/Tremolo/codebook.c b/Tremolo/codebook.c
index 467640d..a06302d 100644
--- a/Tremolo/codebook.c
+++ b/Tremolo/codebook.c
@@ -376,14 +376,21 @@ long _book_maptype1_quantvals(codebook *b){
long acc=1;
long acc1=1;
int i;
- for(i=0;i<b->dim;i++){
- acc*=vals;
- acc1*=vals+1;
+ for (i = 0; i < b->dim; i++) {
+ if (acc > b->entries / vals) {
+ break;
+ }
+ acc *= vals;
+ if (acc1 > LONG_MAX / (vals + 1)) {
+ acc1 = LONG_MAX;
+ } else {
+ acc1 *= (vals + 1);
+ }
}
- if(acc<=b->entries && acc1>b->entries){
+ if (i >= b->dim && acc <= b->entries && acc1 > b->entries) {
return(vals);
}else{
- if(acc>b->entries){
+ if (i < b->dim || acc > b->entries) {
vals--;
}else{
vals++;