diff options
author | Dongwon Kang <dwkang@google.com> | 2017-07-19 00:01:50 +0000 |
---|---|---|
committer | android-build-merger <android-build-merger@google.com> | 2017-07-19 00:01:50 +0000 |
commit | c9114c49d3573ac34bcd35a6e861101d201465e8 (patch) | |
tree | 051770dbf206213b498290266978645d7b71bdc6 | |
parent | 5c319574a09f3fdb279145461d419e9abb523dfe (diff) | |
parent | 8096fc27d4b26d9c6da9986657b5e4f487c8a0a6 (diff) | |
download | tremolo-c9114c49d3573ac34bcd35a6e861101d201465e8.tar.gz |
Use heap instead of alloca in res012.c am: 70f5300e5a am: 69a7633dda
am: 8096fc27d4
Change-Id: I0cb1e8572e64cf0444bed624998ad1709820fbf6
-rw-r--r-- | Tremolo/res012.c | 36 |
1 files changed, 24 insertions, 12 deletions
diff --git a/Tremolo/res012.c b/Tremolo/res012.c index 513d9ad..d6495fb 100644 --- a/Tremolo/res012.c +++ b/Tremolo/res012.c @@ -126,10 +126,13 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info, if(used){ - char **partword=(char **)alloca(ch*sizeof(*partword)); - for(j=0;j<ch;j++) - partword[j]=(char *)alloca(partwords*partitions_per_word* - sizeof(*partword[j])); + char **partword=(char **)_ogg_calloc(ch,sizeof(*partword)); + if(partword==NULL)goto cleanup1; + for(j=0;j<ch;j++){ + partword[j]=(char *)_ogg_malloc(partwords*partitions_per_word* + sizeof(*partword[j])); + if(partword[j]==NULL)goto cleanup1; + } for(s=0;s<info->stages;s++){ @@ -147,7 +150,7 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info, for(j=0;j<ch;j++){ int temp=vorbis_book_decode(phrasebook,&vd->opb); - if(temp==-1)goto eopbreak; + if(temp==-1)goto cleanup1; /* this can be done quickly in assembly due to the quotient always being at most six bits */ @@ -171,16 +174,23 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info, if(info->type){ if(vorbis_book_decodev_add(stagebook,in[j]+offset,&vd->opb, samples_per_partition,-8)==-1) - goto eopbreak; + goto cleanup1; }else{ if(vorbis_book_decodevs_add(stagebook,in[j]+offset,&vd->opb, samples_per_partition,-8)==-1) - goto eopbreak; + goto cleanup1; } } } } } + cleanup1: + if(partword){ + for(j=0;j<ch;j++){ + if(partword[j])_ogg_free(partword[j]); + } + _ogg_free(partword); + } } } }else{ @@ -193,11 +203,12 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info, int partwords=(partvals+partitions_per_word-1)/partitions_per_word; char *partword= - (char *)alloca(partwords*partitions_per_word*sizeof(*partword)); + (char *)_ogg_malloc(partwords*partitions_per_word*sizeof(*partword)); + if(partword==NULL)goto cleanup2; int beginoff=info->begin/ch; for(i=0;i<ch;i++)if(nonzero[i])break; - if(i==ch)return(0); /* no nonzero vectors */ + if(i==ch)goto cleanup2; /* no nonzero vectors */ samples_per_partition/=ch; @@ -212,7 +223,7 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info, /* fetch the partition word */ temp=vorbis_book_decode(phrasebook,&vd->opb); - if(temp==-1)goto eopbreak; + if(temp==-1)goto cleanup2; /* this can be done quickly in assembly due to the quotient always being at most six bits */ @@ -233,14 +244,15 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info, i*samples_per_partition+beginoff,ch, &vd->opb, samples_per_partition,-8)==-1) - goto eopbreak; + goto cleanup2; } } } } + cleanup2: + if(partword)_ogg_free(partword); } } - eopbreak: return 0; } |