aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDongwon Kang <dwkang@google.com>2017-07-18 23:57:14 +0000
committerandroid-build-merger <android-build-merger@google.com>2017-07-18 23:57:14 +0000
commit69a7633ddaf859c039c65530c2bf311d9f588782 (patch)
tree3cddf0a2fc797b59cff1955141085726b4e3b799
parent59d2e4bfdc9fa43287107b5edd0104dabe43d9c9 (diff)
parent70f5300e5abbb62f1902c1860d32219bf385d89d (diff)
downloadtremolo-69a7633ddaf859c039c65530c2bf311d9f588782.tar.gz
Use heap instead of alloca in res012.c
am: 70f5300e5a Change-Id: I598500c1a03f26db4688cc838bd8d80e38cb3909
-rw-r--r--Tremolo/res012.c36
1 files changed, 24 insertions, 12 deletions
diff --git a/Tremolo/res012.c b/Tremolo/res012.c
index 513d9ad..d6495fb 100644
--- a/Tremolo/res012.c
+++ b/Tremolo/res012.c
@@ -126,10 +126,13 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info,
if(used){
- char **partword=(char **)alloca(ch*sizeof(*partword));
- for(j=0;j<ch;j++)
- partword[j]=(char *)alloca(partwords*partitions_per_word*
- sizeof(*partword[j]));
+ char **partword=(char **)_ogg_calloc(ch,sizeof(*partword));
+ if(partword==NULL)goto cleanup1;
+ for(j=0;j<ch;j++){
+ partword[j]=(char *)_ogg_malloc(partwords*partitions_per_word*
+ sizeof(*partword[j]));
+ if(partword[j]==NULL)goto cleanup1;
+ }
for(s=0;s<info->stages;s++){
@@ -147,7 +150,7 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info,
for(j=0;j<ch;j++){
int temp=vorbis_book_decode(phrasebook,&vd->opb);
- if(temp==-1)goto eopbreak;
+ if(temp==-1)goto cleanup1;
/* this can be done quickly in assembly due to the quotient
always being at most six bits */
@@ -171,16 +174,23 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info,
if(info->type){
if(vorbis_book_decodev_add(stagebook,in[j]+offset,&vd->opb,
samples_per_partition,-8)==-1)
- goto eopbreak;
+ goto cleanup1;
}else{
if(vorbis_book_decodevs_add(stagebook,in[j]+offset,&vd->opb,
samples_per_partition,-8)==-1)
- goto eopbreak;
+ goto cleanup1;
}
}
}
}
}
+ cleanup1:
+ if(partword){
+ for(j=0;j<ch;j++){
+ if(partword[j])_ogg_free(partword[j]);
+ }
+ _ogg_free(partword);
+ }
}
}
}else{
@@ -193,11 +203,12 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info,
int partwords=(partvals+partitions_per_word-1)/partitions_per_word;
char *partword=
- (char *)alloca(partwords*partitions_per_word*sizeof(*partword));
+ (char *)_ogg_malloc(partwords*partitions_per_word*sizeof(*partword));
+ if(partword==NULL)goto cleanup2;
int beginoff=info->begin/ch;
for(i=0;i<ch;i++)if(nonzero[i])break;
- if(i==ch)return(0); /* no nonzero vectors */
+ if(i==ch)goto cleanup2; /* no nonzero vectors */
samples_per_partition/=ch;
@@ -212,7 +223,7 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info,
/* fetch the partition word */
temp=vorbis_book_decode(phrasebook,&vd->opb);
- if(temp==-1)goto eopbreak;
+ if(temp==-1)goto cleanup2;
/* this can be done quickly in assembly due to the quotient
always being at most six bits */
@@ -233,14 +244,15 @@ int res_inverse(vorbis_dsp_state *vd,vorbis_info_residue *info,
i*samples_per_partition+beginoff,ch,
&vd->opb,
samples_per_partition,-8)==-1)
- goto eopbreak;
+ goto cleanup2;
}
}
}
}
+ cleanup2:
+ if(partword)_ogg_free(partword);
}
}
- eopbreak:
return 0;
}