diff options
| author | Bhautik Ardeshana <bhautik.ardeshana@nxp.com> | 2023-07-25 16:29:17 +0530 |
|---|---|---|
| committer | Bhautik Ardeshana <bhautik.ardeshana@nxp.com> | 2023-07-27 14:50:49 +0530 |
| commit | 2d93d6954662ac0b136bd733adc3b63ebf858bdb (patch) | |
| tree | 4aa8d52307986cbe8aca657cde78fe5392661213 | |
| parent | eb84adc930f4b5e727f55443d2332de8bba01bcc (diff) | |
| download | uwb-2d93d6954662ac0b136bd733adc3b63ebf858bdb.tar.gz | |
Sequence Number field size correction in SESSION_DATA_TRANSFER_STATUS_NTF
Bug: 291177310
Test: Test data transfer
Change-Id: I8e7ff1452db769889a84269087586c7e9e3a8a40
| -rw-r--r-- | src/rust/uwb_core/src/uci/notification.rs | 4 | ||||
| -rw-r--r-- | src/rust/uwb_core/src/uci/uci_manager.rs | 9 | ||||
| -rw-r--r-- | src/rust/uwb_uci_packets/uci_packets.pdl | 2 |
3 files changed, 6 insertions, 9 deletions
diff --git a/src/rust/uwb_core/src/uci/notification.rs b/src/rust/uwb_core/src/uci/notification.rs index eab8233..90231ae 100644 --- a/src/rust/uwb_core/src/uci/notification.rs +++ b/src/rust/uwb_core/src/uci/notification.rs @@ -81,8 +81,8 @@ pub enum SessionNotification { DataTransferStatus { /// SessionToken : u32 session_token: SessionToken, - /// Sequence Number: u8 - uci_sequence_number: u8, + /// Sequence Number: u16 + uci_sequence_number: u16, /// Data Transfer Status Code status: DataTransferNtfStatusCode, /// Transmission count diff --git a/src/rust/uwb_core/src/uci/uci_manager.rs b/src/rust/uwb_core/src/uci/uci_manager.rs index 2325751..646cc6a 100644 --- a/src/rust/uwb_core/src/uci/uci_manager.rs +++ b/src/rust/uwb_core/src/uci/uci_manager.rs @@ -2847,8 +2847,7 @@ mod tests { ntfs.append(&mut into_uci_hal_packets( uwb_uci_packets::DataTransferStatusNtfBuilder { session_token, - // TODO(b/282230468): Remove the u16-to-u8 conversion once spec is updated. - uci_sequence_number: uci_sequence_number.try_into().unwrap(), + uci_sequence_number, status, tx_count, }, @@ -2938,8 +2937,7 @@ mod tests { ntfs.append(&mut into_uci_hal_packets( uwb_uci_packets::DataTransferStatusNtfBuilder { session_token, - // TODO(b/282230468): Remove the u16-to-u8 conversion once spec is updated. - uci_sequence_number: uci_sequence_number.try_into().unwrap(), + uci_sequence_number, status, tx_count, }, @@ -3002,8 +3000,7 @@ mod tests { ntfs.append(&mut into_uci_hal_packets( uwb_uci_packets::DataTransferStatusNtfBuilder { session_token, - // TODO(b/282230468): Remove the u16-to-u8 conversion once spec is updated. - uci_sequence_number: uci_sequence_number.try_into().unwrap(), + uci_sequence_number, status, tx_count, }, diff --git a/src/rust/uwb_uci_packets/uci_packets.pdl b/src/rust/uwb_uci_packets/uci_packets.pdl index 94521c1..de94e2b 100644 --- a/src/rust/uwb_uci_packets/uci_packets.pdl +++ b/src/rust/uwb_uci_packets/uci_packets.pdl @@ -996,7 +996,7 @@ test DataCreditNtf { packet DataTransferStatusNtf : SessionControlNotification (opcode = 0x05) { // SESSION_DATA_TRANSFER_STATUS_NTF session_token: 32, // Session ID or Session Handle (based on UWBS version) - uci_sequence_number: 8, + uci_sequence_number: 16, status: DataTransferNtfStatusCode, tx_count: 8, } |