Merge changes I3c8e1054,I5efe9cdf into rvc-dev

* changes:
  v4l2_codec2: Move BitstreamBuffer class to BitstreamBuffer.h.
  v4l2_codec2: Change input buffer memory type to DMABuf.

7 files changed, 113 insertions, 167 deletions

diff --git a/components/V4L2DecodeComponent.cpp b/components/V4L2DecodeComponent.cpp
index 0f59d79..49f04d6 100644
--- a/components/V4L2DecodeComponent.cpp
+++ b/components/V4L2DecodeComponent.cpp
@@ -24,6 +24,7 @@
 #include <media/stagefright/foundation/ColorUtils.h>
 
 #include <h264_parser.h>
+#include <v4l2_codec2/components/BitstreamBuffer.h>
 #include <v4l2_codec2/components/V4L2Decoder.h>
 #include <v4l2_codec2/components/VideoFramePool.h>
 #include <v4l2_codec2/components/VideoTypes.h>
@@ -39,8 +40,8 @@ int32_t frameIndexToBitstreamId(c2_cntr64_t frameIndex) {
     return static_cast<int32_t>(frameIndex.peeku() & 0x3FFFFFFF);
 }
 
-std::unique_ptr<VideoDecoder::BitstreamBuffer> C2BlockToBitstreamBuffer(
-        const C2ConstLinearBlock& block, const int32_t bitstreamId) {
+std::unique_ptr<BitstreamBuffer> C2BlockToBitstreamBuffer(const C2ConstLinearBlock& block,
+                                                          const int32_t bitstreamId) {
     const int fd = block.handle()->data[0];
     auto dupFd = ::base::ScopedFD(dup(fd));
     if (!dupFd.is_valid()) {
@@ -48,8 +49,8 @@ std::unique_ptr<VideoDecoder::BitstreamBuffer> C2BlockToBitstreamBuffer(
         return nullptr;
     }
 
-    return std::make_unique<VideoDecoder::BitstreamBuffer>(bitstreamId, std::move(dupFd),
-                                                           block.offset(), block.size());
+    return std::make_unique<BitstreamBuffer>(bitstreamId, std::move(dupFd), block.offset(),
+                                             block.size());
 }
 
 bool parseCodedColorAspects(const C2ConstLinearBlock& input,
diff --git a/components/V4L2Decoder.cpp b/components/V4L2Decoder.cpp
index 4301813..3ec799f 100644
--- a/components/V4L2Decoder.cpp
+++ b/components/V4L2Decoder.cpp
@@ -12,6 +12,7 @@
 #include <vector>
 
 #include <base/bind.h>
+#include <base/files/scoped_file.h>
 #include <base/memory/ptr_util.h>
 #include <log/log.h>
 
diff --git a/components/V4L2EncodeComponent.cpp b/components/V4L2EncodeComponent.cpp
index 2f603bd..c13537e 100644
--- a/components/V4L2EncodeComponent.cpp
+++ b/components/V4L2EncodeComponent.cpp
@@ -28,7 +28,6 @@
 #include <v4l2_codec2/common/Common.h>
 #include <v4l2_codec2/common/EncodeHelpers.h>
 #include <v4l2_device.h>
-#include <video_frame.h>
 #include <video_pixel_format.h>
 
 namespace android {
@@ -179,6 +178,23 @@ constexpr size_t kOutputBufferCount = 2;
 }  // namespace
 
 // static
+std::unique_ptr<V4L2EncodeComponent::InputFrame> V4L2EncodeComponent::InputFrame::Create(
+        const C2ConstGraphicBlock& block) {
+    std::vector<::base::ScopedFD> fds;
+    const C2Handle* const handle = block.handle();
+    for (int i = 0; i < handle->numFds; i++) {
+        fds.emplace_back(dup(handle->data[i]));
+        if (!fds.back().is_valid()) {
+            ALOGE("Failed to duplicate input graphic block handle %d (errno: %d)", handle->data[i],
+                  errno);
+            return nullptr;
+        }
+    }
+
+    return std::unique_ptr<InputFrame>(new InputFrame(std::move(fds)));
+}
+
+// static
 std::shared_ptr<C2Component> V4L2EncodeComponent::create(
         C2String name, c2_node_id_t id, std::shared_ptr<C2ReflectorHelper> helper,
         C2ComponentFactory::ComponentDeleter deleter) {
@@ -570,8 +586,6 @@ bool V4L2EncodeComponent::initializeEncoder() {
     mKeyFramePeriod = mInterface->getKeyFramePeriod();
     mKeyFrameCounter = 0;
     mCSDSubmitted = false;
-    // TODO(dstaessens): Add support for DMA buffers.
-    mMemoryType = VideoEncoderAcceleratorConfig::SHMEM;
 
     // Open the V4L2 device for encoding to the requested output format.
     // TODO(dstaessens): Do we need to close the device first if already opened?
@@ -1050,8 +1064,7 @@ bool V4L2EncodeComponent::encode(C2ConstGraphicBlock block, uint64_t index, int6
           timestamp, block.width(), block.height());
 
     // Create a video frame from the graphic block.
-    // TODO(dstaessens): Avoid conversion to video frame
-    scoped_refptr<media::VideoFrame> frame = createVideoFrame(block, index, timestamp);
+    std::unique_ptr<InputFrame> frame = InputFrame::Create(block);
     if (!frame) {
         ALOGE("Failed to create video frame from input block (index: %" PRIu64
               ", timestamp: %" PRId64 ")",
@@ -1060,7 +1073,17 @@ bool V4L2EncodeComponent::encode(C2ConstGraphicBlock block, uint64_t index, int6
         return false;
     }
 
-    if (!enqueueInputBuffer(std::move(frame), index)) {
+    // Get the video frame layout and pixel format from the graphic block.
+    // TODO(dstaessens) Integrate getVideoFrameLayout() into InputFrame::Create()
+    media::VideoPixelFormat format;
+    std::optional<std::vector<VideoFramePlane>> planes = getVideoFrameLayout(block, &format);
+    if (!planes) {
+        ALOGE("Failed to get input block's layout");
+        reportError(C2_CORRUPTED);
+        return false;
+    }
+
+    if (!enqueueInputBuffer(std::move(frame), format, *planes, index, timestamp)) {
         ALOGE("Failed to enqueue video frame (index: %" PRIu64 ", timestamp: %" PRId64 ")", index,
               timestamp);
         reportError(C2_CORRUPTED);
@@ -1162,70 +1185,6 @@ void V4L2EncodeComponent::flush() {
     // encode work is queued.
 }
 
-scoped_refptr<media::VideoFrame> V4L2EncodeComponent::createVideoFrame(
-        const C2ConstGraphicBlock& inputBlock, uint64_t index, int64_t timestamp) {
-    ALOGV("%s(): creating video frame (index: %" PRIu64 ", timestamp: %" PRId64 ", size: %dx%d)",
-          __func__, index, timestamp, inputBlock.width(), inputBlock.height());
-    ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
-
-    // TODO(dstaessens): Find a way to not map input block each time to acquire pixel format.
-    if (mMemoryType != VideoEncoderAcceleratorConfig::SHMEM) {
-        ALOGE("DMAbuf storage type is not supported yet");
-        reportError(C2_CORRUPTED);
-        return nullptr;
-    }
-
-    // TODO(dstaessens): input block layout might be different from the negotiated mInputLayout?
-    media::VideoPixelFormat inputFormat;
-    auto planes = getVideoFrameLayout(inputBlock, &inputFormat);
-    if (!planes) {
-        ALOGE("Failed to get input block's layout");
-        reportError(C2_CORRUPTED);
-        return nullptr;
-    }
-
-    // Get a shared memory handle from the video frame.
-    int frameFd = dup(inputBlock.handle()->data[0]);
-    if (frameFd < 0) {
-        ALOGE("Failed to duplicate input block handle (index: %" PRIu64 ", timestamp: %" PRId64
-              ", errno: %d)",
-              index, timestamp, errno);
-        reportError(C2_CORRUPTED);
-        return nullptr;
-    }
-
-    size_t allocationSize = media::VideoFrame::AllocationSize(inputFormat, mInputCodedSize);
-    ::base::SharedMemoryHandle shmHandle(::base::FileDescriptor(frameFd, true), 0u,
-                                         ::base::UnguessableToken::Create());
-    ALOG_ASSERT(::base::SharedMemory::IsHandleValid(shmHandle));
-
-    auto shm = std::make_unique<::base::SharedMemory>(shmHandle, true);
-
-    off_t offset = static_cast<off_t>((*planes)[0].mOffset);
-    if (!shm->MapAt(offset, allocationSize)) {
-        ALOGE("Failed to map input block memory (index: %" PRIu64 ", timestamp: %" PRId64
-              ", offset=%ld, map size: %zu)",
-              index, timestamp, offset, allocationSize);
-        reportError(C2_CORRUPTED);
-        return nullptr;
-    }
-
-    uint8_t* shmMemory = reinterpret_cast<uint8_t*>(shm->memory());
-    scoped_refptr<media::VideoFrame> frame = media::VideoFrame::WrapExternalSharedMemory(
-            inputFormat, mInputCodedSize, media::Rect(mVisibleSize), mVisibleSize,
-            shmMemory + offset, allocationSize, shmHandle, (*planes)[0].mOffset,
-            ::base::TimeDelta::FromMicroseconds(timestamp));
-    ALOGE("Created video frame from shared memory (index: %" PRIu64 ", timestamp: %" PRId64, index,
-          timestamp);
-
-    // Attach shared memory to video frame destruction observer, so when the frame goes out of scope
-    // the shared memory is unmapped and released.
-    frame->AddDestructionObserver(::base::BindOnce(
-            ::base::DoNothing::Once<std::unique_ptr<::base::SharedMemory>>(), std::move(shm)));
-
-    return frame;
-}
-
 std::shared_ptr<C2LinearBlock> V4L2EncodeComponent::fetchOutputBlock() {
     // TODO(dstaessens): fetchLinearBlock() might be blocking.
     ALOGV("Fetching linear block (size: %u)", mOutputBufferSize);
@@ -1481,13 +1440,16 @@ void V4L2EncodeComponent::serviceDeviceTask(bool /*event*/) {
     ALOGV("%s() - done", __func__);
 }
 
-bool V4L2EncodeComponent::enqueueInputBuffer(scoped_refptr<media::VideoFrame> frame,
-                                             int64_t index) {
+bool V4L2EncodeComponent::enqueueInputBuffer(std::unique_ptr<InputFrame> frame,
+                                             media::VideoPixelFormat format,
+                                             const std::vector<VideoFramePlane>& planes,
+                                             int64_t index, int64_t timestamp) {
     ALOGV("%s(): queuing input buffer (index: %" PRId64 ")", __func__, index);
     ALOG_ASSERT(mEncoderTaskRunner->RunsTasksInCurrentSequence());
     ALOG_ASSERT(mInputQueue->FreeBuffersCount() > 0);
     ALOG_ASSERT(mEncoderState == EncoderState::ENCODING);
-    ALOG_ASSERT(mInputLayout->format() == frame->format());
+    ALOG_ASSERT(mInputLayout->format() == format);
+    ALOG_ASSERT(mInputLayout->planes().size() == planes.size());
 
     auto buffer = mInputQueue->GetFreeBuffer();
     if (!buffer) {
@@ -1496,75 +1458,37 @@ bool V4L2EncodeComponent::enqueueInputBuffer(scoped_refptr<media::VideoFrame> fr
     }
 
     // Mark the buffer with the frame's timestamp so we can identify the associated output buffers.
-    struct timeval timestamp;
-    timestamp.tv_sec = static_cast<time_t>(frame->timestamp().InSeconds());
-    timestamp.tv_usec = frame->timestamp().InMicroseconds() -
-                        frame->timestamp().InSeconds() * ::base::Time::kMicrosecondsPerSecond;
-    buffer->SetTimeStamp(timestamp);
+    buffer->SetTimeStamp(
+            {.tv_sec = static_cast<time_t>(timestamp / ::base::Time::kMicrosecondsPerSecond),
+             .tv_usec = static_cast<time_t>(timestamp % ::base::Time::kMicrosecondsPerSecond)});
     size_t bufferId = buffer->BufferId();
 
-    auto fourcc = media::Fourcc::FromVideoPixelFormat(mInputLayout->format(), false);
-    size_t numPlanes = media::V4L2Device::GetNumPlanesOfV4L2PixFmt(fourcc->ToV4L2PixFmt());
-
-    for (size_t i = 0; i < numPlanes; ++i) {
-        // Single-buffer input format may have multiple color planes, so bytesused of the single
+    for (size_t i = 0; i < planes.size(); ++i) {
+        // Single-buffer input format may have multiple color planes, so bytesUsed of the single
         // buffer should be sum of each color planes' size.
         size_t bytesUsed = 0;
-        if (numPlanes == 1) {
-            bytesUsed =
-                    media::VideoFrame::AllocationSize(frame->format(), mInputLayout->coded_size());
+        if (planes.size() == 1) {
+            bytesUsed = media::VideoFrame::AllocationSize(format, mInputLayout->coded_size());
         } else {
             bytesUsed = ::base::checked_cast<size_t>(
-                    media::VideoFrame::PlaneSize(frame->format(), i, mInputLayout->coded_size())
-                            .GetArea());
-        }
-        switch (buffer->Memory()) {
-        case V4L2_MEMORY_USERPTR:
-            // Use the input buffer sizes negotiated with the device.
-            buffer->SetPlaneSize(i, mInputLayout->planes()[i].size);
-            break;
-        case V4L2_MEMORY_DMABUF: {
-            const auto& planes = frame->layout().planes();
-            ALOG_ASSERT(mInputLayout->planes().size() == planes.size());
-            // TODO(crbug.com/901264): The way to pass an offset within a DMA-buf is not defined
-            // in V4L2 specification, so we abuse data_offset for now. Fix it when we have the
-            // right interface, including any necessary validation and potential alignment.
-            buffer->SetPlaneDataOffset(i, planes[i].offset);
-            bytesUsed += planes[i].offset;
-            // Workaround: filling length should not be needed. This is a bug of videobuf2
-            // library.
-            buffer->SetPlaneSize(i, mInputLayout->planes()[i].size + planes[i].offset);
-            break;
-        }
-        default:
-            NOTREACHED();
-            return false;
+                    media::VideoFrame::PlaneSize(format, i, mInputLayout->coded_size()).GetArea());
         }
 
+        // TODO(crbug.com/901264): The way to pass an offset within a DMA-buf is not defined
+        // in V4L2 specification, so we abuse data_offset for now. Fix it when we have the
+        // right interface, including any necessary validation and potential alignment.
+        buffer->SetPlaneDataOffset(i, planes[i].mOffset);
+        bytesUsed += planes[i].mOffset;
+        // Workaround: filling length should not be needed. This is a bug of videobuf2 library.
+        buffer->SetPlaneSize(i, mInputLayout->planes()[i].size + planes[i].mOffset);
         buffer->SetPlaneBytesUsed(i, bytesUsed);
     }
 
-    switch (buffer->Memory()) {
-    case V4L2_MEMORY_USERPTR: {
-        std::vector<void*> userPtrs;
-        for (size_t i = 0; i < numPlanes; ++i) userPtrs.push_back(frame->data(i));
-        std::move(*buffer).QueueUserPtr(std::move(userPtrs));
-        break;
-    }
-    case V4L2_MEMORY_DMABUF: {
-        const std::vector<::base::ScopedFD>& fds = frame->DmabufFds();
-        std::move(*buffer).QueueDMABuf(fds);
-        break;
-    }
-    default:
-        NOTREACHED() << "Unknown input memory type: " << static_cast<int>(buffer->Memory());
-        reportError(C2_CORRUPTED);
-        return false;
-    }
+    std::move(*buffer).QueueDMABuf(frame->getFDs());
 
     ALOGV("Queued buffer in input queue (index: %" PRId64 ", timestamp: %" PRId64
           ", bufferId: %zu)",
-          index, frame->timestamp().InMicroseconds(), bufferId);
+          index, timestamp, bufferId);
 
     mInputBuffersMap[bufferId] = {index, std::move(frame)};
 
@@ -1612,13 +1536,13 @@ bool V4L2EncodeComponent::dequeueInputBuffer() {
 
     const media::V4L2ReadableBufferRef buffer = std::move(result.second);
     uint64_t index = mInputBuffersMap[buffer->BufferId()].first;
-    scoped_refptr<media::VideoFrame> frame = std::move(mInputBuffersMap[buffer->BufferId()].second);
-
+    int64_t timestamp = buffer->GetTimeStamp().tv_usec +
+                        buffer->GetTimeStamp().tv_sec * ::base::Time::kMicrosecondsPerSecond;
     ALOGV("Dequeued buffer from input queue (index: %" PRId64 ", timestamp: %" PRId64
           ", bufferId: %zu)",
-          index, frame->timestamp().InMicroseconds(), buffer->BufferId());
+          index, timestamp, buffer->BufferId());
 
-    frame = nullptr;
+    mInputBuffersMap[buffer->BufferId()].second = nullptr;
     onInputBufferDone(index);
 
     return true;
@@ -1704,12 +1628,8 @@ bool V4L2EncodeComponent::createInputBuffers() {
 
     // No memory is allocated here, we just generate a list of buffers on the input queue, which
     // will hold memory handles to the real buffers.
-    enum v4l2_memory input_memory_type =
-            (mMemoryType == VideoEncoderAcceleratorConfig::VideoFrameStorageType::SHMEM)
-                    ? V4L2_MEMORY_USERPTR
-                    : V4L2_MEMORY_DMABUF;
-    if (mInputQueue->AllocateBuffers(kInputBufferCount, input_memory_type) < kInputBufferCount) {
-        ALOGE("Failed to allocate V4L2 input buffers.");
+    if (mInputQueue->AllocateBuffers(kInputBufferCount, V4L2_MEMORY_DMABUF) < kInputBufferCount) {
+        ALOGE("Failed to create V4L2 input buffers.");
         return false;
     }
 
diff --git a/components/include/v4l2_codec2/components/BitstreamBuffer.h b/components/include/v4l2_codec2/components/BitstreamBuffer.h
new file mode 100644
index 0000000..cc8d3f6
--- /dev/null
+++ b/components/include/v4l2_codec2/components/BitstreamBuffer.h
@@ -0,0 +1,28 @@
+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ANDROID_V4L2_CODEC2_COMPONENTS_BITSTREAMBUFFER_H
+#define ANDROID_V4L2_CODEC2_COMPONENTS_BITSTREAMBUFFER_H
+
+#include <stdint.h>
+
+#include <base/files/scoped_file.h>
+
+namespace android {
+
+struct BitstreamBuffer {
+    BitstreamBuffer(const int32_t id, base::ScopedFD dmabuf_fd, const size_t offset,
+                    const size_t size)
+          : id(id), dmabuf_fd(std::move(dmabuf_fd)), offset(offset), size(size) {}
+    ~BitstreamBuffer() = default;
+
+    const int32_t id;
+    base::ScopedFD dmabuf_fd;
+    const size_t offset;
+    const size_t size;
+};
+
+}  // namespace android
+
+#endif  // ANDROID_V4L2_CODEC2_COMPONENTS_BITSTREAMBUFFER_H
diff --git a/components/include/v4l2_codec2/components/V4L2Decoder.h b/components/include/v4l2_codec2/components/V4L2Decoder.h
index 6476bb6..eb12950 100644
--- a/components/include/v4l2_codec2/components/V4L2Decoder.h
+++ b/components/include/v4l2_codec2/components/V4L2Decoder.h
@@ -11,7 +11,6 @@
 #include <optional>
 
 #include <base/callback.h>
-#include <base/files/scoped_file.h>
 #include <base/memory/weak_ptr.h>
 
 #include <rect.h>
diff --git a/components/include/v4l2_codec2/components/V4L2EncodeComponent.h b/components/include/v4l2_codec2/components/V4L2EncodeComponent.h
index b772377..8a9459c 100644
--- a/components/include/v4l2_codec2/components/V4L2EncodeComponent.h
+++ b/components/include/v4l2_codec2/components/V4L2EncodeComponent.h
@@ -16,6 +16,7 @@
 #include <C2Param.h>
 #include <C2ParamDef.h>
 #include <SimpleC2Interface.h>
+#include <base/files/scoped_file.h>
 #include <base/memory/scoped_refptr.h>
 #include <base/single_thread_task_runner.h>
 #include <base/synchronization/waitable_event.h>
@@ -31,11 +32,12 @@ namespace media {
 class V4L2Device;
 class V4L2ReadableBuffer;
 class V4L2Queue;
-class VideoFrame;
 }  // namespace media
 
 namespace android {
 
+struct VideoFramePlane;
+
 class V4L2EncodeComponent : public C2Component,
                             public std::enable_shared_from_this<V4L2EncodeComponent> {
 public:
@@ -61,6 +63,19 @@ public:
     std::shared_ptr<C2ComponentInterface> intf() override;
 
 private:
+    class InputFrame {
+    public:
+        // Create an input frame from a C2GraphicBlock.
+        static std::unique_ptr<InputFrame> Create(const C2ConstGraphicBlock& block);
+        ~InputFrame() = default;
+
+        const std::vector<::base::ScopedFD>& getFDs() const { return mFds; }
+
+    private:
+        InputFrame(std::vector<::base::ScopedFD> fds) : mFds(std::move(fds)) {}
+        const std::vector<::base::ScopedFD> mFds;
+    };
+
     // Possible component states.
     enum class ComponentState {
         UNLOADED,  // Initial state of component.
@@ -125,10 +140,6 @@ private:
     // Flush the encoder.
     void flush();
 
-    // Create a video frame from the specified |inputBlock|.
-    // TODO(dstaessens): Avoid conversion to video frame
-    scoped_refptr<media::VideoFrame> createVideoFrame(const C2ConstGraphicBlock& inputBlock,
-                                                      uint64_t index, int64_t timestamp);
     // Fetch a new output buffer from the output block pool.
     std::shared_ptr<C2LinearBlock> fetchOutputBlock();
 
@@ -158,8 +169,9 @@ private:
 
     // Enqueue an input buffer to be encoded on the device input queue. Returns whether the
     // operation was successful.
-    // TODO(dstaessens): Avoid using a video frame here
-    bool enqueueInputBuffer(scoped_refptr<media::VideoFrame> frame, int64_t index);
+    bool enqueueInputBuffer(std::unique_ptr<InputFrame> frame, media::VideoPixelFormat format,
+                            const std::vector<VideoFramePlane>& planes, int64_t index,
+                            int64_t timestamp);
     // Enqueue an output buffer to store the encoded bitstream on the device output queue. Returns
     // whether the operation was successful.
     bool enqueueOutputBuffer();
@@ -238,10 +250,6 @@ private:
     // Key frame counter, a key frame will be requested each time it reaches zero.
     uint32_t mKeyFrameCounter = 0;
 
-    // The buffer memory type, can be either shared memory or DMA.
-    VideoEncoderAcceleratorConfig::VideoFrameStorageType mMemoryType =
-            VideoEncoderAcceleratorConfig::SHMEM;
-
     // Whether we need to manually cache and prepend the SPS and PPS to each IDR frame. When
     // encoding H.264 we prepend each IDR with SPS and PPS for resilience. Some devices support this
     // via the V4L2_CID_MPEG_VIDEO_H264_SPS_PPS_BEFORE_IDR control. For devices without support for
@@ -261,7 +269,7 @@ private:
     std::deque<std::unique_ptr<C2Work>> mOutputWorkQueue;
 
     // List of work item indices and frames associated with each buffer in the device input queue.
-    std::vector<std::pair<int64_t, scoped_refptr<media::VideoFrame>>> mInputBuffersMap;
+    std::vector<std::pair<int64_t, std::unique_ptr<InputFrame>>> mInputBuffersMap;
     // The output block pool.
     std::shared_ptr<C2BlockPool> mOutputBlockPool;
 
diff --git a/components/include/v4l2_codec2/components/VideoDecoder.h b/components/include/v4l2_codec2/components/VideoDecoder.h
index 41517b3..99d16b3 100644
--- a/components/include/v4l2_codec2/components/VideoDecoder.h
+++ b/components/include/v4l2_codec2/components/VideoDecoder.h
@@ -11,6 +11,7 @@
 #include <base/callback.h>
 #include <base/files/scoped_file.h>
 
+#include <v4l2_codec2/components/BitstreamBuffer.h>
 #include <v4l2_codec2/components/VideoFrame.h>
 #include <v4l2_codec2/components/VideoFramePool.h>
 #include <v4l2_codec2/components/VideoTypes.h>
@@ -26,18 +27,6 @@ public:
     };
     static const char* DecodeStatusToString(DecodeStatus status);
 
-    struct BitstreamBuffer {
-        BitstreamBuffer(const int32_t id, base::ScopedFD dmabuf_fd, const size_t offset,
-                        const size_t size)
-              : id(id), dmabuf_fd(std::move(dmabuf_fd)), offset(offset), size(size) {}
-        ~BitstreamBuffer() = default;
-
-        const int32_t id;
-        base::ScopedFD dmabuf_fd;
-        const size_t offset;
-        const size_t size;
-    };
-
     using GetPoolCB =
             base::RepeatingCallback<void(std::unique_ptr<VideoFramePool>*, const media::Size& size,
                                          HalPixelFormat pixelFormat, size_t numOutputBuffers)>;