diff options
author | Ben Murdoch <benm@android.com> | 2016-05-18 10:25:55 +0000 |
---|---|---|
committer | Ben Murdoch <benm@android.com> | 2016-05-18 10:25:55 +0000 |
commit | f2e3994fa5148cc3d9946666f0b0596290192b0e (patch) | |
tree | c3598742f63815b83f744c50e515b845c1217551 /src/ic/mips | |
parent | 8389745919cae02139ddc085a63c00d024269cf2 (diff) | |
download | v8-f2e3994fa5148cc3d9946666f0b0596290192b0e.tar.gz |
Revert "Upgrade to 5.0.71.48"
This reverts commit 8389745919cae02139ddc085a63c00d024269cf2.
Change-Id: Ic5c75c8b3ddaf795972372fbc863a514862953c1
Diffstat (limited to 'src/ic/mips')
-rw-r--r-- | src/ic/mips/handler-compiler-mips.cc | 109 | ||||
-rw-r--r-- | src/ic/mips/ic-mips.cc | 72 | ||||
-rw-r--r-- | src/ic/mips/stub-cache-mips.cc | 6 |
3 files changed, 100 insertions, 87 deletions
diff --git a/src/ic/mips/handler-compiler-mips.cc b/src/ic/mips/handler-compiler-mips.cc index f3af1cf5..554d0c56 100644 --- a/src/ic/mips/handler-compiler-mips.cc +++ b/src/ic/mips/handler-compiler-mips.cc @@ -4,10 +4,8 @@ #if V8_TARGET_ARCH_MIPS -#include "src/ic/handler-compiler.h" - -#include "src/field-type.h" #include "src/ic/call-optimization.h" +#include "src/ic/handler-compiler.h" #include "src/ic/ic.h" #include "src/isolate-inl.h" @@ -281,16 +279,9 @@ void PropertyHandlerCompiler::GenerateApiAccessorCall( call_data_undefined = true; __ LoadRoot(data, Heap::kUndefinedValueRootIndex); } else { - if (optimization.is_constant_call()) { - __ lw(data, - FieldMemOperand(callee, JSFunction::kSharedFunctionInfoOffset)); - __ lw(data, - FieldMemOperand(data, SharedFunctionInfo::kFunctionDataOffset)); - __ lw(data, FieldMemOperand(data, FunctionTemplateInfo::kCallCodeOffset)); - } else { - __ lw(data, - FieldMemOperand(callee, FunctionTemplateInfo::kCallCodeOffset)); - } + __ lw(data, FieldMemOperand(callee, JSFunction::kSharedFunctionInfoOffset)); + __ lw(data, FieldMemOperand(data, SharedFunctionInfo::kFunctionDataOffset)); + __ lw(data, FieldMemOperand(data, FunctionTemplateInfo::kCallCodeOffset)); __ lw(data, FieldMemOperand(data, CallHandlerInfo::kDataOffset)); } @@ -308,8 +299,7 @@ void PropertyHandlerCompiler::GenerateApiAccessorCall( __ li(api_function_address, Operand(ref)); // Jump to stub. - CallApiAccessorStub stub(isolate, is_store, call_data_undefined, - !optimization.is_constant_call()); + CallApiAccessorStub stub(isolate, is_store, call_data_undefined); __ TailCallStub(&stub); } @@ -393,7 +383,8 @@ void NamedStoreHandlerCompiler::GenerateConstantCheck(Register map_reg, __ Branch(miss_label, ne, value_reg, Operand(scratch)); } -void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(FieldType* field_type, + +void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type, Register value_reg, Label* miss_label) { Register map_reg = scratch1(); @@ -401,11 +392,21 @@ void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(FieldType* field_type, DCHECK(!value_reg.is(map_reg)); DCHECK(!value_reg.is(scratch)); __ JumpIfSmi(value_reg, miss_label); - if (field_type->IsClass()) { + HeapType::Iterator<Map> it = field_type->Classes(); + if (!it.Done()) { __ lw(map_reg, FieldMemOperand(value_reg, HeapObject::kMapOffset)); - // Compare map directly within the Branch() functions. - __ GetWeakValue(scratch, Map::WeakCellForMap(field_type->AsClass())); - __ Branch(miss_label, ne, map_reg, Operand(scratch)); + Label do_store; + while (true) { + // Compare map directly within the Branch() functions. + __ GetWeakValue(scratch, Map::WeakCellForMap(it.Current())); + it.Advance(); + if (it.Done()) { + __ Branch(miss_label, ne, map_reg, Operand(scratch)); + break; + } + __ Branch(&do_store, eq, map_reg, Operand(scratch)); + } + __ bind(&do_store); } } @@ -583,51 +584,42 @@ void NamedLoadHandlerCompiler::GenerateLoadConstant(Handle<Object> value) { void NamedLoadHandlerCompiler::GenerateLoadCallback( - Register reg, Handle<AccessorInfo> callback) { - DCHECK(!AreAliased(scratch2(), scratch3(), scratch4(), receiver())); - DCHECK(!AreAliased(scratch2(), scratch3(), scratch4(), reg)); - - // Build v8::PropertyCallbackInfo::args_ array on the stack and push property - // name below the exit frame to make GC aware of them. - STATIC_ASSERT(PropertyCallbackArguments::kShouldThrowOnErrorIndex == 0); - STATIC_ASSERT(PropertyCallbackArguments::kHolderIndex == 1); - STATIC_ASSERT(PropertyCallbackArguments::kIsolateIndex == 2); - STATIC_ASSERT(PropertyCallbackArguments::kReturnValueDefaultValueIndex == 3); - STATIC_ASSERT(PropertyCallbackArguments::kReturnValueOffset == 4); - STATIC_ASSERT(PropertyCallbackArguments::kDataIndex == 5); - STATIC_ASSERT(PropertyCallbackArguments::kThisIndex == 6); - STATIC_ASSERT(PropertyCallbackArguments::kArgsLength == 7); - - // Here and below +1 is for name() pushed after the args_ array. - typedef PropertyCallbackArguments PCA; - __ Subu(sp, sp, (PCA::kArgsLength + 1) * kPointerSize); - __ sw(receiver(), MemOperand(sp, (PCA::kThisIndex + 1) * kPointerSize)); + Register reg, Handle<ExecutableAccessorInfo> callback) { + // Build AccessorInfo::args_ list on the stack and push property name below + // the exit frame to make GC aware of them and store pointers to them. + STATIC_ASSERT(PropertyCallbackArguments::kHolderIndex == 0); + STATIC_ASSERT(PropertyCallbackArguments::kIsolateIndex == 1); + STATIC_ASSERT(PropertyCallbackArguments::kReturnValueDefaultValueIndex == 2); + STATIC_ASSERT(PropertyCallbackArguments::kReturnValueOffset == 3); + STATIC_ASSERT(PropertyCallbackArguments::kDataIndex == 4); + STATIC_ASSERT(PropertyCallbackArguments::kThisIndex == 5); + STATIC_ASSERT(PropertyCallbackArguments::kArgsLength == 6); + DCHECK(!scratch2().is(reg)); + DCHECK(!scratch3().is(reg)); + DCHECK(!scratch4().is(reg)); + __ push(receiver()); Handle<Object> data(callback->data(), isolate()); if (data->IsUndefined() || data->IsSmi()) { - __ li(scratch2(), data); + __ li(scratch3(), data); } else { Handle<WeakCell> cell = isolate()->factory()->NewWeakCell(Handle<HeapObject>::cast(data)); // The callback is alive if this instruction is executed, // so the weak cell is not cleared and points to data. - __ GetWeakValue(scratch2(), cell); + __ GetWeakValue(scratch3(), cell); } - __ sw(scratch2(), MemOperand(sp, (PCA::kDataIndex + 1) * kPointerSize)); - __ LoadRoot(scratch2(), Heap::kUndefinedValueRootIndex); - __ sw(scratch2(), - MemOperand(sp, (PCA::kReturnValueOffset + 1) * kPointerSize)); - __ sw(scratch2(), MemOperand(sp, (PCA::kReturnValueDefaultValueIndex + 1) * - kPointerSize)); - __ li(scratch2(), Operand(ExternalReference::isolate_address(isolate()))); - __ sw(scratch2(), MemOperand(sp, (PCA::kIsolateIndex + 1) * kPointerSize)); - __ sw(reg, MemOperand(sp, (PCA::kHolderIndex + 1) * kPointerSize)); - // should_throw_on_error -> false - DCHECK(Smi::FromInt(0) == nullptr); - __ sw(zero_reg, - MemOperand(sp, (PCA::kShouldThrowOnErrorIndex + 1) * kPointerSize)); - + __ Subu(sp, sp, 6 * kPointerSize); + __ sw(scratch3(), MemOperand(sp, 5 * kPointerSize)); + __ LoadRoot(scratch3(), Heap::kUndefinedValueRootIndex); + __ sw(scratch3(), MemOperand(sp, 4 * kPointerSize)); + __ sw(scratch3(), MemOperand(sp, 3 * kPointerSize)); + __ li(scratch4(), Operand(ExternalReference::isolate_address(isolate()))); + __ sw(scratch4(), MemOperand(sp, 2 * kPointerSize)); + __ sw(reg, MemOperand(sp, 1 * kPointerSize)); __ sw(name(), MemOperand(sp, 0 * kPointerSize)); + __ Addu(scratch2(), sp, 1 * kPointerSize); + __ mov(a2, scratch2()); // Saved in case scratch2 == a1. // Abi for CallApiGetter. Register getter_address_reg = ApiGetterDescriptor::function_address(); @@ -713,8 +705,8 @@ void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) { Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( - Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback, - LanguageMode language_mode) { + Handle<JSObject> object, Handle<Name> name, + Handle<ExecutableAccessorInfo> callback) { Register holder_reg = Frontend(name); __ Push(receiver(), holder_reg); // Receiver. @@ -729,7 +721,6 @@ Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( __ push(at); __ li(at, Operand(name)); __ Push(at, value()); - __ Push(Smi::FromInt(language_mode)); // Do tail-call to the runtime system. __ TailCallRuntime(Runtime::kStoreCallbackProperty); @@ -778,7 +769,7 @@ Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal( } Counters* counters = isolate()->counters(); - __ IncrementCounter(counters->ic_named_load_global_stub(), 1, a1, a3); + __ IncrementCounter(counters->named_load_global_stub(), 1, a1, a3); if (IC::ICUseVector(kind())) { DiscardVectorAndSlot(); } diff --git a/src/ic/mips/ic-mips.cc b/src/ic/mips/ic-mips.cc index ae3615e3..a27d6b56 100644 --- a/src/ic/mips/ic-mips.cc +++ b/src/ic/mips/ic-mips.cc @@ -159,7 +159,8 @@ static void GenerateKeyedLoadReceiverCheck(MacroAssembler* masm, static void GenerateFastArrayLoad(MacroAssembler* masm, Register receiver, Register key, Register elements, Register scratch1, Register scratch2, - Register result, Label* slow) { + Register result, Label* slow, + LanguageMode language_mode) { // Register use: // // receiver - holds the receiver on entry. @@ -215,8 +216,13 @@ static void GenerateFastArrayLoad(MacroAssembler* masm, Register receiver, __ Branch(&check_next_prototype); __ bind(&absent); - __ LoadRoot(result, Heap::kUndefinedValueRootIndex); - __ Branch(&done); + if (is_strong(language_mode)) { + // Strong mode accesses must throw in this case, so call the runtime. + __ Branch(slow); + } else { + __ LoadRoot(result, Heap::kUndefinedValueRootIndex); + __ Branch(&done); + } __ bind(&in_bounds); // Fast case: Do the load. @@ -224,7 +230,8 @@ static void GenerateFastArrayLoad(MacroAssembler* masm, Register receiver, Operand(FixedArray::kHeaderSize - kHeapObjectTag)); // The key is a smi. STATIC_ASSERT(kSmiTag == 0 && kSmiTagSize < kPointerSizeLog2); - __ Lsa(at, scratch1, key, kPointerSizeLog2 - kSmiTagSize); + __ sll(at, key, kPointerSizeLog2 - kSmiTagSize); + __ addu(at, at, scratch1); __ lw(scratch2, MemOperand(at)); __ LoadRoot(at, Heap::kTheHoleValueRootIndex); @@ -264,7 +271,8 @@ static void GenerateKeyNameCheck(MacroAssembler* masm, Register key, __ bind(&unique); } -void LoadIC::GenerateNormal(MacroAssembler* masm) { + +void LoadIC::GenerateNormal(MacroAssembler* masm, LanguageMode language_mode) { Register dictionary = a0; DCHECK(!dictionary.is(LoadDescriptor::ReceiverRegister())); DCHECK(!dictionary.is(LoadDescriptor::NameRegister())); @@ -279,7 +287,7 @@ void LoadIC::GenerateNormal(MacroAssembler* masm) { // Dictionary load failed, go slow (but don't miss). __ bind(&slow); - GenerateRuntimeGetProperty(masm); + GenerateRuntimeGetProperty(masm, language_mode); } @@ -303,7 +311,7 @@ void LoadIC::GenerateMiss(MacroAssembler* masm) { DCHECK(!AreAliased(t0, t1, LoadWithVectorDescriptor::SlotRegister(), LoadWithVectorDescriptor::VectorRegister())); - __ IncrementCounter(isolate->counters()->ic_load_miss(), 1, t0, t1); + __ IncrementCounter(isolate->counters()->load_miss(), 1, t0, t1); LoadIC_PushArgs(masm); @@ -311,14 +319,17 @@ void LoadIC::GenerateMiss(MacroAssembler* masm) { __ TailCallRuntime(Runtime::kLoadIC_Miss); } -void LoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm) { + +void LoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm, + LanguageMode language_mode) { // The return address is in ra. __ mov(LoadIC_TempRegister(), LoadDescriptor::ReceiverRegister()); __ Push(LoadIC_TempRegister(), LoadDescriptor::NameRegister()); // Do tail-call to runtime routine. - __ TailCallRuntime(Runtime::kGetProperty); + __ TailCallRuntime(is_strong(language_mode) ? Runtime::kGetPropertyStrong + : Runtime::kGetProperty); } @@ -328,7 +339,7 @@ void KeyedLoadIC::GenerateMiss(MacroAssembler* masm) { DCHECK(!AreAliased(t0, t1, LoadWithVectorDescriptor::SlotRegister(), LoadWithVectorDescriptor::VectorRegister())); - __ IncrementCounter(isolate->counters()->ic_keyed_load_miss(), 1, t0, t1); + __ IncrementCounter(isolate->counters()->keyed_load_miss(), 1, t0, t1); LoadIC_PushArgs(masm); @@ -336,16 +347,21 @@ void KeyedLoadIC::GenerateMiss(MacroAssembler* masm) { __ TailCallRuntime(Runtime::kKeyedLoadIC_Miss); } -void KeyedLoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm) { + +void KeyedLoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm, + LanguageMode language_mode) { // The return address is in ra. __ Push(LoadDescriptor::ReceiverRegister(), LoadDescriptor::NameRegister()); // Do tail-call to runtime routine. - __ TailCallRuntime(Runtime::kKeyedGetProperty); + __ TailCallRuntime(is_strong(language_mode) ? Runtime::kKeyedGetPropertyStrong + : Runtime::kKeyedGetProperty); } -void KeyedLoadIC::GenerateMegamorphic(MacroAssembler* masm) { + +void KeyedLoadIC::GenerateMegamorphic(MacroAssembler* masm, + LanguageMode language_mode) { // The return address is in ra. Label slow, check_name, index_smi, index_name, property_array_property; Label probe_dictionary, check_number_dictionary; @@ -369,9 +385,9 @@ void KeyedLoadIC::GenerateMegamorphic(MacroAssembler* masm) { // Check the receiver's map to see if it has fast elements. __ CheckFastElements(a0, a3, &check_number_dictionary); - GenerateFastArrayLoad(masm, receiver, key, a0, a3, t0, v0, &slow); - __ IncrementCounter(isolate->counters()->ic_keyed_load_generic_smi(), 1, t0, - a3); + GenerateFastArrayLoad(masm, receiver, key, a0, a3, t0, v0, &slow, + language_mode); + __ IncrementCounter(isolate->counters()->keyed_load_generic_smi(), 1, t0, a3); __ Ret(); __ bind(&check_number_dictionary); @@ -389,9 +405,9 @@ void KeyedLoadIC::GenerateMegamorphic(MacroAssembler* masm) { // Slow case, key and receiver still in a2 and a1. __ bind(&slow); - __ IncrementCounter(isolate->counters()->ic_keyed_load_generic_slow(), 1, t0, + __ IncrementCounter(isolate->counters()->keyed_load_generic_slow(), 1, t0, a3); - GenerateRuntimeGetProperty(masm); + GenerateRuntimeGetProperty(masm, language_mode); __ bind(&check_name); GenerateKeyNameCheck(masm, key, a0, a3, &index_name, &slow); @@ -435,8 +451,8 @@ void KeyedLoadIC::GenerateMegamorphic(MacroAssembler* masm) { GenerateGlobalInstanceTypeCheck(masm, a0, &slow); // Load the property to v0. GenerateDictionaryLoad(masm, &slow, a3, key, v0, t1, t0); - __ IncrementCounter(isolate->counters()->ic_keyed_load_generic_symbol(), 1, - t0, a3); + __ IncrementCounter(isolate->counters()->keyed_load_generic_symbol(), 1, t0, + a3); __ Ret(); __ bind(&index_name); @@ -475,7 +491,8 @@ static void KeyedStoreGenerateMegamorphicHelper( // there may be a callback on the element. Label holecheck_passed1; __ Addu(address, elements, FixedArray::kHeaderSize - kHeapObjectTag); - __ Lsa(address, address, key, kPointerSizeLog2 - kSmiTagSize); + __ sll(at, key, kPointerSizeLog2 - kSmiTagSize); + __ addu(address, address, at); __ lw(scratch, MemOperand(address)); __ Branch(&holecheck_passed1, ne, scratch, Operand(masm->isolate()->factory()->the_hole_value())); @@ -494,7 +511,8 @@ static void KeyedStoreGenerateMegamorphicHelper( } // It's irrelevant whether array is smi-only or not when writing a smi. __ Addu(address, elements, Operand(FixedArray::kHeaderSize - kHeapObjectTag)); - __ Lsa(address, address, key, kPointerSizeLog2 - kSmiTagSize); + __ sll(scratch, key, kPointerSizeLog2 - kSmiTagSize); + __ Addu(address, address, scratch); __ sw(value, MemOperand(address)); __ Ret(); @@ -510,7 +528,8 @@ static void KeyedStoreGenerateMegamorphicHelper( __ sw(scratch, FieldMemOperand(receiver, JSArray::kLengthOffset)); } __ Addu(address, elements, Operand(FixedArray::kHeaderSize - kHeapObjectTag)); - __ Lsa(address, address, key, kPointerSizeLog2 - kSmiTagSize); + __ sll(scratch, key, kPointerSizeLog2 - kSmiTagSize); + __ Addu(address, address, scratch); __ sw(value, MemOperand(address)); // Update write barrier for the elements array address. __ mov(scratch, value); // Preserve the value which is returned. @@ -531,7 +550,8 @@ static void KeyedStoreGenerateMegamorphicHelper( // go to the runtime. __ Addu(address, elements, Operand(FixedDoubleArray::kHeaderSize + kHoleNanUpper32Offset - kHeapObjectTag)); - __ Lsa(address, address, key, kPointerSizeLog2); + __ sll(at, key, kPointerSizeLog2); + __ addu(address, address, at); __ lw(scratch, MemOperand(address)); __ Branch(&fast_double_without_map_check, ne, scratch, Operand(kHoleNanUpper32)); @@ -771,11 +791,11 @@ void StoreIC::GenerateNormal(MacroAssembler* masm) { GenerateDictionaryStore(masm, &miss, dictionary, name, value, t2, t5); Counters* counters = masm->isolate()->counters(); - __ IncrementCounter(counters->ic_store_normal_hit(), 1, t2, t5); + __ IncrementCounter(counters->store_normal_hit(), 1, t2, t5); __ Ret(); __ bind(&miss); - __ IncrementCounter(counters->ic_store_normal_miss(), 1, t2, t5); + __ IncrementCounter(counters->store_normal_miss(), 1, t2, t5); GenerateMiss(masm); } diff --git a/src/ic/mips/stub-cache-mips.cc b/src/ic/mips/stub-cache-mips.cc index 039763c4..1a9897e8 100644 --- a/src/ic/mips/stub-cache-mips.cc +++ b/src/ic/mips/stub-cache-mips.cc @@ -42,11 +42,13 @@ static void ProbeTable(Isolate* isolate, MacroAssembler* masm, scratch = no_reg; // Multiply by 3 because there are 3 fields per entry (name, code, map). - __ Lsa(offset_scratch, offset, offset, 1); + __ sll(offset_scratch, offset, 1); + __ Addu(offset_scratch, offset_scratch, offset); // Calculate the base address of the entry. __ li(base_addr, Operand(key_offset)); - __ Lsa(base_addr, base_addr, offset_scratch, kPointerSizeLog2); + __ sll(at, offset_scratch, kPointerSizeLog2); + __ Addu(base_addr, base_addr, at); // Check that the key in the entry matches the name. __ lw(at, MemOperand(base_addr, 0)); |