diff options
| author | Elliott Hughes <enh@google.com> | 2017-05-09 15:20:53 -0700 |
|---|---|---|
| committer | Elliott Hughes <enh@google.com> | 2017-05-09 15:20:53 -0700 |
| commit | be226c47ee3e59f27c19ba771f54769b3c3b9d1d (patch) | |
| tree | 2bda4b9a419333e43cec13a8fa656c5905281228 | |
| parent | c9fc475448cb7d2cd023ed03ff4038dad1ff73e8 (diff) | |
| download | valgrind-be226c47ee3e59f27c19ba771f54769b3c3b9d1d.tar.gz | |
Don't build x86 valgrind.
valgrind's "supported platforms" page says:
x86/Linux: up to and including SSSE3, but not higher -- no SSE4, AVX, AVX2.
This target is in maintenance mode now..
AMD64/Linux: up to and including AVX2. This is the primary development
target and tends to be well supported.
A sentiment reiterated in the release notes for the current version:
Whilst 3.12.0 continues to support the 32-bit x86 instruction set, we
would prefer users to migrate to 64-bit x86 (a.k.a amd64 or x86_64)
where possible. Valgrind's support for 32-bit x86 has stagnated in
recent years and has fallen far behind that for 64-bit x86
instructions. By contrast 64-bit x86 is well supported, up to and
including AVX2.
Since our default build flags use SSE4 for x86, valgrind is not currently
usable.
Bug: http://b/38034461
Test: N/A
Change-Id: I97e5244d79c95c613ac43b98e6ee35d445c1b9f5
| -rw-r--r-- | Android.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Android.mk b/Android.mk index 1786805c8..a192c2e7b 100644 --- a/Android.mk +++ b/Android.mk @@ -16,7 +16,7 @@ LOCAL_PATH:= $(call my-dir) ANDROID_HARDWARE := ANDROID_HARDWARE_generic -ifneq ($(filter arm arm64 x86 x86_64,$(TARGET_ARCH)),) +ifneq ($(filter arm arm64 x86_64,$(TARGET_ARCH)),) vg_arch:=$(TARGET_ARCH) |