diff options
| author | Emma Anholt <emma@anholt.net> | 2021-09-10 12:45:20 -0700 |
|---|---|---|
| committer | Chia-I Wu <olvaffe@gmail.com> | 2021-09-13 17:28:12 +0000 |
| commit | 6f0af537de89d221bc354847e7da5b9dad95b917 (patch) | |
| tree | 73240bf3d8230d75de35d182efb5f759b90559c7 | |
| parent | 318fb537a429ac4c5249f5aa8515b0c11b2bbbe0 (diff) | |
| download | virglrenderer-6f0af537de89d221bc354847e7da5b9dad95b917.tar.gz | |
vrend: Make the compile failure path return value consistent.
It doesn't end up getting used because the sub_ctx->prog check happens
first, but let's not return a surprising truthy value from one fail
path of a bool function.
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
| -rw-r--r-- | src/vrend_renderer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c index dd31b4f1..27e2efd3 100644 --- a/src/vrend_renderer.c +++ b/src/vrend_renderer.c @@ -4672,7 +4672,7 @@ vrend_select_program(struct vrend_sub_context *sub_ctx, const struct pipe_draw_i struct vrend_shader *shader = sel->current; if (shader && !shader->is_compiled) {//shader->sel->type == PIPE_SHADER_FRAGMENT || shader->sel->type == PIPE_SHADER_GEOMETRY) { if (!vrend_compile_shader(sub_ctx, shader)) - return -1; + return false; } if (vrend_state.use_gles && sel->sinfo.gles_use_tex_query_level) gles_emulate_query_texture_levels_mask |= 1 << i; |