aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnonymous <no-reply@google.com>2017-09-27 17:40:51 +0000
committerandroid-build-merger <android-build-merger@google.com>2017-09-27 17:40:51 +0000
commit2b6245c946f668b02a410cef05a982a4a7c7bf7a (patch)
tree3ad9d0d376af6f97c8ff9c2505237a638201e07b
parentb930874b3a8ea95206fe44d13db20a2b1b18bad6 (diff)
parent2021ca6a6c3fa80646220cb97746f0b1cd3ae103 (diff)
downloadvolley-2b6245c946f668b02a410cef05a982a4a7c7bf7a.tar.gz
Import of Volley from GitHub to AOSP.
am: 2021ca6a6c Change-Id: I9b725e4fe67e0b628d99c06f455e272f7c854fca
-rw-r--r--src/main/java/com/android/volley/CacheDispatcher.java1
-rw-r--r--src/test/java/com/android/volley/CacheDispatcherTest.java27
2 files changed, 28 insertions, 0 deletions
diff --git a/src/main/java/com/android/volley/CacheDispatcher.java b/src/main/java/com/android/volley/CacheDispatcher.java
index 51dfd9c..b0432f3 100644
--- a/src/main/java/com/android/volley/CacheDispatcher.java
+++ b/src/main/java/com/android/volley/CacheDispatcher.java
@@ -229,6 +229,7 @@ public class CacheDispatcher extends Thread {
}
Request<?> nextInLine = waitingRequests.remove(0);
mWaitingRequests.put(cacheKey, waitingRequests);
+ nextInLine.setNetworkRequestCompleteListener(this);
try {
mCacheDispatcher.mNetworkQueue.put(nextInLine);
} catch (InterruptedException iex) {
diff --git a/src/test/java/com/android/volley/CacheDispatcherTest.java b/src/test/java/com/android/volley/CacheDispatcherTest.java
index 54886f8..a39be7b 100644
--- a/src/test/java/com/android/volley/CacheDispatcherTest.java
+++ b/src/test/java/com/android/volley/CacheDispatcherTest.java
@@ -124,6 +124,33 @@ public class CacheDispatcherTest {
assertFalse(mDelivery.postResponse_called);
}
+ @Test public void tripleCacheMiss_networkErrorOnFirst() throws Exception {
+ MockRequest secondRequest = new MockRequest();
+ MockRequest thirdRequest = new MockRequest();
+ mRequest.setSequence(1);
+ secondRequest.setSequence(2);
+ thirdRequest.setSequence(3);
+ mCacheQueue.add(mRequest);
+ mCacheQueue.add(secondRequest);
+ mCacheQueue.add(thirdRequest);
+ mCacheQueue.waitUntilEmpty(TIMEOUT_MILLIS);
+
+ assertTrue(mNetworkQueue.size() == 1);
+ assertFalse(mDelivery.postResponse_called);
+
+ Request request = mNetworkQueue.take();
+ request.notifyListenerResponseNotUsable();
+ // Second request should now be in network queue.
+ assertTrue(mNetworkQueue.size() == 1);
+ request = mNetworkQueue.take();
+ assertTrue(request.equals(secondRequest));
+ // Another unusable response, third request should now be added.
+ request.notifyListenerResponseNotUsable();
+ assertTrue(mNetworkQueue.size() == 1);
+ request = mNetworkQueue.take();
+ assertTrue(request.equals(thirdRequest));
+ }
+
@Test public void duplicateSoftExpiredCacheHit_failedRequest() throws Exception {
Cache.Entry entry = CacheTestUtils.makeRandomCacheEntry(null, false, true);
mCache.setEntryToReturn(entry);