diff options
author | Zdeněk Kořán <zkoran@gmail.com> | 2015-01-20 22:45:25 +0100 |
---|---|---|
committer | Zdeněk Kořán <zkoran@gmail.com> | 2015-01-20 22:45:25 +0100 |
commit | 6bafd7d28fc7947f263feb7134fc8a70084357c3 (patch) | |
tree | 40d34913ae2c7afff4f611043dcf70cb267654ca /src/main | |
parent | 1a39583f0ee06329f7918ed9a4c7d0e7cd342917 (diff) | |
download | volley-6bafd7d28fc7947f263feb7134fc8a70084357c3.tar.gz |
Change the default character encoding for JSON responses to UTF-8
According to RFC 7159 (Section 8.1), the default encoding of JSON should be UTF-8.
Using ISO-8859-1 as default causes incompatibility with some JSON APIs (e.g. wrong interpretation of internationalized strings).
Diffstat (limited to 'src/main')
4 files changed, 22 insertions, 10 deletions
diff --git a/src/main/java/com/android/volley/toolbox/HttpHeaderParser.java b/src/main/java/com/android/volley/toolbox/HttpHeaderParser.java index cb08432..601ac0f 100644 --- a/src/main/java/com/android/volley/toolbox/HttpHeaderParser.java +++ b/src/main/java/com/android/volley/toolbox/HttpHeaderParser.java @@ -115,10 +115,14 @@ public class HttpHeaderParser { } /** - * Returns the charset specified in the Content-Type of this header, - * or the HTTP default (ISO-8859-1) if none can be found. + * Retrieve a charset from headers + * + * @param headers An {@link java.util.Map} of headers + * @param defaultCharset Charset to return if none can be found + * @return Returns the charset specified in the Content-Type of this header, + * or the defaultCharset if none can be found. */ - public static String parseCharset(Map<String, String> headers) { + public static String parseCharset(Map<String, String> headers, String defaultCharset) { String contentType = headers.get(HTTP.CONTENT_TYPE); if (contentType != null) { String[] params = contentType.split(";"); @@ -132,6 +136,14 @@ public class HttpHeaderParser { } } - return HTTP.DEFAULT_CONTENT_CHARSET; + return defaultCharset; + } + + /** + * Returns the charset specified in the Content-Type of this header, + * or the HTTP default (ISO-8859-1) if none can be found. + */ + public static String parseCharset(Map<String, String> headers) { + return parseCharset(headers, HTTP.DEFAULT_CONTENT_CHARSET); } } diff --git a/src/main/java/com/android/volley/toolbox/JsonArrayRequest.java b/src/main/java/com/android/volley/toolbox/JsonArrayRequest.java index b1eae80..e932a61 100644 --- a/src/main/java/com/android/volley/toolbox/JsonArrayRequest.java +++ b/src/main/java/com/android/volley/toolbox/JsonArrayRequest.java @@ -45,8 +45,8 @@ public class JsonArrayRequest extends JsonRequest<JSONArray> { @Override protected Response<JSONArray> parseNetworkResponse(NetworkResponse response) { try { - String jsonString = - new String(response.data, HttpHeaderParser.parseCharset(response.headers)); + String jsonString = new String(response.data, + HttpHeaderParser.parseCharset(response.headers, PROTOCOL_CHARSET)); return Response.success(new JSONArray(jsonString), HttpHeaderParser.parseCacheHeaders(response)); } catch (UnsupportedEncodingException e) { diff --git a/src/main/java/com/android/volley/toolbox/JsonObjectRequest.java b/src/main/java/com/android/volley/toolbox/JsonObjectRequest.java index 74821cb..2991898 100644 --- a/src/main/java/com/android/volley/toolbox/JsonObjectRequest.java +++ b/src/main/java/com/android/volley/toolbox/JsonObjectRequest.java @@ -63,8 +63,8 @@ public class JsonObjectRequest extends JsonRequest<JSONObject> { @Override protected Response<JSONObject> parseNetworkResponse(NetworkResponse response) { try { - String jsonString = - new String(response.data, HttpHeaderParser.parseCharset(response.headers)); + String jsonString = new String(response.data, + HttpHeaderParser.parseCharset(response.headers, PROTOCOL_CHARSET)); return Response.success(new JSONObject(jsonString), HttpHeaderParser.parseCacheHeaders(response)); } catch (UnsupportedEncodingException e) { diff --git a/src/main/java/com/android/volley/toolbox/JsonRequest.java b/src/main/java/com/android/volley/toolbox/JsonRequest.java index f11ac14..95f4ecb 100644 --- a/src/main/java/com/android/volley/toolbox/JsonRequest.java +++ b/src/main/java/com/android/volley/toolbox/JsonRequest.java @@ -32,8 +32,8 @@ import java.io.UnsupportedEncodingException; * @param <T> JSON type of response expected */ public abstract class JsonRequest<T> extends Request<T> { - /** Charset for request. */ - private static final String PROTOCOL_CHARSET = "utf-8"; + /** Default charset for JSON request. */ + protected static final String PROTOCOL_CHARSET = "utf-8"; /** Content type for request. */ private static final String PROTOCOL_CONTENT_TYPE = |